github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #422] [CLOSED] Remove the “…” menu in the sidebar #3122

New Issue
Closed
opened 2026-02-28 20:36:46 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:36:46 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/422
Author: @j-f1
Created: 1/2/2023
Status: ❌ Closed

Base: master ← Head: more-sidebar-tweaks

📝 Commits (10+)

  • 27d0ff8 move “Find schedules” to a button on the Schedules page
  • 168f9d4 Adjust schedule routes to be under /schedules
  • 81d51cf fix matching sidebar links (sorta)
  • 3f3689f Split the Settings component into multiple files
  • f15bee6 Move Fix Splits to Settings → Advanced
  • 5a1a47a Remove outdated notifications
  • 9ea8d72 …wait that means the Fix Splits tool is also no longer needed
  • a4b28dd Move Settings + Help to “More Tools”
  • 22f33c5 Move the “Close” button to an explicit back button
  • 4d0e0dd Change the sidebar toggle to be a pin icon to disambiguate

📊 Changes

18 files changed (+557 additions, -618 deletions)

View changed files

📝 packages/desktop-client/src/components/FinancesApp.js (+1 -3)
➖ packages/desktop-client/src/components/Settings.js (+0 -387)
📝 packages/desktop-client/src/components/SidebarWithData.js (+1 -1)
📝 packages/desktop-client/src/components/Titlebar.js (+7 -5)
📝 packages/desktop-client/src/components/manager/ManagementApp.js (+8 -0)
📝 packages/desktop-client/src/components/schedules/index.js (+13 -1)
➕ packages/desktop-client/src/components/settings/Encryption.js (+49 -0)
➕ packages/desktop-client/src/components/settings/Export.js (+30 -0)
➕ packages/desktop-client/src/components/settings/Format.js (+65 -0)
➕ packages/desktop-client/src/components/settings/Global.js (+75 -0)
➕ packages/desktop-client/src/components/settings/Reset.js (+61 -0)
➕ packages/desktop-client/src/components/settings/UI.js (+64 -0)
➕ packages/desktop-client/src/components/settings/index.js (+90 -0)
➖ packages/desktop-client/src/components/tools/FixSplitsTool.js (+0 -88)
📝 packages/loot-core/src/client/upgrade-notifications.js (+59 -56)
📝 packages/loot-core/src/server/prefs.js (+2 -0)
📝 packages/loot-design/src/components/common.js (+2 -12)
📝 packages/loot-design/src/components/sidebar.js (+30 -65)

📄 Description

I was introducing a relative to Actual, and they were confused by the existence of two “…” menu buttons. Now there’s just one!

UI:

  • Find Schedules is now a button on the Schedules page
  • the Settings and Help options have been moved to the More Tools panel
    • clarify that the settings apply only to the current budget
    • maybe rephrase “Actual Help”? I just realized it sounds like click here for the actual help page, not some impostor
  • Fix Split Transactions has been removed since the issues it fixes were never present in the OSS version as far as I can tell
  • Move the Close File action to a “back” button to the left of the budget name
  • remove the now-empty “…” menu at the top left
  • since the ���<<” icon is now confusable with the back button, I changed it to be a pin (which also matches its behavior)
  • add a “Help” link to the bottom left corner of the management app
Screenshot_2023-01-02 12 20 05

Code:

  • refactor the Settings page into ~1 file for each section
  • The code that displays notifications has been commented out since all of the notifications are from before the codebase was OSS and are therefore no longer relevant. Not deleting the code so it can serve as a template for future notifications

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/422 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 1/2/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `more-sidebar-tweaks` --- ### 📝 Commits (10+) - [`27d0ff8`](https://github.com/actualbudget/actual/commit/27d0ff8523c7c412b7ae7bea7bb23448bbeebd6a) move “Find schedules” to a button on the Schedules page - [`168f9d4`](https://github.com/actualbudget/actual/commit/168f9d446452ca8731de9530cb2cfff677614fc6) Adjust schedule routes to be under /schedules - [`81d51cf`](https://github.com/actualbudget/actual/commit/81d51cfae78ebf470faa5d0877aad6d32343a77f) fix matching sidebar links (sorta) - [`3f3689f`](https://github.com/actualbudget/actual/commit/3f3689fdad5220d8026c2305b453d65a67305451) Split the Settings component into multiple files - [`f15bee6`](https://github.com/actualbudget/actual/commit/f15bee630ffb102a1b9273b3ca2fa36dad04e13a) Move Fix Splits to Settings → Advanced - [`5a1a47a`](https://github.com/actualbudget/actual/commit/5a1a47aa9cae39f3a5191b7712715ca7303fc241) Remove outdated notifications - [`9ea8d72`](https://github.com/actualbudget/actual/commit/9ea8d722fe61a2c42b1862622277244919e450a0) …wait that means the Fix Splits tool is also no longer needed - [`a4b28dd`](https://github.com/actualbudget/actual/commit/a4b28dd4623aecb64f240b9ec1f825e03c5aa0b9) Move Settings + Help to “More Tools” - [`22f33c5`](https://github.com/actualbudget/actual/commit/22f33c5a571442e5fa117f0f6dff9d89d994fdad) Move the “Close” button to an explicit back button - [`4d0e0dd`](https://github.com/actualbudget/actual/commit/4d0e0dd831bfdce45cb23ae7ce651f8ddf4ee177) Change the sidebar toggle to be a pin icon to disambiguate ### 📊 Changes **18 files changed** (+557 additions, -618 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/FinancesApp.js` (+1 -3) ➖ `packages/desktop-client/src/components/Settings.js` (+0 -387) 📝 `packages/desktop-client/src/components/SidebarWithData.js` (+1 -1) 📝 `packages/desktop-client/src/components/Titlebar.js` (+7 -5) 📝 `packages/desktop-client/src/components/manager/ManagementApp.js` (+8 -0) 📝 `packages/desktop-client/src/components/schedules/index.js` (+13 -1) ➕ `packages/desktop-client/src/components/settings/Encryption.js` (+49 -0) ➕ `packages/desktop-client/src/components/settings/Export.js` (+30 -0) ➕ `packages/desktop-client/src/components/settings/Format.js` (+65 -0) ➕ `packages/desktop-client/src/components/settings/Global.js` (+75 -0) ➕ `packages/desktop-client/src/components/settings/Reset.js` (+61 -0) ➕ `packages/desktop-client/src/components/settings/UI.js` (+64 -0) ➕ `packages/desktop-client/src/components/settings/index.js` (+90 -0) ➖ `packages/desktop-client/src/components/tools/FixSplitsTool.js` (+0 -88) 📝 `packages/loot-core/src/client/upgrade-notifications.js` (+59 -56) 📝 `packages/loot-core/src/server/prefs.js` (+2 -0) 📝 `packages/loot-design/src/components/common.js` (+2 -12) 📝 `packages/loot-design/src/components/sidebar.js` (+30 -65) </details> ### 📄 Description I was introducing a relative to Actual, and they were confused by the existence of two “…” menu buttons. Now there’s just one! UI: - Find Schedules is now a button on the Schedules page - the Settings and Help options have been moved to the More Tools panel - clarify that the settings apply only to the current budget - maybe rephrase “Actual Help”? I just realized it sounds like click here for the _actual_ help page, not some impostor - Fix Split Transactions has been removed since the issues it fixes were never present in the OSS version as far as I can tell - Move the Close File action to a “back” button to the left of the budget name - remove the now-empty “…” menu at the top left - since the ���<<” icon is now confusable with the back button, I changed it to be a pin (which also matches its behavior) - add a “Help” link to the bottom left corner of the management app <img width="394" alt="Screenshot_2023-01-02 12 20 05" src="https://user-images.githubusercontent.com/25517624/210262461-a2795032-2a69-4d52-b4ad-c95493f058d5.png"> Code: - refactor the Settings page into ~1 file for each section - The code that displays notifications has been commented out since all of the notifications are from before the codebase was OSS and are therefore no longer relevant. Not deleting the code so it can serve as a template for future notifications --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:36:46 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3122
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?