[PR #4179] [MERGED] Remove unnecessary dispatch calls that are already being handled by shared-listeners.ts #31164

Closed
opened 2026-04-18 07:26:06 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4179
Author: @joel-jeremy
Created: 1/17/2025
Status: Merged
Merged: 1/23/2025
Merged by: @joel-jeremy

Base: masterHead: remove-duplicate-sync-event-listeners


📝 Commits (3)

  • 30aa328 Remove unnecessary dispatch calls that are already being handles by shared-listeners.ts
  • d45f1fd Release notes
  • 5de2d87 Fix lint error

📊 Changes

2 files changed (+22 additions, -36 deletions)

View changed files

📝 packages/loot-core/src/client/queries/queriesSlice.ts (+16 -36)
upcoming-release-notes/4179.md (+6 -0)

📄 Description

Follow up to https://github.com/actualbudget/actual/pull/4161

This will save us 1 DB call on each of the create/update/delete actions


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4179 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 1/17/2025 **Status:** ✅ Merged **Merged:** 1/23/2025 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `remove-duplicate-sync-event-listeners` --- ### 📝 Commits (3) - [`30aa328`](https://github.com/actualbudget/actual/commit/30aa32890c7b7e25063a73c0870f2d14c2f1750e) Remove unnecessary dispatch calls that are already being handles by shared-listeners.ts - [`d45f1fd`](https://github.com/actualbudget/actual/commit/d45f1fdaa02a67eeea68d0c8745fde5d6424e3a5) Release notes - [`5de2d87`](https://github.com/actualbudget/actual/commit/5de2d8736b791550e383548ad62304f5df9f285b) Fix lint error ### 📊 Changes **2 files changed** (+22 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/client/queries/queriesSlice.ts` (+16 -36) ➕ `upcoming-release-notes/4179.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Follow up to https://github.com/actualbudget/actual/pull/4161 This will save us 1 DB call on each of the create/update/delete actions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 07:26:06 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#31164