github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #414] [MERGED] Fix condition mapping for payee rule creation from payee modal #3115

New Issue
Closed
opened 2026-02-28 20:36:37 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:36:37 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/414
Author: @winklevos
Created: 12/30/2022
Status: ✅ Merged
Merged: 1/14/2023
Merged by: @MatissJanis

Base: master ← Head: context-create-rule

📝 Commits (9)

  • c1555b2 Fix condition mapping for payee rule creation
  • f8d5fbc Merge branch 'master' into context-create-rule
  • 5a32f65 Merge branch 'actualbudget:master' into context-create-rule
  • 0b28ffc Align Payee rule creation UX
  • f15435c let rule
  • 769d335 ensure create rule works from rules page
  • 3011be5 Update packages/desktop-client/src/components/ManageRules.js
  • fdb73b1 remove null id prop, better action logic
  • aa5adcf fix incorrect rule action on new rule

📊 Changes

2 files changed (+31 additions, -17 deletions)

View changed files

📝 packages/desktop-client/src/components/ManageRules.js (+21 -12)
📝 packages/desktop-client/src/components/payees/ManagePayeesWithData.js (+10 -5)

📄 Description

Fixes bug where creating rule from Payee modal does not auto populate the condition with the payee.

Before
image

After
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/414 **Author:** [@winklevos](https://github.com/winklevos) **Created:** 12/30/2022 **Status:** ✅ Merged **Merged:** 1/14/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `context-create-rule` --- ### 📝 Commits (9) - [`c1555b2`](https://github.com/actualbudget/actual/commit/c1555b2945cb8928a0777a1791ea8fa90fa1c276) Fix condition mapping for payee rule creation - [`f8d5fbc`](https://github.com/actualbudget/actual/commit/f8d5fbce73901bbea1563ee7f07f1f6bd246267e) Merge branch 'master' into context-create-rule - [`5a32f65`](https://github.com/actualbudget/actual/commit/5a32f65aada6f165cc2a15d18c86fdf7e6c0bccf) Merge branch 'actualbudget:master' into context-create-rule - [`0b28ffc`](https://github.com/actualbudget/actual/commit/0b28ffc985b784d61ff404c0fc353e6254e34dcb) Align Payee rule creation UX - [`f15435c`](https://github.com/actualbudget/actual/commit/f15435cf9539d4e7079b4f4031dd04a95c6a504a) let rule - [`769d335`](https://github.com/actualbudget/actual/commit/769d3356220daf0bb7c142f4ab4f12f52d514a6d) ensure create rule works from rules page - [`3011be5`](https://github.com/actualbudget/actual/commit/3011be5a44a3781ed19b2691b431c21d6451aa7a) Update packages/desktop-client/src/components/ManageRules.js - [`fdb73b1`](https://github.com/actualbudget/actual/commit/fdb73b17dd6d4c5ab70f34570c30c5a1396fc381) remove null id prop, better action logic - [`aa5adcf`](https://github.com/actualbudget/actual/commit/aa5adcf917cf37833a1bc2e9694a3e7ef067c1db) fix incorrect rule action on new rule ### 📊 Changes **2 files changed** (+31 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/ManageRules.js` (+21 -12) 📝 `packages/desktop-client/src/components/payees/ManagePayeesWithData.js` (+10 -5) </details> ### 📄 Description Fixes [bug](https://github.com/actualbudget/actual/issues/195) where creating rule from Payee modal does not auto populate the condition with the payee. **Before** ![image](https://user-images.githubusercontent.com/30995408/210022994-385811f5-9876-4a68-b2d8-712d5574cb5d.png) **After** ![image](https://user-images.githubusercontent.com/30995408/210023006-2abd2992-4012-4e73-81c8-e69fb4ad3f98.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:36:37 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3115
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?