github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #396] [MERGED] Avoid pulling in the bundled app from API in backend #3104

New Issue
Closed
opened 2026-02-28 20:36:24 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:36:24 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/396
Author: @jlongster
Created: 12/2/2022
Status: ✅ Merged
Merged: 12/2/2022
Merged by: @jlongster

Base: master ← Head: jlongster-avoid-api-bundle

📝 Commits (1)

  • c4d1303 Import only what's needed from the API for importer packages

📊 Changes

3 files changed (+13 additions, -6 deletions)

View changed files

📝 packages/api/index.js (+1 -2)
📝 packages/import-ynab4/importer.js (+7 -3)
📝 packages/import-ynab5/importer.js (+5 -1)

📄 Description

The backend imports the import-ynab4 and import-ynab5 packages, which we pulling in @actual-app/api directly. When we switched to the API using a full bundled version of the app, this is a problem. The importer packages are special because they are inlined directly into Actual, so although they invoke the API they are actually just running directly against Actual when in the app.

We can import just the methods from the API instead, which avoids pulling in the whole bundle. This fixes building the backend, and unblocks us to cut a release. Building the backend previously took many minutes (and resulted in a huge bundle) because it was embedding the API build; now it takes ~30 seconds.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/396 **Author:** [@jlongster](https://github.com/jlongster) **Created:** 12/2/2022 **Status:** ✅ Merged **Merged:** 12/2/2022 **Merged by:** [@jlongster](https://github.com/jlongster) **Base:** `master` ← **Head:** `jlongster-avoid-api-bundle` --- ### 📝 Commits (1) - [`c4d1303`](https://github.com/actualbudget/actual/commit/c4d1303691dd01f7fec5528b86216e46702e687d) Import only what's needed from the API for importer packages ### 📊 Changes **3 files changed** (+13 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/index.js` (+1 -2) 📝 `packages/import-ynab4/importer.js` (+7 -3) 📝 `packages/import-ynab5/importer.js` (+5 -1) </details> ### 📄 Description The backend imports the `import-ynab4` and `import-ynab5` packages, which we pulling in `@actual-app/api` directly. When we switched to the API using a full bundled version of the app, this is a problem. The importer packages are special because they are inlined directly into Actual, so although they invoke the API they are actually just running directly against Actual when in the app. We can import just the methods from the API instead, which avoids pulling in the whole bundle. This fixes building the backend, and unblocks us to cut a release. Building the backend previously took many minutes (and resulted in a huge bundle) because it was embedding the API build; now it takes ~30 seconds. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:36:24 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3104
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?