github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #387] [MERGED] Remove 32bit limit on amounts #3101

New Issue
Closed
opened 2026-02-28 20:36:22 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:36:22 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/387
Author: @jlongster
Created: 11/10/2022
Status: ✅ Merged
Merged: 11/13/2022
Merged by: @jlongster

Base: master ← Head: remove-32bit-limit-on-amounts

📝 Commits (10+)

  • 423f355 fix: use integer check which doesn't require value to be 32 bit
  • 75da379 fix: use 64bit compatible integer check in aql compiler
  • fb3e12b fix: replace custom isInteger function with Number.isInteger
  • f5417bc fix: use Math.round in place of truncating digits
  • 9a44236 fix: use Math.round in place of truncating digits
  • 6e15b98 fix: remove unnecessary conversion to 32 bit
  • 3a92594 fix: replace last usages of | 0
  • 6cbc223 feat: add explicit value checking on saving to / reading from budget
  • 496ef03 Move safeNumber to shared util and tweak implementation
  • e8a79c8 Fix lint

📊 Changes

22 files changed (+97 additions, -71 deletions)

View changed files

📝 packages/api/utils.js (+1 -1)
📝 packages/desktop-electron/index.js (+2 -2)
📝 packages/loot-core/bin/profile-sql.js (+7 -7)
📝 packages/loot-core/src/client/queries.js (+1 -5)
📝 packages/loot-core/src/client/query-helpers.test.js (+1 -1)
📝 packages/loot-core/src/mocks/budget.js (+6 -6)
📝 packages/loot-core/src/mocks/index.js (+4 -4)
📝 packages/loot-core/src/server/aql/compiler.js (+1 -1)
📝 packages/loot-core/src/server/aql/schema-helpers.js (+1 -1)
📝 packages/loot-core/src/server/aql/schema/executors.test.js (+1 -1)
📝 packages/loot-core/src/server/budget/actions.js (+4 -5)
📝 packages/loot-core/src/server/budget/report.js (+9 -8)
📝 packages/loot-core/src/server/budget/rollover.js (+19 -15)
📝 packages/loot-core/src/server/budget/util.js (+6 -3)
📝 packages/loot-core/src/server/crdt/merkle.js (+1 -1)
📝 packages/loot-core/src/server/db/sort.js (+1 -1)
📝 packages/loot-core/src/server/sync/sync.property.test.js (+1 -1)
📝 packages/loot-core/src/shared/rules.js (+1 -1)
📝 packages/loot-core/src/shared/schedules.js (+1 -1)
📝 packages/loot-core/src/shared/util.js (+26 -3)

...and 2 more files

📄 Description

Rebased version of https://github.com/actualbudget/actual/pull/138

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/387 **Author:** [@jlongster](https://github.com/jlongster) **Created:** 11/10/2022 **Status:** ✅ Merged **Merged:** 11/13/2022 **Merged by:** [@jlongster](https://github.com/jlongster) **Base:** `master` ← **Head:** `remove-32bit-limit-on-amounts` --- ### 📝 Commits (10+) - [`423f355`](https://github.com/actualbudget/actual/commit/423f355766198f0b0502051c489c56707292c7f0) fix: use integer check which doesn't require value to be 32 bit - [`75da379`](https://github.com/actualbudget/actual/commit/75da379079c320b688d053c139258745d5ba2097) fix: use 64bit compatible integer check in aql compiler - [`fb3e12b`](https://github.com/actualbudget/actual/commit/fb3e12b8a7e78ad40b8798f1061233d988a55200) fix: replace custom isInteger function with Number.isInteger - [`f5417bc`](https://github.com/actualbudget/actual/commit/f5417bcc8d414a03c5641e7e5c3010c396437599) fix: use Math.round in place of truncating digits - [`9a44236`](https://github.com/actualbudget/actual/commit/9a442361ad706a304d55824a34247e0139f2ae35) fix: use Math.round in place of truncating digits - [`6e15b98`](https://github.com/actualbudget/actual/commit/6e15b985cbd9005427d10218cfe406a4717dce66) fix: remove unnecessary conversion to 32 bit - [`3a92594`](https://github.com/actualbudget/actual/commit/3a925948e2a6dee76f6d710fe3e35c48a5087797) fix: replace last usages of | 0 - [`6cbc223`](https://github.com/actualbudget/actual/commit/6cbc22312fbfe6d0c55d46e4a433664f24f58c2d) feat: add explicit value checking on saving to / reading from budget - [`496ef03`](https://github.com/actualbudget/actual/commit/496ef039b712343471c9c011fea8467865c07ceb) Move `safeNumber` to shared util and tweak implementation - [`e8a79c8`](https://github.com/actualbudget/actual/commit/e8a79c8dbf8b8b8576f4256552558dfe4bd4d0b2) Fix lint ### 📊 Changes **22 files changed** (+97 additions, -71 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/utils.js` (+1 -1) 📝 `packages/desktop-electron/index.js` (+2 -2) 📝 `packages/loot-core/bin/profile-sql.js` (+7 -7) 📝 `packages/loot-core/src/client/queries.js` (+1 -5) 📝 `packages/loot-core/src/client/query-helpers.test.js` (+1 -1) 📝 `packages/loot-core/src/mocks/budget.js` (+6 -6) 📝 `packages/loot-core/src/mocks/index.js` (+4 -4) 📝 `packages/loot-core/src/server/aql/compiler.js` (+1 -1) 📝 `packages/loot-core/src/server/aql/schema-helpers.js` (+1 -1) 📝 `packages/loot-core/src/server/aql/schema/executors.test.js` (+1 -1) 📝 `packages/loot-core/src/server/budget/actions.js` (+4 -5) 📝 `packages/loot-core/src/server/budget/report.js` (+9 -8) 📝 `packages/loot-core/src/server/budget/rollover.js` (+19 -15) 📝 `packages/loot-core/src/server/budget/util.js` (+6 -3) 📝 `packages/loot-core/src/server/crdt/merkle.js` (+1 -1) 📝 `packages/loot-core/src/server/db/sort.js` (+1 -1) 📝 `packages/loot-core/src/server/sync/sync.property.test.js` (+1 -1) 📝 `packages/loot-core/src/shared/rules.js` (+1 -1) 📝 `packages/loot-core/src/shared/schedules.js` (+1 -1) 📝 `packages/loot-core/src/shared/util.js` (+26 -3) _...and 2 more files_ </details> ### 📄 Description Rebased version of https://github.com/actualbudget/actual/pull/138 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:36:22 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3101
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?