github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #354] [MERGED] Schedules editor: exclude closed accounts in Account autocomplete #3092

New Issue
Closed
opened 2026-02-28 20:36:13 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:36:13 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/354
Author: @trevdor
Created: 10/18/2022
Status: ✅ Merged
Merged: 12/30/2022
Merged by: @MatissJanis

Base: master ← Head: bug/307-schedule-editor-closed-accounts

📝 Commits (2)

  • c33dc8d Schedules editor: exclude closed accounts in Account autocomplete
  • b131879 fixup! Schedules editor: exclude closed accounts in Account autocomplete

📊 Changes

2 files changed (+11 additions, -2 deletions)

View changed files

📝 packages/desktop-client/src/components/schedules/EditSchedule.js (+1 -0)
📝 packages/loot-design/src/components/AccountAutocomplete.js (+10 -2)

📄 Description

Fixes https://github.com/actualbudget/actual/issues/307

Gave AccountAutocomplete a prop for including closed accounts and defaulted it to false.
To fix the Account dropdown in the Schedule editor, that particular dropdown will use the default.
However, for the lightest touch, every other AccountAutocomplete will specify includeClosedAccounts for the moment, which will leave them as they are today.

Show 'n' Tell

BEFORE
bug_307_before

AFTER
bug_307_after

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/354 **Author:** [@trevdor](https://github.com/trevdor) **Created:** 10/18/2022 **Status:** ✅ Merged **Merged:** 12/30/2022 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `bug/307-schedule-editor-closed-accounts` --- ### 📝 Commits (2) - [`c33dc8d`](https://github.com/actualbudget/actual/commit/c33dc8d848a29201ca9b282507ecb06bb477cb94) Schedules editor: exclude closed accounts in Account autocomplete - [`b131879`](https://github.com/actualbudget/actual/commit/b131879d309e705a4c2370149d320ce0bef719ae) fixup! Schedules editor: exclude closed accounts in Account autocomplete ### 📊 Changes **2 files changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/schedules/EditSchedule.js` (+1 -0) 📝 `packages/loot-design/src/components/AccountAutocomplete.js` (+10 -2) </details> ### 📄 Description Fixes https://github.com/actualbudget/actual/issues/307 Gave AccountAutocomplete a prop for including closed accounts and defaulted it to false. To fix the Account dropdown in the Schedule editor, that particular dropdown will use the default. However, for the lightest touch, every other AccountAutocomplete will specify includeClosedAccounts for the moment, which will leave them as they are today. ## Show 'n' Tell **BEFORE** ![bug_307_before](https://user-images.githubusercontent.com/5862724/196810301-dc7feeda-5240-46b1-b80a-aa75d0ca401d.gif) **AFTER** ![bug_307_after](https://user-images.githubusercontent.com/5862724/196810399-48ca5b97-f8ad-4556-91e5-d913617be346.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:36:13 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3092
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?