github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #265] [MERGED] Allow enabling end-to-end encryption again #3084

New Issue
Closed
opened 2026-02-28 20:36:03 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:36:03 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/265
Author: @j-f1
Created: 10/7/2022
Status: ✅ Merged
Merged: 1/16/2023
Merged by: @MatissJanis

Base: master ← Head: enable-e2e

📝 Commits (10+)

  • b16b185 Update messaging about encryption to reflect self-hosting
  • 4a9d77c Restore button to enable encryption
  • 6ac2167 Fix whitespace
  • 05d0a36 Merge remote-tracking branch 'upstream/master' into enable-e2e
  • badb549 Merge remote-tracking branch 'upstream/master' into enable-e2e
  • 3d41ecd Update language to clarify that a different password should be used
  • 5eae202 Block enabling e2e without a server
  • 647688b Learn more…
  • 04ec9d7 Merge remote-tracking branch 'upstream/master' into enable-e2e
  • 7d5cdb8 Apply suggestions from code review

📊 Changes

2 files changed (+48 additions, -18 deletions)

View changed files

📝 packages/desktop-client/src/components/modals/CreateEncryptionKey.js (+7 -3)
📝 packages/desktop-client/src/components/settings/Encryption.js (+41 -15)

📄 Description

I would greatly appreciate feedback on this wording:

Encryption is not enabled. Your data is still stored on your server, but if you do not fully trust the security of the server, you can enable encryption to ensure that your data is encrypted on the server.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/265 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 10/7/2022 **Status:** ✅ Merged **Merged:** 1/16/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `enable-e2e` --- ### 📝 Commits (10+) - [`b16b185`](https://github.com/actualbudget/actual/commit/b16b185952dd0206cbba09ccc6f53834037a192c) Update messaging about encryption to reflect self-hosting - [`4a9d77c`](https://github.com/actualbudget/actual/commit/4a9d77cf09be3523481a695319f65a7761e58240) Restore button to enable encryption - [`6ac2167`](https://github.com/actualbudget/actual/commit/6ac2167ff30a090a861705406ec2556a4160d2c0) Fix whitespace - [`05d0a36`](https://github.com/actualbudget/actual/commit/05d0a36c63bdb1c6934ff6e46135063584796f78) Merge remote-tracking branch 'upstream/master' into enable-e2e - [`badb549`](https://github.com/actualbudget/actual/commit/badb5490c9ad01bf262f29ffcb6c17b6c660b6eb) Merge remote-tracking branch 'upstream/master' into enable-e2e - [`3d41ecd`](https://github.com/actualbudget/actual/commit/3d41ecd1e408b8a539caaba8c5c4be7501b8a3c7) Update language to clarify that a different password should be used - [`5eae202`](https://github.com/actualbudget/actual/commit/5eae2028fb5666458d55fa6699379e5325eb11e7) Block enabling e2e without a server - [`647688b`](https://github.com/actualbudget/actual/commit/647688ba65a85ad802b78efa5a51272f84f44e7d) Learn more… - [`04ec9d7`](https://github.com/actualbudget/actual/commit/04ec9d7d0d9f0d87d36708eb033dbcb9ccb19654) Merge remote-tracking branch 'upstream/master' into enable-e2e - [`7d5cdb8`](https://github.com/actualbudget/actual/commit/7d5cdb812c948d5bb0a89c037f1abfe13e3cad5f) Apply suggestions from code review ### 📊 Changes **2 files changed** (+48 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/modals/CreateEncryptionKey.js` (+7 -3) 📝 `packages/desktop-client/src/components/settings/Encryption.js` (+41 -15) </details> ### 📄 Description I would greatly appreciate feedback on this wording: > Encryption is not enabled. Your data is still stored on your server, but if you do not fully trust the security of the server, you can enable encryption to ensure that your data is encrypted on the server. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:36:03 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3084
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?