github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #225] [MERGED] Implement localization for schedule descriptions #3067

New Issue
Closed
opened 2026-02-28 20:35:50 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:35:50 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/225
Author: @j-f1
Created: 8/31/2022
Status: ✅ Merged
Merged: 9/8/2022
Merged by: @TomAFrench

Base: i18n ← Head: i18n-schedules

📝 Commits (10+)

  • ae85b2c monthUtils.{format → nonLocalizedFormat}
  • 3ac824a Implement localization for schedule descriptions
  • 2c4caa1 Remove outdated comment
  • ee37819 Add general.ordinal in Spanish
  • 75b261c yay time zones?
  • 7c11113 Merge branch 'i18n' into i18n-schedules
  • 7d82d82 Merge branch 'i18n' into i18n-schedules
  • f8baf30 fix: re-add missing keys
  • b1e391e fix: fix broken i18n imports/initialisation
  • 3c2b16f style: linting

📊 Changes

28 files changed (+376 additions, -169 deletions)

View changed files

📝 .github/workflows/i18n.yml (+1 -1)
📝 packages/desktop-client/i18next-parser.config.js (+1 -0)
📝 packages/desktop-client/src/components/budget/index.js (+1 -1)
📝 packages/desktop-client/src/components/modals/EditRule.js (+1 -1)
📝 packages/desktop-client/src/components/modals/ManageRules.js (+3 -1)
📝 packages/desktop-client/src/components/reports/CashFlow.js (+1 -1)
📝 packages/desktop-client/src/components/reports/NetWorth.js (+1 -1)
📝 packages/desktop-client/src/components/schedules/DiscoverSchedules.js (+2 -2)
📝 packages/desktop-client/src/components/schedules/EditSchedule.js (+3 -1)
📝 packages/desktop-client/src/components/schedules/SchedulesTable.js (+1 -1)
📝 packages/desktop-client/src/components/tutorial/Overspending.js (+1 -1)
📝 packages/desktop-client/src/locales/index.js (+8 -2)
➕ packages/loot-core/i18next-parser.config.js (+16 -0)
📝 packages/loot-core/package.json (+4 -1)
➕ packages/loot-core/src/locales/en-GB.json (+27 -0)
➕ packages/loot-core/src/locales/es-ES.json (+28 -0)
📝 packages/loot-core/src/shared/months.js (+3 -3)
📝 packages/loot-core/src/shared/schedules.js (+105 -50)
📝 packages/loot-core/src/shared/schedules.test.js (+145 -86)
📝 packages/loot-design/src/components/RecurringSchedulePicker.js (+6 -6)

...and 8 more files

📄 Description

cc @manuelcanepa — let me know if all of this makes sense for Spanish too :)

One thing I’m not super confident about is general.ordinal, but I’m not sure what the best approach for that is. (The Intl API doesn’t offer ordinal formatting for some reason)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/225 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 8/31/2022 **Status:** ✅ Merged **Merged:** 9/8/2022 **Merged by:** [@TomAFrench](https://github.com/TomAFrench) **Base:** `i18n` ← **Head:** `i18n-schedules` --- ### 📝 Commits (10+) - [`ae85b2c`](https://github.com/actualbudget/actual/commit/ae85b2cb588d298f4b0b0357a3683205f8295e07) monthUtils.{format → nonLocalizedFormat} - [`3ac824a`](https://github.com/actualbudget/actual/commit/3ac824a9a1fd701b14c12798ad0aeda10c5e8280) Implement localization for schedule descriptions - [`2c4caa1`](https://github.com/actualbudget/actual/commit/2c4caa100c0231da0788444d7cdaf63063b64bd3) Remove outdated comment - [`ee37819`](https://github.com/actualbudget/actual/commit/ee37819ed8ab045a972b21264e598e367c51b30e) Add general.ordinal in Spanish - [`75b261c`](https://github.com/actualbudget/actual/commit/75b261ccd62a0d59bd723c32a8e6e9f7dbff31ea) yay time zones? - [`7c11113`](https://github.com/actualbudget/actual/commit/7c111136df62ce03837fab9e3d0b907c00ce7d1a) Merge branch 'i18n' into i18n-schedules - [`7d82d82`](https://github.com/actualbudget/actual/commit/7d82d8269a959b82048e3a441be967c6615d5140) Merge branch 'i18n' into i18n-schedules - [`f8baf30`](https://github.com/actualbudget/actual/commit/f8baf30936286a79be56b98179c5cd3710dc77ed) fix: re-add missing keys - [`b1e391e`](https://github.com/actualbudget/actual/commit/b1e391eff44ff2d1a3db411121652a251f76d48e) fix: fix broken i18n imports/initialisation - [`3c2b16f`](https://github.com/actualbudget/actual/commit/3c2b16f9acb87a89604fee91e31a78d199a34355) style: linting ### 📊 Changes **28 files changed** (+376 additions, -169 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/i18n.yml` (+1 -1) 📝 `packages/desktop-client/i18next-parser.config.js` (+1 -0) 📝 `packages/desktop-client/src/components/budget/index.js` (+1 -1) 📝 `packages/desktop-client/src/components/modals/EditRule.js` (+1 -1) 📝 `packages/desktop-client/src/components/modals/ManageRules.js` (+3 -1) 📝 `packages/desktop-client/src/components/reports/CashFlow.js` (+1 -1) 📝 `packages/desktop-client/src/components/reports/NetWorth.js` (+1 -1) 📝 `packages/desktop-client/src/components/schedules/DiscoverSchedules.js` (+2 -2) 📝 `packages/desktop-client/src/components/schedules/EditSchedule.js` (+3 -1) 📝 `packages/desktop-client/src/components/schedules/SchedulesTable.js` (+1 -1) 📝 `packages/desktop-client/src/components/tutorial/Overspending.js` (+1 -1) 📝 `packages/desktop-client/src/locales/index.js` (+8 -2) ➕ `packages/loot-core/i18next-parser.config.js` (+16 -0) 📝 `packages/loot-core/package.json` (+4 -1) ➕ `packages/loot-core/src/locales/en-GB.json` (+27 -0) ➕ `packages/loot-core/src/locales/es-ES.json` (+28 -0) 📝 `packages/loot-core/src/shared/months.js` (+3 -3) 📝 `packages/loot-core/src/shared/schedules.js` (+105 -50) 📝 `packages/loot-core/src/shared/schedules.test.js` (+145 -86) 📝 `packages/loot-design/src/components/RecurringSchedulePicker.js` (+6 -6) _...and 8 more files_ </details> ### 📄 Description cc @manuelcanepa — let me know if all of this makes sense for Spanish too :) One thing I’m not super confident about is `general.ordinal`, but I’m not sure what the best approach for that is. (The `Intl` API doesn’t offer ordinal formatting for some reason) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:35:50 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3067
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?