github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #217] [MERGED] Remove unused imports and sort imports in desktop-client #3060

New Issue
Closed
opened 2026-02-28 20:35:44 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:35:44 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/217
Author: @TomAFrench
Created: 8/30/2022
Status: ✅ Merged
Merged: 8/30/2022
Merged by: @TomAFrench

Base: master ← Head: remove-unused-imports

📝 Commits (2)

  • 8e41d8d chore: remove unused imports from desktop-client
  • 887df1e refactor: sort imports in desktop-client alphabetically

📊 Changes

74 files changed (+129 additions, -368 deletions)

View changed files

📝 packages/desktop-client/src/components/App.js (+1 -1)
📝 packages/desktop-client/src/components/AppBackground.js (+2 -2)
📝 packages/desktop-client/src/components/BankSyncStatus.js (+1 -1)
📝 packages/desktop-client/src/components/Debugger.js (+1 -2)
📝 packages/desktop-client/src/components/FinancesApp.js (+5 -5)
📝 packages/desktop-client/src/components/LoggedInUser.js (+0 -2)
📝 packages/desktop-client/src/components/Modals.js (+4 -5)
📝 packages/desktop-client/src/components/Page.js (+1 -1)
📝 packages/desktop-client/src/components/Settings.js (+2 -9)
📝 packages/desktop-client/src/components/SidebarWithData.js (+0 -3)
📝 packages/desktop-client/src/components/SpreadsheetInterface.js (+1 -1)
📝 packages/desktop-client/src/components/SyncNotifications.js (+0 -10)
📝 packages/desktop-client/src/components/Titlebar.js (+2 -8)
📝 packages/desktop-client/src/components/Tutorial.js (+0 -4)
📝 packages/desktop-client/src/components/TutorialPoints.js (+0 -1)
📝 packages/desktop-client/src/components/UpdateNotification.js (+1 -7)
📝 packages/desktop-client/src/components/accounts/Account.js (+11 -39)
📝 packages/desktop-client/src/components/accounts/AccountSyncCheck.js (+1 -2)
📝 packages/desktop-client/src/components/accounts/Filters.js (+1 -2)
📝 packages/desktop-client/src/components/accounts/SimpleTransactionsTable.js (+1 -7)

...and 54 more files

📄 Description

There's a lot of unused imports in desktop-client which we can strip out to improve readability. I've run some linting rules to strip out unused imports and sort the remaining ones alphabetically.

In future I'd like to add the import sorting linting rule to the eslint config so it's enforced going forwards.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/217 **Author:** [@TomAFrench](https://github.com/TomAFrench) **Created:** 8/30/2022 **Status:** ✅ Merged **Merged:** 8/30/2022 **Merged by:** [@TomAFrench](https://github.com/TomAFrench) **Base:** `master` ← **Head:** `remove-unused-imports` --- ### 📝 Commits (2) - [`8e41d8d`](https://github.com/actualbudget/actual/commit/8e41d8d2dde7d780b15de10b3b92971c8a5dbe90) chore: remove unused imports from desktop-client - [`887df1e`](https://github.com/actualbudget/actual/commit/887df1e3884bcee17e5ad1678191749ba48fd996) refactor: sort imports in desktop-client alphabetically ### 📊 Changes **74 files changed** (+129 additions, -368 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/App.js` (+1 -1) 📝 `packages/desktop-client/src/components/AppBackground.js` (+2 -2) 📝 `packages/desktop-client/src/components/BankSyncStatus.js` (+1 -1) 📝 `packages/desktop-client/src/components/Debugger.js` (+1 -2) 📝 `packages/desktop-client/src/components/FinancesApp.js` (+5 -5) 📝 `packages/desktop-client/src/components/LoggedInUser.js` (+0 -2) 📝 `packages/desktop-client/src/components/Modals.js` (+4 -5) 📝 `packages/desktop-client/src/components/Page.js` (+1 -1) 📝 `packages/desktop-client/src/components/Settings.js` (+2 -9) 📝 `packages/desktop-client/src/components/SidebarWithData.js` (+0 -3) 📝 `packages/desktop-client/src/components/SpreadsheetInterface.js` (+1 -1) 📝 `packages/desktop-client/src/components/SyncNotifications.js` (+0 -10) 📝 `packages/desktop-client/src/components/Titlebar.js` (+2 -8) 📝 `packages/desktop-client/src/components/Tutorial.js` (+0 -4) 📝 `packages/desktop-client/src/components/TutorialPoints.js` (+0 -1) 📝 `packages/desktop-client/src/components/UpdateNotification.js` (+1 -7) 📝 `packages/desktop-client/src/components/accounts/Account.js` (+11 -39) 📝 `packages/desktop-client/src/components/accounts/AccountSyncCheck.js` (+1 -2) 📝 `packages/desktop-client/src/components/accounts/Filters.js` (+1 -2) 📝 `packages/desktop-client/src/components/accounts/SimpleTransactionsTable.js` (+1 -7) _...and 54 more files_ </details> ### 📄 Description There's a lot of unused imports in desktop-client which we can strip out to improve readability. I've run some linting rules to strip out unused imports and sort the remaining ones alphabetically. In future I'd like to add the import sorting linting rule to the eslint config so it's enforced going forwards. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:35:44 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3060
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?