[PR #2995] [MERGED] :electron: server.js ➡️ server.ts #30553

Closed
opened 2026-04-18 06:52:58 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2995
Author: @MikesGlitch
Created: 7/7/2024
Status: Merged
Merged: 7/7/2024
Merged by: @MatissJanis

Base: masterHead: ts/server-js-electron


📝 Commits (9)

📊 Changes

6 files changed (+38 additions, -29 deletions)

View changed files

📝 packages/desktop-electron/index.ts (+4 -6)
packages/desktop-electron/modules.d.ts (+8 -0)
packages/desktop-electron/server.html (+0 -8)
packages/desktop-electron/server.js (+0 -15)
packages/desktop-electron/server.ts (+20 -0)
upcoming-release-notes/2995.md (+6 -0)

📄 Description

  • Removed server.html - it's not used for anything. The server.js is imported directly
  • Converted server.js to server.ts

#1483


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2995 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 7/7/2024 **Status:** ✅ Merged **Merged:** 7/7/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `ts/server-js-electron` --- ### 📝 Commits (9) - [`e6446e3`](https://github.com/actualbudget/actual/commit/e6446e3604bd8278d965a635be95dab7c17bb97f) electron server js to ts - [`d672a39`](https://github.com/actualbudget/actual/commit/d672a3956e73c7fdb89544ac71389966db056a0e) import - [`30f7c9d`](https://github.com/actualbudget/actual/commit/30f7c9d9fca1536402bc6f873e670a93e5469f36) lint update - [`f68b429`](https://github.com/actualbudget/actual/commit/f68b4296f9240f5ba50146742771796e43fae98d) types - [`0cd55cd`](https://github.com/actualbudget/actual/commit/0cd55cd34a1ff8469718841726578c6c6cafa7a1) bundle added to module types - [`23a14f7`](https://github.com/actualbudget/actual/commit/23a14f7898492322cd6cd64895face6ee1c72dd8) removing api bundle - [`2993180`](https://github.com/actualbudget/actual/commit/2993180c019f38c3e8375bc7909797f7ecf52c97) so many annoyances - [`b53cf4c`](https://github.com/actualbudget/actual/commit/b53cf4c7f9fe5574d2421f394d9253bf52460009) release notes - [`a4d71d2`](https://github.com/actualbudget/actual/commit/a4d71d2db140626040829262a2ad562170a5665b) better module d ts typing ### 📊 Changes **6 files changed** (+38 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-electron/index.ts` (+4 -6) ➕ `packages/desktop-electron/modules.d.ts` (+8 -0) ➖ `packages/desktop-electron/server.html` (+0 -8) ➖ `packages/desktop-electron/server.js` (+0 -15) ➕ `packages/desktop-electron/server.ts` (+20 -0) ➕ `upcoming-release-notes/2995.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> - Removed server.html - it's not used for anything. The server.js is imported directly - Converted server.js to server.ts #1483 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 06:52:58 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#30553