mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-11 04:32:39 -05:00
[PR #205] [CLOSED] Add internationalisation framework #3053
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#3053
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/actualbudget/actual/pull/205
Author: @TomAFrench
Created: 8/24/2022
Status: ❌ Closed
Base:
master← Head:i18n📝 Commits (10+)
fd0d30cfeat: add skeleton of i18n framework9b3dbd1#199 Adding some translation to check if im doing rightdd9d32afix: ensure that translation keys match2d025d8fix: get bold tags to display correctly43740f1Merge branch 'master' into i18n5c56370feat: prevent translation keys which don't exist in locale filesa4fe219feat: fallback to english rather than showing translation key1fd3234ci: correct i18n job nameb0f0c4aci: fix workspace name in i18n job304a384style: format json with 2 space indents📊 Changes
43 files changed (+1926 additions, -411 deletions)
View changed files
➕
.github/workflows/i18n.yml(+18 -0)📝
packages/desktop-client/.gitignore(+3 -0)➕
packages/desktop-client/i18next-parser.config.js(+16 -0)📝
packages/desktop-client/package.json(+5 -1)📝
packages/desktop-client/src/components/accounts/Account.js(+109 -67)📝
packages/desktop-client/src/components/accounts/Filters.js(+14 -9)📝
packages/desktop-client/src/components/accounts/SimpleTransactionsTable.js(+9 -7)📝
packages/desktop-client/src/components/accounts/TransactionsTable.js(+36 -24)📝
packages/desktop-client/src/components/budget/MonthCountSelector.js(+3 -1)📝
packages/desktop-client/src/components/budget/index.js(+1 -1)📝
packages/desktop-client/src/components/manager/subscribe/Bootstrap.js(+10 -7)📝
packages/desktop-client/src/components/manager/subscribe/ChangePassword.js(+9 -8)📝
packages/desktop-client/src/components/modals/EditRule.js(+19 -17)📝
packages/desktop-client/src/components/modals/ManageRules.js(+3 -1)📝
packages/desktop-client/src/components/reports/CashFlow.js(+1 -1)📝
packages/desktop-client/src/components/reports/NetWorth.js(+1 -1)📝
packages/desktop-client/src/components/schedules/DiscoverSchedules.js(+21 -22)📝
packages/desktop-client/src/components/schedules/EditSchedule.js(+45 -28)📝
packages/desktop-client/src/components/schedules/SchedulesTable.js(+25 -16)📝
packages/desktop-client/src/components/schedules/StatusBadge.js(+15 -4)...and 23 more files
📄 Description
There's been some interest in adding translations for languages other than english here: https://github.com/actualbudget/actual/discussions/199
I can't really work on this myself personally due time + language knowledge constraints but I'm leaving this PR open so that anyone can contribute translations to be merged into this PR and once we have more coverage then we can work on getting it merged into master (we'll need to add the ability to set the language in the UI, etc.).
For the time being you can choose which language to display by setting the
lngflag insrc/locales/index.js. We currently have very barebones i18n files which only handle a couple of strings on the bootstrapping page.These files need to be filled out and new ones created for any languages we want to support. To use these these translations, all the components in the app need to be updated in a similar fashion to the
Bootstrapcomponent (please use that component as a guide).🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.