github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #141] [CLOSED] Standardise package names to use @actual-app prefix #3043

New Issue
Closed
opened 2026-02-28 20:35:28 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:35:28 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/141
Author: @TomAFrench
Created: 7/31/2022
Status: ❌ Closed

Base: master ← Head: standardise-package-names

📝 Commits (3)

  • 76305dd build: update packages to have names with @actual-app prefix
  • eb74e03 chore: update imports to reference new package names
  • b2e9261 build: add @actual-app/loot-core dependency to @actual-app/web

📊 Changes

205 files changed (+795 additions, -794 deletions)

View changed files

📝 packages/desktop-client/package.json (+1 -0)
📝 packages/desktop-client/src/components/AnimatedRefresh.js (+2 -2)
📝 packages/desktop-client/src/components/App.js (+3 -3)
📝 packages/desktop-client/src/components/AppBackground.js (+3 -3)
📝 packages/desktop-client/src/components/BankSyncStatus.js (+3 -3)
📝 packages/desktop-client/src/components/Debugger.js (+4 -4)
📝 packages/desktop-client/src/components/FatalError.js (+2 -2)
📝 packages/desktop-client/src/components/FinancesApp.js (+9 -9)
📝 packages/desktop-client/src/components/FloatableSidebar.js (+4 -4)
📝 packages/desktop-client/src/components/GlobalKeys.js (+1 -1)
📝 packages/desktop-client/src/components/LoggedInUser.js (+5 -5)
📝 packages/desktop-client/src/components/MobileWebMessage.js (+2 -2)
📝 packages/desktop-client/src/components/Modals.js (+10 -10)
📝 packages/desktop-client/src/components/Notifications.js (+5 -5)
📝 packages/desktop-client/src/components/Page.js (+2 -2)
📝 packages/desktop-client/src/components/Settings.js (+11 -11)
📝 packages/desktop-client/src/components/SidebarWithData.js (+6 -6)
📝 packages/desktop-client/src/components/SpreadsheetInterface.js (+2 -2)
📝 packages/desktop-client/src/components/SyncNotifications.js (+2 -2)
📝 packages/desktop-client/src/components/Titlebar.js (+11 -11)

...and 80 more files

📄 Description

The current package names are quite inconsistent:

  • @actual-app/api
  • Actual
  • loot-core
  • mobile

This causes a few issues:

  1. There's no reference to Actual in several of the names which adds overhead of knowing that "loot" means Actual. Imports from the "mobile" package are even more generic.
  2. The name "Actual" isn't a valid package name to vscode throws warnings whenever desktop-electron/package.json is opened.

To address this I've updated all the package names to have the prefix @actual-app/ for match those for actual-app/api and actual-app/web, in the second commit I've updated all the imports to point at these new package names.

Going further we could drop the name loot, i.e. @actual-app/loot-core -> @actual-app/core, @actual-app/loot-design -> @actual-app/design as I'm not sure what info "loot" is supposed to convey but that's more a question of personal taste.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/141 **Author:** [@TomAFrench](https://github.com/TomAFrench) **Created:** 7/31/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `standardise-package-names` --- ### 📝 Commits (3) - [`76305dd`](https://github.com/actualbudget/actual/commit/76305dd3857bf9184f8fcbd9edcac3ac52512526) build: update packages to have names with `@actual-app` prefix - [`eb74e03`](https://github.com/actualbudget/actual/commit/eb74e033f12b2cae74dc999041eb201881ee3d41) chore: update imports to reference new package names - [`b2e9261`](https://github.com/actualbudget/actual/commit/b2e92610bc1bd7e33c7ad703b4bf076284f9d680) build: add @actual-app/loot-core dependency to @actual-app/web ### 📊 Changes **205 files changed** (+795 additions, -794 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/package.json` (+1 -0) 📝 `packages/desktop-client/src/components/AnimatedRefresh.js` (+2 -2) 📝 `packages/desktop-client/src/components/App.js` (+3 -3) 📝 `packages/desktop-client/src/components/AppBackground.js` (+3 -3) 📝 `packages/desktop-client/src/components/BankSyncStatus.js` (+3 -3) 📝 `packages/desktop-client/src/components/Debugger.js` (+4 -4) 📝 `packages/desktop-client/src/components/FatalError.js` (+2 -2) 📝 `packages/desktop-client/src/components/FinancesApp.js` (+9 -9) 📝 `packages/desktop-client/src/components/FloatableSidebar.js` (+4 -4) 📝 `packages/desktop-client/src/components/GlobalKeys.js` (+1 -1) 📝 `packages/desktop-client/src/components/LoggedInUser.js` (+5 -5) 📝 `packages/desktop-client/src/components/MobileWebMessage.js` (+2 -2) 📝 `packages/desktop-client/src/components/Modals.js` (+10 -10) 📝 `packages/desktop-client/src/components/Notifications.js` (+5 -5) 📝 `packages/desktop-client/src/components/Page.js` (+2 -2) 📝 `packages/desktop-client/src/components/Settings.js` (+11 -11) 📝 `packages/desktop-client/src/components/SidebarWithData.js` (+6 -6) 📝 `packages/desktop-client/src/components/SpreadsheetInterface.js` (+2 -2) 📝 `packages/desktop-client/src/components/SyncNotifications.js` (+2 -2) 📝 `packages/desktop-client/src/components/Titlebar.js` (+11 -11) _...and 80 more files_ </details> ### 📄 Description The current package names are quite inconsistent: - @actual-app/api - Actual - loot-core - mobile This causes a few issues: 1. There's no reference to Actual in several of the names which adds overhead of knowing that "loot" means Actual. Imports from the "mobile" package are even more generic. 2. The name "Actual" isn't a valid package name to vscode throws warnings whenever `desktop-electron/package.json` is opened. To address this I've updated all the package names to have the prefix `@actual-app/` for match those for `actual-app/api` and `actual-app/web`, in the second commit I've updated all the imports to point at these new package names. Going further we could drop the name loot, i.e. `@actual-app/loot-core` -> `@actual-app/core`, `@actual-app/loot-design` -> `@actual-app/design` as I'm not sure what info "loot" is supposed to convey but that's more a question of personal taste. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:35:28 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3043
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?