github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2770] [MERGED] fix(#2562): Prevent transaction deduplication for imported transactions #30425

New Issue
Closed
opened 2026-04-18 06:47:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 06:47:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2770
Author: @strazto
Created: 5/17/2024
Status: ✅ Merged
Merged: 6/7/2024
Merged by: @youngcw

Base: master ← Head: fix-2526-strazto

📝 Commits (10+)

  • a5ebcc6 fix(#2562): Prevent transaction deduplication for imported transactions
  • 17159e8 chore(): eslint fixes
  • 9905c47 chore(): Add release note file
  • d2d754b fix(#2562): Allow transaction deduplication if transaction being imported is null
  • 3b442f0 chore: Rename release note, add strazto as author
  • 5d24b60 test(loot-core): Add test case for new logic
  • 2150e62 docs(release-notes.loot-core): Add pmoon00 as author
  • 55dfb8e test(loot-core): Update test case to not be affected by unrelated bug
  • a40feac test(loot-core): fix linter
  • 3cbc56a Merge branch 'master' into fix-2526-strazto

📊 Changes

3 files changed (+118 additions, -1 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/sync.test.ts (+104 -0)
📝 packages/loot-core/src/server/accounts/sync.ts (+8 -1)
➕ upcoming-release-notes/2770.md (+6 -0)

📄 Description

Resolves #2562

Based on #2618 , with comments by @MatissJanis and others applied

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2770 **Author:** [@strazto](https://github.com/strazto) **Created:** 5/17/2024 **Status:** ✅ Merged **Merged:** 6/7/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `fix-2526-strazto` --- ### 📝 Commits (10+) - [`a5ebcc6`](https://github.com/actualbudget/actual/commit/a5ebcc6a7301c2815acfe4040a377cb7594494d3) fix(#2562): Prevent transaction deduplication for imported transactions - [`17159e8`](https://github.com/actualbudget/actual/commit/17159e82311b4b04c99753272547054520cdbe7e) chore(): eslint fixes - [`9905c47`](https://github.com/actualbudget/actual/commit/9905c4729f67a066a4dc212094b025b2ddb1a17a) chore(): Add release note file - [`d2d754b`](https://github.com/actualbudget/actual/commit/d2d754b143f01f2f187eabce8a0d53f9b06288ee) fix(#2562): Allow transaction deduplication if transaction being imported is null - [`3b442f0`](https://github.com/actualbudget/actual/commit/3b442f06df89f13fbfd2f02d99555308959b8e45) chore: Rename release note, add strazto as author - [`5d24b60`](https://github.com/actualbudget/actual/commit/5d24b608213f5c246da0bacb6eb696e067c6b6ed) test(loot-core): Add test case for new logic - [`2150e62`](https://github.com/actualbudget/actual/commit/2150e62cf17d7e9569e9528c6794737959be84ed) docs(release-notes.loot-core): Add pmoon00 as author - [`55dfb8e`](https://github.com/actualbudget/actual/commit/55dfb8e7680f98863eaa4c5e490cfab2b4ce71b5) test(loot-core): Update test case to not be affected by unrelated bug - [`a40feac`](https://github.com/actualbudget/actual/commit/a40feac75bc431aab54ebe85af35a822971cc150) test(loot-core): fix linter - [`3cbc56a`](https://github.com/actualbudget/actual/commit/3cbc56a5df04b5dff6a4531cff408d83559ce39a) Merge branch 'master' into fix-2526-strazto ### 📊 Changes **3 files changed** (+118 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/sync.test.ts` (+104 -0) 📝 `packages/loot-core/src/server/accounts/sync.ts` (+8 -1) ➕ `upcoming-release-notes/2770.md` (+6 -0) </details> ### 📄 Description Resolves #2562 Based on #2618 , with comments by @MatissJanis and others applied --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 06:47:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#30425
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?