github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #132] [MERGED] Replace jwl-dev-utils with react-dev-utils #3037

New Issue
Closed
opened 2026-02-28 20:35:23 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:35:23 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/132
Author: @TomAFrench
Created: 7/17/2022
Status: ✅ Merged
Merged: 7/24/2022
Merged by: @jlongster

Base: master ← Head: react-dev-utils

📝 Commits (1)

  • b5c2803 build: replace jwl-dev-utils with react-dev-utils

📊 Changes

6 files changed (+1156 additions, -500 deletions)

View changed files

📝 packages/desktop-client/config/webpack.config.js (+10 -17)
📝 packages/desktop-client/config/webpackDevServer.config.js (+4 -4)
📝 packages/desktop-client/package.json (+1 -1)
📝 packages/desktop-client/scripts/build.js (+6 -6)
📝 packages/desktop-client/scripts/start.js (+6 -6)
📝 yarn.lock (+1129 -466)

📄 Description

closes #127

This PR replaces jwl-dev-utils with the most recent version of react-dev-utils. This has mostly been a 1 for 1 swap but there are a couple differences.

  • WatchMissingNodeModulesPlugin has been removed so we've had to remove it from our config as well.
  • typescriptFormatter has been also removed so we can't pass this into ForkTsCheckerWebpackPlugin.

This second change has likely broken ForkTsCheckerWebpackPlugin however as we don't have typescript in the repo atm it doesn't cause an issues. I think it's sensible to just leave it as is and cross this bridge as part of the TS migration in the future (especially as the version we have installed is marked as deprecated).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/132 **Author:** [@TomAFrench](https://github.com/TomAFrench) **Created:** 7/17/2022 **Status:** ✅ Merged **Merged:** 7/24/2022 **Merged by:** [@jlongster](https://github.com/jlongster) **Base:** `master` ← **Head:** `react-dev-utils` --- ### 📝 Commits (1) - [`b5c2803`](https://github.com/actualbudget/actual/commit/b5c2803a82dbae316946bfb9536a5d7800150e4c) build: replace jwl-dev-utils with react-dev-utils ### 📊 Changes **6 files changed** (+1156 additions, -500 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/config/webpack.config.js` (+10 -17) 📝 `packages/desktop-client/config/webpackDevServer.config.js` (+4 -4) 📝 `packages/desktop-client/package.json` (+1 -1) 📝 `packages/desktop-client/scripts/build.js` (+6 -6) 📝 `packages/desktop-client/scripts/start.js` (+6 -6) 📝 `yarn.lock` (+1129 -466) </details> ### 📄 Description closes #127 This PR replaces `jwl-dev-utils` with the most recent version of `react-dev-utils`. This has mostly been a 1 for 1 swap but there are a couple differences. - `WatchMissingNodeModulesPlugin` has been removed so we've had to remove it from our config as well. - `typescriptFormatter` has been also removed so we can't pass this into `ForkTsCheckerWebpackPlugin`. This second change has likely broken `ForkTsCheckerWebpackPlugin` however as we don't have typescript in the repo atm it doesn't cause an issues. I think it's sensible to just leave it as is and cross this bridge as part of the TS migration in the future (especially as the version we have installed is marked as deprecated). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:35:23 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3037
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?