github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 12:28:57 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #130] [MERGED] Enforce prettier rules #3035

New Issue
Closed
opened 2026-02-28 20:35:21 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:35:21 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/130
Author: @TomAFrench
Created: 7/17/2022
Status: ✅ Merged
Merged: 8/23/2022
Merged by: @TomAFrench

Base: master ← Head: prettier

📝 Commits (4)

  • a44834c style: enforce prettier rules in linter
  • 5977e02 style: switch prettier to enforce single quotes
  • d30067b style: apply prettier fixes
  • 8d0872c Merge branch 'master' into prettier

📊 Changes

52 files changed (+573 additions, -453 deletions)

View changed files

➕ .eslintrc.js (+10 -0)
➕ .prettierrc.json (+4 -0)
📝 package.json (+0 -12)
📝 packages/desktop-client/src/components/Box.js (+6 -2)
📝 packages/desktop-client/src/components/Debugger.js (+1 -1)
📝 packages/desktop-client/src/components/FatalError.js (+3 -1)
📝 packages/desktop-client/src/components/FinancesApp.js (+1 -4)
📝 packages/desktop-client/src/components/accounts/Account.js (+4 -4)
📝 packages/desktop-client/src/components/accounts/Filters.js (+5 -1)
📝 packages/desktop-client/src/components/manager/ManagementApp.js (+11 -14)
📝 packages/desktop-client/src/components/manager/subscribe/ConfirmPasswordForm.js (+1 -4)
📝 packages/desktop-client/src/components/modals/WelcomeScreen.js (+1 -4)
📝 packages/desktop-client/src/components/reports/Change.js (+1 -1)
📝 packages/desktop-client/src/components/reports/Overview.js (+7 -4)
📝 packages/desktop-client/src/components/tutorial/BudgetInitial.js (+3 -3)
📝 packages/desktop-client/src/components/tutorial/BudgetNextMonth.js (+3 -4)
📝 packages/desktop-client/src/components/tutorial/CategoryBalance.js (+1 -1)
📝 packages/desktop-client/src/components/tutorial/Overspending.js (+3 -4)
📝 packages/desktop-client/src/components/tutorial/TransactionAdd.js (+2 -2)
📝 packages/desktop-client/src/components/tutorial/TransactionFinalize.js (+1 -1)

...and 32 more files

📄 Description

Despite having a prettier config set up in the root package.json this isn't being enforced currently. I've added the eslint-plugin-prettier package similar to in https://github.com/actualbudget/actual-server/pull/43 so that we can automatically correct these issues.

On a sidenote, is there any preference for the value of printWidth? It's currently defaulting to 80 however I normally find that a bit restrictive and have it at 120.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/130 **Author:** [@TomAFrench](https://github.com/TomAFrench) **Created:** 7/17/2022 **Status:** ✅ Merged **Merged:** 8/23/2022 **Merged by:** [@TomAFrench](https://github.com/TomAFrench) **Base:** `master` ← **Head:** `prettier` --- ### 📝 Commits (4) - [`a44834c`](https://github.com/actualbudget/actual/commit/a44834c0d3169b56c502800408cd69b0c09fd9e5) style: enforce prettier rules in linter - [`5977e02`](https://github.com/actualbudget/actual/commit/5977e020f0698a6765d7d837ae022fe916125bd7) style: switch prettier to enforce single quotes - [`d30067b`](https://github.com/actualbudget/actual/commit/d30067b5b925f96e6d9f5cebb963496535269a57) style: apply prettier fixes - [`8d0872c`](https://github.com/actualbudget/actual/commit/8d0872c7a45ac67b0d83836b2bc59c5381009541) Merge branch 'master' into prettier ### 📊 Changes **52 files changed** (+573 additions, -453 deletions) <details> <summary>View changed files</summary> ➕ `.eslintrc.js` (+10 -0) ➕ `.prettierrc.json` (+4 -0) 📝 `package.json` (+0 -12) 📝 `packages/desktop-client/src/components/Box.js` (+6 -2) 📝 `packages/desktop-client/src/components/Debugger.js` (+1 -1) 📝 `packages/desktop-client/src/components/FatalError.js` (+3 -1) 📝 `packages/desktop-client/src/components/FinancesApp.js` (+1 -4) 📝 `packages/desktop-client/src/components/accounts/Account.js` (+4 -4) 📝 `packages/desktop-client/src/components/accounts/Filters.js` (+5 -1) 📝 `packages/desktop-client/src/components/manager/ManagementApp.js` (+11 -14) 📝 `packages/desktop-client/src/components/manager/subscribe/ConfirmPasswordForm.js` (+1 -4) 📝 `packages/desktop-client/src/components/modals/WelcomeScreen.js` (+1 -4) 📝 `packages/desktop-client/src/components/reports/Change.js` (+1 -1) 📝 `packages/desktop-client/src/components/reports/Overview.js` (+7 -4) 📝 `packages/desktop-client/src/components/tutorial/BudgetInitial.js` (+3 -3) 📝 `packages/desktop-client/src/components/tutorial/BudgetNextMonth.js` (+3 -4) 📝 `packages/desktop-client/src/components/tutorial/CategoryBalance.js` (+1 -1) 📝 `packages/desktop-client/src/components/tutorial/Overspending.js` (+3 -4) 📝 `packages/desktop-client/src/components/tutorial/TransactionAdd.js` (+2 -2) 📝 `packages/desktop-client/src/components/tutorial/TransactionFinalize.js` (+1 -1) _...and 32 more files_ </details> ### 📄 Description Despite having a prettier config set up in the root `package.json` this isn't being enforced currently. I've added the `eslint-plugin-prettier` package similar to in https://github.com/actualbudget/actual-server/pull/43 so that we can automatically correct these issues. On a sidenote, is there any preference for the value of `printWidth`? It's currently defaulting to 80 however I normally find that a bit restrictive and have it at 120. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:35:21 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3035
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?