github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #125] [CLOSED] Remove node-libofx package and replace it with ofx-js #3033

New Issue
Closed
opened 2026-02-28 20:35:19 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:35:19 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/125
Author: @TomAFrench
Created: 7/7/2022
Status: ❌ Closed

Base: master ← Head: parsers-no-package

📝 Commits (6)

  • b5d9f65 refactor: replace node-libofx dependency in loot-core with ofx-js
  • e336db7 chore: remove node-libofx package
  • 8523651 chore: remove remaining references to node-libofx
  • 5812258 build: update api bundle
  • 9380477 Merge branch 'master' into parsers-no-package
  • d242081 refactor: move extraction of transactions inside try-catch

📊 Changes

971 files changed (+2495 additions, -305122 deletions)

View changed files

📝 .circleci/config.yml (+0 -1)
📝 packages/api/app/bundle.api.js (+2459 -44)
📝 packages/api/app/bundle.api.js.map (+1 -1)
➖ packages/desktop-client/public/libofx.web.wasm (+0 -0)
📝 packages/desktop-electron/package.json (+1 -2)
📝 packages/loot-core/package.json (+1 -1)
📝 packages/loot-core/src/server/accounts/parse-file.js (+12 -15)
📝 packages/loot-core/webpack/webpack.desktop.config.js (+0 -1)
➖ packages/node-libofx/.gitignore (+0 -1)
➖ packages/node-libofx/Makefile (+0 -38)
➖ packages/node-libofx/OpenSP-1.5.2/.cvsignore (+0 -33)
➖ packages/node-libofx/OpenSP-1.5.2/ABOUT-NLS (+0 -996)
➖ packages/node-libofx/OpenSP-1.5.2/AUTHORS (+0 -15)
➖ packages/node-libofx/OpenSP-1.5.2/BUGS (+0 -4)
➖ packages/node-libofx/OpenSP-1.5.2/COPYING (+0 -25)
➖ packages/node-libofx/OpenSP-1.5.2/ChangeLog (+0 -2634)
➖ packages/node-libofx/OpenSP-1.5.2/INSTALL (+0 -236)
➖ packages/node-libofx/OpenSP-1.5.2/Makefile (+0 -777)
➖ packages/node-libofx/OpenSP-1.5.2/Makefile.am (+0 -44)
➖ packages/node-libofx/OpenSP-1.5.2/Makefile.in (+0 -777)

...and 80 more files

📄 Description

Supercedes #98

This PR replaces the use of node-libofx in loot-core with a drop in replacement ofx-js.

This allows us to delete node-libofx completely and remove most of the code in the monorepo.

All the snapshots for the parser tests are still satisfied.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/125 **Author:** [@TomAFrench](https://github.com/TomAFrench) **Created:** 7/7/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `parsers-no-package` --- ### 📝 Commits (6) - [`b5d9f65`](https://github.com/actualbudget/actual/commit/b5d9f658d5dfd55066aa968e8cadbda0c4b9ea30) refactor: replace node-libofx dependency in loot-core with ofx-js - [`e336db7`](https://github.com/actualbudget/actual/commit/e336db7430fbc5b9cc24c203de047ae6ea1dd259) chore: remove node-libofx package - [`8523651`](https://github.com/actualbudget/actual/commit/85236510fab1857a7cb193dd84dbf2777565ff3e) chore: remove remaining references to node-libofx - [`5812258`](https://github.com/actualbudget/actual/commit/5812258f2c9b5a26c391a764a073222ab27d6a2c) build: update api bundle - [`9380477`](https://github.com/actualbudget/actual/commit/938047723d2486c5b0247ebdda4f241ea45ce527) Merge branch 'master' into parsers-no-package - [`d242081`](https://github.com/actualbudget/actual/commit/d2420816be67fe636bc2f7624cbb1a491311566b) refactor: move extraction of transactions inside try-catch ### 📊 Changes **971 files changed** (+2495 additions, -305122 deletions) <details> <summary>View changed files</summary> 📝 `.circleci/config.yml` (+0 -1) 📝 `packages/api/app/bundle.api.js` (+2459 -44) 📝 `packages/api/app/bundle.api.js.map` (+1 -1) ➖ `packages/desktop-client/public/libofx.web.wasm` (+0 -0) 📝 `packages/desktop-electron/package.json` (+1 -2) 📝 `packages/loot-core/package.json` (+1 -1) 📝 `packages/loot-core/src/server/accounts/parse-file.js` (+12 -15) 📝 `packages/loot-core/webpack/webpack.desktop.config.js` (+0 -1) ➖ `packages/node-libofx/.gitignore` (+0 -1) ➖ `packages/node-libofx/Makefile` (+0 -38) ➖ `packages/node-libofx/OpenSP-1.5.2/.cvsignore` (+0 -33) ➖ `packages/node-libofx/OpenSP-1.5.2/ABOUT-NLS` (+0 -996) ➖ `packages/node-libofx/OpenSP-1.5.2/AUTHORS` (+0 -15) ➖ `packages/node-libofx/OpenSP-1.5.2/BUGS` (+0 -4) ➖ `packages/node-libofx/OpenSP-1.5.2/COPYING` (+0 -25) ➖ `packages/node-libofx/OpenSP-1.5.2/ChangeLog` (+0 -2634) ➖ `packages/node-libofx/OpenSP-1.5.2/INSTALL` (+0 -236) ➖ `packages/node-libofx/OpenSP-1.5.2/Makefile` (+0 -777) ➖ `packages/node-libofx/OpenSP-1.5.2/Makefile.am` (+0 -44) ➖ `packages/node-libofx/OpenSP-1.5.2/Makefile.in` (+0 -777) _...and 80 more files_ </details> ### 📄 Description Supercedes #98 This PR replaces the use of `node-libofx` in `loot-core` with a drop in replacement `ofx-js`. This allows us to delete `node-libofx` completely and remove most of the code in the monorepo. All the snapshots for the parser tests are still satisfied. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:35:19 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3033
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?