github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #124] [MERGED] fix: hitting enter after setting password redirects to demo page #3032

New Issue
Closed
opened 2026-02-28 20:35:18 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:35:18 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/124
Author: @andremralves
Created: 7/6/2022
Status: ✅ Merged
Merged: 8/23/2022
Merged by: @TomAFrench

Base: master ← Head: fix/hitting-enter-on-bootstrap-page

📝 Commits (1)

  • a2b67cb fix: hitting enter after setting password redirects to demo page

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 packages/desktop-client/src/components/manager/subscribe/ConfirmPasswordForm.js (+2 -0)

📄 Description

Closes #29

  • At the bootstrap page, when the user sets the password and press enter or even when the password field is empty, he is redirected to the demo page.
  • I used the "onEnter" prop from the Input component to trigger the "onSubmit" function whenever the user presses enter within both password input fields.

Before changes:

  • The user is redirected to the demo page after pressing enter.

old-screen-record

  • In this screen record i fill the password fields and then i press enter. The page demo is launched.

After changes:

  • The user is redirected to the files page after pressing enter.

new-screen-record

  • In this screen record I fill the password fields and then I press enter. Now the user is redirected to the files page.
  • I also tested pressing enter with empty fields and with just one filled.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/124 **Author:** [@andremralves](https://github.com/andremralves) **Created:** 7/6/2022 **Status:** ✅ Merged **Merged:** 8/23/2022 **Merged by:** [@TomAFrench](https://github.com/TomAFrench) **Base:** `master` ← **Head:** `fix/hitting-enter-on-bootstrap-page` --- ### 📝 Commits (1) - [`a2b67cb`](https://github.com/actualbudget/actual/commit/a2b67cb153622998993539ffb97fa1a99c84eafb) fix: hitting enter after setting password redirects to demo page ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/manager/subscribe/ConfirmPasswordForm.js` (+2 -0) </details> ### 📄 Description Closes #29 - At the bootstrap page, when the user sets the password and press enter or even when the password field is empty, he is redirected to the demo page. - I used the "onEnter" prop from the Input component to trigger the "onSubmit" function whenever the user presses enter within both password input fields. ### Before changes: - The user is redirected to the demo page after pressing enter. [old-screen-record](https://user-images.githubusercontent.com/71379045/177626271-5ba29253-4c4b-477c-ba1f-c51b7fc265ca.webm) - In this screen record i fill the password fields and then i press enter. The page demo is launched. ### After changes: - The user is redirected to the files page after pressing enter. [new-screen-record](https://user-images.githubusercontent.com/71379045/177625445-fda04a4f-271f-4c1c-bf5d-63d203bfacf5.webm) - In this screen record I fill the password fields and then I press enter. Now the user is redirected to the files page. - I also tested pressing enter with empty fields and with just one filled. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:35:18 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3032
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?