github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #122] [CLOSED] Feat/delimiter select on error #3031

New Issue
Closed
opened 2026-02-28 20:35:17 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:35:17 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/122
Author: @PartyLich
Created: 7/5/2022
Status: ❌ Closed

Base: master ← Head: feat/delimiter-select-on-error

📝 Commits (3)

  • a56efcc refactor: extract DelimiterSelect component
  • 05dc109 feat: show delimiter select on csv import error
  • 581d496 style: apply prettier to legacy code

📊 Changes

1 file changed (+61 additions, -31 deletions)

View changed files

📝 packages/loot-design/src/components/modals/ImportTransactions.js (+61 -31)

📄 Description

edit: rewritten for easier review

Problem

As described in #19. The current flow doesn't provide an opportunity to select the appropriate csv delimiter setting until after you've successfully parsed.

This seems to happen with CSV files that contain semicolon delimiters and strings that are wrapped with double quotation marks. When trying to import such files for the first time to an account, the error pops up.

Proposed solution

Adding a delimiter selector when csv parsing fails. This change avoids that flow issue (though i'm sure the aesthetics or UX could be even better) by presenting the delimiter select alongside the error.
image

There's also a prettier driven style change to legacy code. Unrelated to this change other than existing in the same file.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/122 **Author:** [@PartyLich](https://github.com/PartyLich) **Created:** 7/5/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feat/delimiter-select-on-error` --- ### 📝 Commits (3) - [`a56efcc`](https://github.com/actualbudget/actual/commit/a56efcc9e14526b8059f61fa8e4478598108d94a) refactor: extract DelimiterSelect component - [`05dc109`](https://github.com/actualbudget/actual/commit/05dc1095840d9441ed04481c2a182d7a2b6cc861) feat: show delimiter select on csv import error - [`581d496`](https://github.com/actualbudget/actual/commit/581d496f5cb05d2b0a60bc422d734c214f95aa19) style: apply prettier to legacy code ### 📊 Changes **1 file changed** (+61 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-design/src/components/modals/ImportTransactions.js` (+61 -31) </details> ### 📄 Description edit: rewritten for easier review ### Problem As described in #19. The current flow doesn't provide an opportunity to select the appropriate csv delimiter setting until *after* you've successfully parsed. > This seems to happen with CSV files that contain semicolon delimiters and strings that are wrapped with double quotation marks. When trying to import such files for the first time to an account, the error pops up. ### Proposed solution Adding a delimiter selector when csv parsing fails. This change avoids that flow issue (though i'm sure the aesthetics or UX could be even better) by presenting the delimiter select alongside the error. ![image](https://user-images.githubusercontent.com/2792750/177268997-2bacbf07-c458-4793-ad1b-e9da8aa6f831.png) There's also a prettier driven style change to legacy code. Unrelated to this change other than existing in the same file. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:35:17 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3031
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?