github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-21 14:42:14 -05:00
Code Issues 2.1k Packages Projects Releases 57 Wiki Activity

[PR #118] [MERGED] Strip down and refactor package scripts #3030

New Issue
Closed
opened 2026-02-28 20:35:16 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:35:16 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/118
Author: @TomAFrench
Created: 7/3/2022
Status: ✅ Merged
Merged: 1/1/2023
Merged by: @MatissJanis

Base: master ← Head: strip-down-package-scripts

📝 Commits (5)

  • 1a4b46c feat: stop sending beta releases to jlongster.com
  • da62f9b refactor: move script to update client build into electron package
  • 617f39e feat: change ROOT variable to be package root rather than bin
  • 9b67102 refactor: use yarnv3 magic for updating client
  • 456369f Merge branch 'master' into strip-down-package-scripts

📊 Changes

3 files changed (+17 additions, -34 deletions)

View changed files

📝 bin/package (+3 -34)
➕ packages/desktop-electron/bin/update-client (+13 -0)
📝 packages/desktop-electron/package.json (+1 -0)

📄 Description

The package script contains some leftover code which sends beta releases to https://jlongster.com. As we move towards running/hosting releases on Github we can remove this code as it's no longer needed.

I've also moved the code responsible for updating the client build for the electron app into the desktop-electron package.

The obvious thing to remove next is the sentry integration however I'll do that in a separate PR as it'll touch other packages.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/118 **Author:** [@TomAFrench](https://github.com/TomAFrench) **Created:** 7/3/2022 **Status:** ✅ Merged **Merged:** 1/1/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `strip-down-package-scripts` --- ### 📝 Commits (5) - [`1a4b46c`](https://github.com/actualbudget/actual/commit/1a4b46cb6ce61b98d0405e5aeba20a3958aaa1ba) feat: stop sending beta releases to jlongster.com - [`da62f9b`](https://github.com/actualbudget/actual/commit/da62f9b5d945faf4d680572cb1c30d5291de13b9) refactor: move script to update client build into electron package - [`617f39e`](https://github.com/actualbudget/actual/commit/617f39e73c79871b69eb1061cece5a233d09c63e) feat: change ROOT variable to be package root rather than bin - [`9b67102`](https://github.com/actualbudget/actual/commit/9b671026a73a23f1420ded513398af1362bf71a9) refactor: use yarnv3 magic for updating client - [`456369f`](https://github.com/actualbudget/actual/commit/456369f1101c9b6035e3060e0ee835bd73adbd09) Merge branch 'master' into strip-down-package-scripts ### 📊 Changes **3 files changed** (+17 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `bin/package` (+3 -34) ➕ `packages/desktop-electron/bin/update-client` (+13 -0) 📝 `packages/desktop-electron/package.json` (+1 -0) </details> ### 📄 Description The `package` script contains some leftover code which sends beta releases to https://jlongster.com. As we move towards running/hosting releases on Github we can remove this code as it's no longer needed. I've also moved the code responsible for updating the client build for the electron app into the `desktop-electron` package. The obvious thing to remove next is the sentry integration however I'll do that in a separate PR as it'll touch other packages. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:35:16 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3030
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?