github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2566] [MERGED] Use amount input on rules page instead of plain text field #30296

New Issue
Closed
opened 2026-04-18 06:41:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 06:41:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2566
Author: @jfdoming
Created: 4/8/2024
Status: ✅ Merged
Merged: 6/5/2024
Merged by: @youngcw

Base: master ← Head: jfdoming/amount-input-in-rules

📝 Commits (10+)

  • 7d1cea7 Use amount input on rules page instead of plain text field
  • b337f5b Add release notes
  • 5f95aa2 Remove unneeded attributes
  • 665b121 Support percent formatting
  • 5f8db5f Lint + typecheck
  • be09acb Fix latent bug
  • b9b2687 Handle existing data correctly
  • 3aa6ea3 PR feedback: naming
  • d5664a5 PR feedback: force percent to a positive number
  • bd555b9 PR feedback: reset percent to 100 upon changing input type

📊 Changes

5 files changed (+176 additions, -0 deletions)

View changed files

📝 packages/desktop-client/src/components/modals/EditRule.jsx (+5 -0)
📝 packages/desktop-client/src/components/spreadsheet/useFormat.ts (+3 -0)
📝 packages/desktop-client/src/components/util/GenericInput.jsx (+38 -0)
➕ packages/desktop-client/src/components/util/PercentInput.tsx (+124 -0)
➕ upcoming-release-notes/2566.md (+6 -0)

📄 Description

There was feedback on the original rules-with-splits PR that amount inputs could use the featureful amount input instead of a plain text field. This PR updates that page to use the AmountInput component.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2566 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 4/8/2024 **Status:** ✅ Merged **Merged:** 6/5/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `jfdoming/amount-input-in-rules` --- ### 📝 Commits (10+) - [`7d1cea7`](https://github.com/actualbudget/actual/commit/7d1cea731e2230f89908950c1f163508befbf0f0) Use amount input on rules page instead of plain text field - [`b337f5b`](https://github.com/actualbudget/actual/commit/b337f5b5e077856870a358f5a896ff806b2ebd78) Add release notes - [`5f95aa2`](https://github.com/actualbudget/actual/commit/5f95aa244e64e765dd191fe69dcdcf955ce13c51) Remove unneeded attributes - [`665b121`](https://github.com/actualbudget/actual/commit/665b12140c12e89bbc57353d284662c6d78947d6) Support percent formatting - [`5f8db5f`](https://github.com/actualbudget/actual/commit/5f8db5f74ae4045787fd7887c638509c48a5efb5) Lint + typecheck - [`be09acb`](https://github.com/actualbudget/actual/commit/be09acb9cee1b1e38a49d5eee357817386f5f9cb) Fix latent bug - [`b9b2687`](https://github.com/actualbudget/actual/commit/b9b26879a67e5d71aefdfeb9e1a0dc82655a21e4) Handle existing data correctly - [`3aa6ea3`](https://github.com/actualbudget/actual/commit/3aa6ea3da248e00dc3a7ea29399727cb4fc3462f) PR feedback: naming - [`d5664a5`](https://github.com/actualbudget/actual/commit/d5664a58375cee24f5ee36f7b8c675690552032b) PR feedback: force percent to a positive number - [`bd555b9`](https://github.com/actualbudget/actual/commit/bd555b96ec432be1975af7dd4723d8430ce108b5) PR feedback: reset percent to 100 upon changing input type ### 📊 Changes **5 files changed** (+176 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/modals/EditRule.jsx` (+5 -0) 📝 `packages/desktop-client/src/components/spreadsheet/useFormat.ts` (+3 -0) 📝 `packages/desktop-client/src/components/util/GenericInput.jsx` (+38 -0) ➕ `packages/desktop-client/src/components/util/PercentInput.tsx` (+124 -0) ➕ `upcoming-release-notes/2566.md` (+6 -0) </details> ### 📄 Description There was feedback on the original rules-with-splits PR that amount inputs could use the featureful amount input instead of a plain text field. This PR updates that page to use the `AmountInput` component. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 06:41:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#30296
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?