github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #98] [CLOSED] Replace node-libofx with new parsers package #3017

New Issue
Closed
opened 2026-02-28 20:35:04 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:35:04 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/98
Author: @TomAFrench
Created: 6/20/2022
Status: ❌ Closed

Base: master ← Head: parsers

📝 Commits (2)

  • b8268eb feat: create a parsers package
  • 0fa910d feat: remove node-libofx package

📊 Changes

990 files changed (+2641 additions, -305515 deletions)

View changed files

📝 packages/loot-core/package.json (+1 -1)
📝 packages/loot-core/src/server/accounts/parse-file.js (+1 -116)
📝 packages/loot-core/src/server/accounts/parse-file.test.js (+0 -22)
➖ packages/loot-core/src/server/accounts/qif2json.js (+0 -87)
➖ packages/node-libofx/.gitignore (+0 -1)
➖ packages/node-libofx/Makefile (+0 -38)
➖ packages/node-libofx/OpenSP-1.5.2/.cvsignore (+0 -33)
➖ packages/node-libofx/OpenSP-1.5.2/ABOUT-NLS (+0 -996)
➖ packages/node-libofx/OpenSP-1.5.2/AUTHORS (+0 -15)
➖ packages/node-libofx/OpenSP-1.5.2/BUGS (+0 -4)
➖ packages/node-libofx/OpenSP-1.5.2/COPYING (+0 -25)
➖ packages/node-libofx/OpenSP-1.5.2/ChangeLog (+0 -2634)
➖ packages/node-libofx/OpenSP-1.5.2/INSTALL (+0 -236)
➖ packages/node-libofx/OpenSP-1.5.2/Makefile (+0 -777)
➖ packages/node-libofx/OpenSP-1.5.2/Makefile.am (+0 -44)
➖ packages/node-libofx/OpenSP-1.5.2/Makefile.in (+0 -777)
➖ packages/node-libofx/OpenSP-1.5.2/NEWS (+0 -155)
➖ packages/node-libofx/OpenSP-1.5.2/OpenSP-1.5.2.spec (+0 -91)
➖ packages/node-libofx/OpenSP-1.5.2/README (+0 -18)
➖ packages/node-libofx/OpenSP-1.5.2/SP.dsw (+0 -118)

...and 80 more files

📄 Description

Marked as draft as I'm having weird test issues locally. These should be fixed by other PRs hopefully so we can revisit once some more stuff is merged.

closes #67

This PR is an attempt to simplify how we handle importing transaction files. We're currently using the libofx library to handle OFX/QFX files but this leads to the awkward position of using a C++ library in a Javascript codebase.

Instead, we now use the ofx-js package to handle OFX/QFX files. The parsing logic has now been encapsulated into a parsers package to help break down loot-core into manageable chunks.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/98 **Author:** [@TomAFrench](https://github.com/TomAFrench) **Created:** 6/20/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `parsers` --- ### 📝 Commits (2) - [`b8268eb`](https://github.com/actualbudget/actual/commit/b8268eb4d03282549d83f35eac95e97d4d2ae4c7) feat: create a parsers package - [`0fa910d`](https://github.com/actualbudget/actual/commit/0fa910d4de068a14611f29028d5e564b987d4adb) feat: remove node-libofx package ### 📊 Changes **990 files changed** (+2641 additions, -305515 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/package.json` (+1 -1) 📝 `packages/loot-core/src/server/accounts/parse-file.js` (+1 -116) 📝 `packages/loot-core/src/server/accounts/parse-file.test.js` (+0 -22) ➖ `packages/loot-core/src/server/accounts/qif2json.js` (+0 -87) ➖ `packages/node-libofx/.gitignore` (+0 -1) ➖ `packages/node-libofx/Makefile` (+0 -38) ➖ `packages/node-libofx/OpenSP-1.5.2/.cvsignore` (+0 -33) ➖ `packages/node-libofx/OpenSP-1.5.2/ABOUT-NLS` (+0 -996) ➖ `packages/node-libofx/OpenSP-1.5.2/AUTHORS` (+0 -15) ➖ `packages/node-libofx/OpenSP-1.5.2/BUGS` (+0 -4) ➖ `packages/node-libofx/OpenSP-1.5.2/COPYING` (+0 -25) ➖ `packages/node-libofx/OpenSP-1.5.2/ChangeLog` (+0 -2634) ➖ `packages/node-libofx/OpenSP-1.5.2/INSTALL` (+0 -236) ➖ `packages/node-libofx/OpenSP-1.5.2/Makefile` (+0 -777) ➖ `packages/node-libofx/OpenSP-1.5.2/Makefile.am` (+0 -44) ➖ `packages/node-libofx/OpenSP-1.5.2/Makefile.in` (+0 -777) ➖ `packages/node-libofx/OpenSP-1.5.2/NEWS` (+0 -155) ➖ `packages/node-libofx/OpenSP-1.5.2/OpenSP-1.5.2.spec` (+0 -91) ➖ `packages/node-libofx/OpenSP-1.5.2/README` (+0 -18) ➖ `packages/node-libofx/OpenSP-1.5.2/SP.dsw` (+0 -118) _...and 80 more files_ </details> ### 📄 Description Marked as draft as I'm having weird test issues locally. These *should* be fixed by other PRs hopefully so we can revisit once some more stuff is merged. closes #67 This PR is an attempt to simplify how we handle importing transaction files. We're currently using the libofx library to handle OFX/QFX files but this leads to the awkward position of using a C++ library in a Javascript codebase. Instead, we now use the [ofx-js](https://github.com/bradenmacdonald/ofx-js) package to handle OFX/QFX files. The parsing logic has now been encapsulated into a `parsers` package to help break down `loot-core` into manageable chunks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:35:04 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3017
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?