github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #89] [CLOSED] Update patches #3012

New Issue
Closed
opened 2026-02-28 20:35:00 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:35:00 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/89
Author: @trevdor
Created: 6/15/2022
Status: ❌ Closed

Base: master ← Head: patches

📝 Commits (1)

📊 Changes

4 files changed (+15 additions, -15 deletions)

View changed files

📝 patches/eslint-config-react-app+3.0.8.patch (+2 -2)
📝 patches/hotkeys-js+3.8.7.patch (+5 -5)
📝 patches/pikaday+1.8.2.patch (+1 -1)
📝 patches/react-modal+3.14.4.patch (+7 -7)

📄 Description

To reduce warnings on yarn install.

All patch version bumps except react-modal.
☝🏻 This one could use review.

In intervening minor bumps, the lib guarded the afterClose close call with a check for the modal being open. Presumably, that's what one would want.
However, it's not clear to me what purpose the non-blocking afterClose patch is serving within Actual (I find no uses of this function), so I couldn't say for sure this is still how we want to patch it. Or if it even needs patching anymore.

❌ BEFORE

patch-package 6.4.7
Applying patches...
@reach/listbox@0.11.2 ✔
@sentry/browser@6.12.0 ✔
absurd-sql@0.0.53 ✔
eslint-config-react-app@3.0.5 ✔
hotkeys-js@3.8.2 ✔
pikaday@1.8.0 ✔
react-dnd-html5-backend@10.0.2 ✔
...
<warnings warnings warnings>

**ERROR** Failed to apply patch for package react-modal at path
  
    node_modules/react-modal

<details details>

  Info:
    Patch file: patches/react-modal+3.4.4.patch
    Patch was made for version: 3.4.4
    Installed version: 3.14.4
patch-package finished with 3 warning(s), 1 error(s).

✅ AFTER

after

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/89 **Author:** [@trevdor](https://github.com/trevdor) **Created:** 6/15/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patches` --- ### 📝 Commits (1) - [`e85a31d`](https://github.com/actualbudget/actual/commit/e85a31d32e2f3f807efbc10478ea484ee2229740) Update patches ### 📊 Changes **4 files changed** (+15 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `patches/eslint-config-react-app+3.0.8.patch` (+2 -2) 📝 `patches/hotkeys-js+3.8.7.patch` (+5 -5) 📝 `patches/pikaday+1.8.2.patch` (+1 -1) 📝 `patches/react-modal+3.14.4.patch` (+7 -7) </details> ### 📄 Description To reduce warnings on `yarn install`. All patch version bumps except `react-modal`. ☝🏻 **This one could use review.** In intervening minor bumps, the lib guarded the `afterClose` close call with a check for the modal being open. Presumably, that's what one would want. However, it's not clear to me what purpose the non-blocking `afterClose` patch is serving within Actual (I find no uses of this function), so I couldn't say for sure this is still how we want to patch it. Or if it even needs patching anymore. ❌ BEFORE ``` patch-package 6.4.7 Applying patches... @reach/listbox@0.11.2 ✔ @sentry/browser@6.12.0 ✔ absurd-sql@0.0.53 ✔ eslint-config-react-app@3.0.5 ✔ hotkeys-js@3.8.2 ✔ pikaday@1.8.0 ✔ react-dnd-html5-backend@10.0.2 ✔ ... <warnings warnings warnings> **ERROR** Failed to apply patch for package react-modal at path node_modules/react-modal <details details> Info: Patch file: patches/react-modal+3.4.4.patch Patch was made for version: 3.4.4 Installed version: 3.14.4 patch-package finished with 3 warning(s), 1 error(s). ``` ✅ AFTER ![after](https://user-images.githubusercontent.com/5862724/173730731-c3a9b135-5853-493e-8151-f2765584b488.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:35:00 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3012
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?