[PR #1900] [MERGED] Larger mobile autocomplete fonts and paddings #29937

Closed
opened 2026-04-18 06:24:36 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1900
Author: @joel-jeremy
Created: 11/12/2023
Status: Merged
Merged: 12/1/2023
Merged by: @joel-jeremy

Base: masterHead: mobile-transaction-larger-components


📝 Commits (10+)

📊 Changes

16 files changed (+652 additions, -314 deletions)

View changed files

📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.test.js (+1 -1)
📝 packages/desktop-client/src/components/autocomplete/AccountAutocomplete.tsx (+122 -63)
📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+199 -90)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx (+189 -93)
📝 packages/desktop-client/src/components/autocomplete/SavedFilterAutocomplete.tsx (+2 -3)
📝 packages/desktop-client/src/components/mobile/MobileNavTabs.tsx (+9 -9)
📝 packages/desktop-client/src/components/modals/EditField.js (+103 -26)
📝 packages/desktop-client/src/components/transactions/MobileTransaction.js (+5 -4)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.test.js (+16 -25)
upcoming-release-notes/1900.md (+6 -0)

📄 Description

Made autocomplete components easier to tap by making the fonts and paddings larger.

Previous:
image

New:
image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1900 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 11/12/2023 **Status:** ✅ Merged **Merged:** 12/1/2023 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `mobile-transaction-larger-components` --- ### 📝 Commits (10+) - [`ba28b38`](https://github.com/actualbudget/actual/commit/ba28b384d3e046fdd8b83eef388682c41e6678ae) Larger mobile autocomplete fonts and paddings - [`e4614c3`](https://github.com/actualbudget/actual/commit/e4614c3b3c93687e237d21bbea12beb862e50bd8) Release notes - [`d01c83d`](https://github.com/actualbudget/actual/commit/d01c83d315d414012caabd0d340a33ddfe8f5263) VRT + update tests - [`b593c9d`](https://github.com/actualbudget/actual/commit/b593c9d9ab62100127e3c82a835d48c882f50ce8) Update tests - [`69a8913`](https://github.com/actualbudget/actual/commit/69a8913aa5e25146e0922495e2cb598ceb9247a0) Update data-highlighted and tests - [`f429d96`](https://github.com/actualbudget/actual/commit/f429d96c6ece0b3374ccd1c2c47be7047e4b026e) Use styles text - [`31b8558`](https://github.com/actualbudget/actual/commit/31b8558b46a02357d255275cb1ddf59e1122d7cf) Fix tests - [`0392f9f`](https://github.com/actualbudget/actual/commit/0392f9fd7e534682c156b5649094a36b513b7eea) Fix tests - [`73dd742`](https://github.com/actualbudget/actual/commit/73dd742fee399a71afe98cc04bcf35b739b795fa) Fix tests - [`aec2d83`](https://github.com/actualbudget/actual/commit/aec2d83be54376c1b19f9c75bd8269a25d70cb8f) Fix tests ### 📊 Changes **16 files changed** (+652 additions, -314 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.test.js` (+1 -1) 📝 `packages/desktop-client/src/components/autocomplete/AccountAutocomplete.tsx` (+122 -63) 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+199 -90) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx` (+189 -93) 📝 `packages/desktop-client/src/components/autocomplete/SavedFilterAutocomplete.tsx` (+2 -3) 📝 `packages/desktop-client/src/components/mobile/MobileNavTabs.tsx` (+9 -9) 📝 `packages/desktop-client/src/components/modals/EditField.js` (+103 -26) 📝 `packages/desktop-client/src/components/transactions/MobileTransaction.js` (+5 -4) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.test.js` (+16 -25) ➕ `upcoming-release-notes/1900.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Made autocomplete components easier to tap by making the fonts and paddings larger. Previous: ![image](https://github.com/actualbudget/actual/assets/20313680/9026a0a7-9fc4-4be1-8a30-e28ec328907e) New: ![image](https://github.com/actualbudget/actual/assets/20313680/c3c60354-9318-4e50-bf39-c403a561f3d4) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 06:24:36 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#29937