github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #52] [MERGED] Remove unused imports #2990

New Issue
Closed
opened 2026-02-28 20:34:42 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:34:42 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/52
Author: @TomAFrench
Created: 5/7/2022
Status: ✅ Merged
Merged: 8/23/2022
Merged by: @jlongster

Base: master ← Head: remove-unused-imports

📝 Commits (4)

  • f0d1ef1 refactor: remove unused imports
  • 09e0608 style: nicer re-exporting syntax
  • 73a5edf revert: revert pruning of svg imports
  • 822aeae Merge branch 'master' into remove-unused-imports

📊 Changes

65 files changed (+41 additions, -130 deletions)

View changed files

📝 packages/loot-core/src/client/actions/account.js (+1 -1)
📝 packages/loot-core/src/client/actions/sync.js (+0 -3)
📝 packages/loot-core/src/client/actions/tutorial.js (+0 -1)
📝 packages/loot-core/src/client/data-hooks/accounts.js (+2 -2)
📝 packages/loot-core/src/client/data-hooks/payees.js (+2 -2)
📝 packages/loot-core/src/client/data-hooks/schedules.js (+2 -4)
📝 packages/loot-core/src/client/query-helpers.js (+1 -1)
📝 packages/loot-core/src/mocks/plaid.js (+0 -1)
📝 packages/loot-core/src/mocks/setup.js (+0 -1)
📝 packages/loot-core/src/platform/server/fs/index.web.test.js (+1 -10)
📝 packages/loot-core/src/server/accounts/export-to-csv.js (+0 -1)
📝 packages/loot-core/src/server/accounts/rules.js (+0 -1)
📝 packages/loot-core/src/server/accounts/rules.test.js (+0 -1)
📝 packages/loot-core/src/server/accounts/sync.js (+1 -10)
📝 packages/loot-core/src/server/accounts/transaction-rules.js (+0 -2)
📝 packages/loot-core/src/server/accounts/transaction-rules.test.js (+0 -2)
📝 packages/loot-core/src/server/accounts/transactions.js (+0 -1)
📝 packages/loot-core/src/server/api.js (+0 -4)
📝 packages/loot-core/src/server/aql/schema/executors.js (+0 -1)
📝 packages/loot-core/src/server/aql/schema/executors.test.js (+1 -5)

...and 45 more files

📄 Description

We have a lot of unused imports currently (such that this warning is silenced in eslint) which just adds a lot of noise to the files.

I've run a linting rule to strip these out on a branch with a more comprehensive eslint setup and cherry-picked this change onto master to help clear these out.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/52 **Author:** [@TomAFrench](https://github.com/TomAFrench) **Created:** 5/7/2022 **Status:** ✅ Merged **Merged:** 8/23/2022 **Merged by:** [@jlongster](https://github.com/jlongster) **Base:** `master` ← **Head:** `remove-unused-imports` --- ### 📝 Commits (4) - [`f0d1ef1`](https://github.com/actualbudget/actual/commit/f0d1ef148c5d3ba37a830dd3c66658aa3058ceff) refactor: remove unused imports - [`09e0608`](https://github.com/actualbudget/actual/commit/09e06085ea3ef81032649f08f1cd0af39063b5ed) style: nicer re-exporting syntax - [`73a5edf`](https://github.com/actualbudget/actual/commit/73a5edfa7f7fd0f18062305f1a7ed0c5c1f2231e) revert: revert pruning of svg imports - [`822aeae`](https://github.com/actualbudget/actual/commit/822aeaea7976b020f30a022345c795e0dc00baaa) Merge branch 'master' into remove-unused-imports ### 📊 Changes **65 files changed** (+41 additions, -130 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/client/actions/account.js` (+1 -1) 📝 `packages/loot-core/src/client/actions/sync.js` (+0 -3) 📝 `packages/loot-core/src/client/actions/tutorial.js` (+0 -1) 📝 `packages/loot-core/src/client/data-hooks/accounts.js` (+2 -2) 📝 `packages/loot-core/src/client/data-hooks/payees.js` (+2 -2) 📝 `packages/loot-core/src/client/data-hooks/schedules.js` (+2 -4) 📝 `packages/loot-core/src/client/query-helpers.js` (+1 -1) 📝 `packages/loot-core/src/mocks/plaid.js` (+0 -1) 📝 `packages/loot-core/src/mocks/setup.js` (+0 -1) 📝 `packages/loot-core/src/platform/server/fs/index.web.test.js` (+1 -10) 📝 `packages/loot-core/src/server/accounts/export-to-csv.js` (+0 -1) 📝 `packages/loot-core/src/server/accounts/rules.js` (+0 -1) 📝 `packages/loot-core/src/server/accounts/rules.test.js` (+0 -1) 📝 `packages/loot-core/src/server/accounts/sync.js` (+1 -10) 📝 `packages/loot-core/src/server/accounts/transaction-rules.js` (+0 -2) 📝 `packages/loot-core/src/server/accounts/transaction-rules.test.js` (+0 -2) 📝 `packages/loot-core/src/server/accounts/transactions.js` (+0 -1) 📝 `packages/loot-core/src/server/api.js` (+0 -4) 📝 `packages/loot-core/src/server/aql/schema/executors.js` (+0 -1) 📝 `packages/loot-core/src/server/aql/schema/executors.test.js` (+1 -5) _...and 45 more files_ </details> ### 📄 Description We have a lot of unused imports currently (such that this warning is silenced in eslint) which just adds a lot of noise to the files. I've run a linting rule to strip these out on a branch with a more comprehensive eslint setup and cherry-picked this change onto master to help clear these out. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:34:42 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#2990
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?