github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #1423] [MERGED] 🐛 fix number formatter not listening to state changes #29655

New Issue
Closed
opened 2026-04-18 06:12:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 06:12:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1423
Author: @MatissJanis
Created: 7/30/2023
Status: ✅ Merged
Merged: 7/30/2023
Merged by: @MatissJanis

Base: master ← Head: matiss/fix-1415

📝 Commits (5)

  • 482bf6f 🐛 fix number formatter not listening to state changes
  • f13e72e Release notes
  • 1243a98 Add reselect
  • 071ef93 Remove @types/reselect
  • 97c8aa2 Relocate the selector fn to loot-core

📊 Changes

7 files changed (+91 additions, -28 deletions)

View changed files

📝 packages/desktop-client/src/components/spreadsheet/CellValue.tsx (+3 -1)
📝 packages/desktop-client/src/components/spreadsheet/format.ts (+26 -5)
📝 packages/loot-core/package.json (+1 -0)
➕ packages/loot-core/src/client/selectors.ts (+17 -0)
📝 packages/loot-core/src/shared/util.ts (+30 -22)
➕ upcoming-release-notes/1423.md (+6 -0)
📝 yarn.lock (+8 -0)

📄 Description

Closes #1415

Fix number formatter not listening to state changes. This is not a fully comprehensive solution. We will need to run a migration campaign to port over from direct usage of format util to useFormat, but this is a first step that solves the most glaring issue.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1423 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 7/30/2023 **Status:** ✅ Merged **Merged:** 7/30/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/fix-1415` --- ### 📝 Commits (5) - [`482bf6f`](https://github.com/actualbudget/actual/commit/482bf6fc779ec42b8cf05930e9884099d44fad73) :bug: fix number formatter not listening to state changes - [`f13e72e`](https://github.com/actualbudget/actual/commit/f13e72e50ce8c9e64a9b762af98411940b36981f) Release notes - [`1243a98`](https://github.com/actualbudget/actual/commit/1243a984ace697ed50b132b0abca82a2717b4abf) Add reselect - [`071ef93`](https://github.com/actualbudget/actual/commit/071ef936c3832d4a95a5f198ce57b58593b81c39) Remove @types/reselect - [`97c8aa2`](https://github.com/actualbudget/actual/commit/97c8aa24033ab842956e02f9c75e61fa33c36e3f) Relocate the selector fn to loot-core ### 📊 Changes **7 files changed** (+91 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/spreadsheet/CellValue.tsx` (+3 -1) 📝 `packages/desktop-client/src/components/spreadsheet/format.ts` (+26 -5) 📝 `packages/loot-core/package.json` (+1 -0) ➕ `packages/loot-core/src/client/selectors.ts` (+17 -0) 📝 `packages/loot-core/src/shared/util.ts` (+30 -22) ➕ `upcoming-release-notes/1423.md` (+6 -0) 📝 `yarn.lock` (+8 -0) </details> ### 📄 Description Closes #1415 Fix number formatter not listening to state changes. This is not a fully comprehensive solution. We will need to run a migration campaign to port over from direct usage of `format` util to `useFormat`, but this is a first step that solves the most glaring issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 06:12:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#29655
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?