[PR #1391] [MERGED] Adapt the top level components to dark mode #29633

Closed
opened 2026-04-18 06:11:23 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1391
Author: @j-f1
Created: 7/23/2023
Status: Merged
Merged: 7/24/2023
Merged by: @j-f1

Base: masterHead: jed/dark-apps


📝 Commits (8)

  • 00b3baf Adapt the top level components to dark mode
  • 73adcbb Rename navy → blue, gray → navy
  • 720500a Add a true gray color scale
  • 6f6a31f Swap in the true gray for the page background
  • 0294f28 Adapt the manager background to be lazy loaded + dark adaptive
  • d7767a9 Update light mode warning colors to match
  • 0135833 Fix custom page text color in light mode
  • 1ee9a20 Add release note

📊 Changes

16 files changed (+412 additions, -254 deletions)

View changed files

📝 packages/desktop-client/public/index.html (+1 -2)
📝 packages/desktop-client/src/components/App.js (+0 -1)
📝 packages/desktop-client/src/components/AppBackground.js (+3 -3)
packages/desktop-client/src/components/Background.js (+0 -23)
packages/desktop-client/src/components/Background.tsx (+57 -0)
packages/desktop-client/src/components/BackgroundImage.tsx (+107 -0)
📝 packages/desktop-client/src/components/DevelopmentTopBar.tsx (+5 -4)
📝 packages/desktop-client/src/components/FatalError.js (+4 -6)
📝 packages/desktop-client/src/components/FinancesApp.tsx (+9 -5)
📝 packages/desktop-client/src/components/manager/ManagementApp.js (+4 -4)
packages/desktop-client/src/components/manager/bg.svg (+0 -1)
📝 packages/desktop-client/src/style/palette.ts (+33 -22)
📝 packages/desktop-client/src/style/themes/dark.ts (+71 -71)
📝 packages/desktop-client/src/style/themes/development.ts (+34 -34)
📝 packages/desktop-client/src/style/themes/light.ts (+78 -78)
upcoming-release-notes/1391.md (+6 -0)

📄 Description

This updates the management and finance app to apply the theme colors. Things don‘t look very good yet but at least there is some sort of dark mode now.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1391 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 7/23/2023 **Status:** ✅ Merged **Merged:** 7/24/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/dark-apps` --- ### 📝 Commits (8) - [`00b3baf`](https://github.com/actualbudget/actual/commit/00b3baf3dac929243fd92c01557c0c3c26ee2ae8) Adapt the top level components to dark mode - [`73adcbb`](https://github.com/actualbudget/actual/commit/73adcbb91b5c1a21b36522ef3c135d595130ef5c) Rename navy → blue, gray → navy - [`720500a`](https://github.com/actualbudget/actual/commit/720500ad56acf697c676c256931dca4848a53a5d) Add a true gray color scale - [`6f6a31f`](https://github.com/actualbudget/actual/commit/6f6a31fa21978b818198d1b621a8dace00646844) Swap in the true gray for the page background - [`0294f28`](https://github.com/actualbudget/actual/commit/0294f28906783d4360dfbb2c32fff28afd8b9de3) Adapt the manager background to be lazy loaded + dark adaptive - [`d7767a9`](https://github.com/actualbudget/actual/commit/d7767a9bcbea8b1213bcecfecdecb0ae929159e4) Update light mode warning colors to match - [`0135833`](https://github.com/actualbudget/actual/commit/0135833d872f51449a5e41023c055e9ac25f2e53) Fix custom page text color in light mode - [`1ee9a20`](https://github.com/actualbudget/actual/commit/1ee9a209e068aecabebbdcd7738656ea49546051) Add release note ### 📊 Changes **16 files changed** (+412 additions, -254 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/public/index.html` (+1 -2) 📝 `packages/desktop-client/src/components/App.js` (+0 -1) 📝 `packages/desktop-client/src/components/AppBackground.js` (+3 -3) ➖ `packages/desktop-client/src/components/Background.js` (+0 -23) ➕ `packages/desktop-client/src/components/Background.tsx` (+57 -0) ➕ `packages/desktop-client/src/components/BackgroundImage.tsx` (+107 -0) 📝 `packages/desktop-client/src/components/DevelopmentTopBar.tsx` (+5 -4) 📝 `packages/desktop-client/src/components/FatalError.js` (+4 -6) 📝 `packages/desktop-client/src/components/FinancesApp.tsx` (+9 -5) 📝 `packages/desktop-client/src/components/manager/ManagementApp.js` (+4 -4) ➖ `packages/desktop-client/src/components/manager/bg.svg` (+0 -1) 📝 `packages/desktop-client/src/style/palette.ts` (+33 -22) 📝 `packages/desktop-client/src/style/themes/dark.ts` (+71 -71) 📝 `packages/desktop-client/src/style/themes/development.ts` (+34 -34) 📝 `packages/desktop-client/src/style/themes/light.ts` (+78 -78) ➕ `upcoming-release-notes/1391.md` (+6 -0) </details> ### 📄 Description This updates the management and finance app to apply the theme colors. Things don‘t look very good yet but at least there is some sort of dark mode now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 06:11:23 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#29633