github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #1277] [MERGED] Remove some usages of the Select component #29566

New Issue
Closed
opened 2026-04-18 06:08:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 06:08:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1277
Author: @aleetsaiya
Created: 7/4/2023
Status: ✅ Merged
Merged: 7/9/2023
Merged by: @j-f1

Base: master ← Head: remove-select

📝 Commits (10+)

  • e50b6dd removing some usages of the Select component
  • 5f0ce8d Merge branch 'master' into remove-select
  • eef35ac Merge branch 'master' of github.com:actualbudget/actual into remove-select
  • 19e5986 add release note
  • 56a4495 removing some usages of the Select component
  • 3431b8b add release note
  • b9e5aca fix typos
  • 0631a1a fix UI and menu not clickable problems
  • f10e511 Merge branch remove-select of github.com:aleetsaiya/actual into remove-select
  • 6be0897 Merge branch 'master' into remove-select

📊 Changes

5 files changed (+113 additions, -93 deletions)

View changed files

📝 packages/desktop-client/src/components/common/CustomSelect.tsx (+25 -4)
📝 packages/desktop-client/src/components/modals/ImportTransactions.js (+39 -46)
📝 packages/desktop-client/src/components/select/RecurringSchedulePicker.js (+40 -40)
📝 packages/desktop-client/src/components/settings/Format.js (+3 -3)
➕ upcoming-release-notes/1277.md (+6 -0)

📄 Description

Hi, This is my first contribution to this project.

The goal of this PR is to remove some usages of the Select component

Reference to the good first issue #1275

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1277 **Author:** [@aleetsaiya](https://github.com/aleetsaiya) **Created:** 7/4/2023 **Status:** ✅ Merged **Merged:** 7/9/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `remove-select` --- ### 📝 Commits (10+) - [`e50b6dd`](https://github.com/actualbudget/actual/commit/e50b6dd5b81cb5e8caddb85ed7f1e6a7f620693c) removing some usages of the Select component - [`5f0ce8d`](https://github.com/actualbudget/actual/commit/5f0ce8d659fae8b3156ede28da0ff4cf87c07e26) Merge branch 'master' into remove-select - [`eef35ac`](https://github.com/actualbudget/actual/commit/eef35acbcf83d49673bb716ca219146af09df923) Merge branch 'master' of github.com:actualbudget/actual into remove-select - [`19e5986`](https://github.com/actualbudget/actual/commit/19e5986e4011fd1f3b1d5ac78269102d6abc5329) add release note - [`56a4495`](https://github.com/actualbudget/actual/commit/56a4495a7ccd28d76ba9777b72b7f7803bb1101f) removing some usages of the Select component - [`3431b8b`](https://github.com/actualbudget/actual/commit/3431b8b80b9517f50c248f353ce84fda6a269723) add release note - [`b9e5aca`](https://github.com/actualbudget/actual/commit/b9e5aca7a57a2e64247e76428f8eaf3b5f51f1bf) fix typos - [`0631a1a`](https://github.com/actualbudget/actual/commit/0631a1ae95c552ee53fe400ac397a5f39a7f2c61) fix UI and menu not clickable problems - [`f10e511`](https://github.com/actualbudget/actual/commit/f10e511e7717052652e07fa6801115d6de6038b8) Merge branch remove-select of github.com:aleetsaiya/actual into remove-select - [`6be0897`](https://github.com/actualbudget/actual/commit/6be0897d96cab90fd36d915a707ee5d735d4b65b) Merge branch 'master' into remove-select ### 📊 Changes **5 files changed** (+113 additions, -93 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/common/CustomSelect.tsx` (+25 -4) 📝 `packages/desktop-client/src/components/modals/ImportTransactions.js` (+39 -46) 📝 `packages/desktop-client/src/components/select/RecurringSchedulePicker.js` (+40 -40) 📝 `packages/desktop-client/src/components/settings/Format.js` (+3 -3) ➕ `upcoming-release-notes/1277.md` (+6 -0) </details> ### 📄 Description Hi, This is my first contribution to this project. The goal of this PR is to remove some usages of the `Select` component Reference to the good first issue #1275 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 06:08:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#29566
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?