github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #1235] [MERGED] Month picker rework #29539

New Issue
Closed
opened 2026-04-18 06:07:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 06:07:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1235
Author: @Miodec
Created: 6/30/2023
Status: ✅ Merged
Merged: 7/11/2023
Merged by: @j-f1

Base: master ← Head: month-picker

📝 Commits (10+)

  • bcdfe75 extracted month picker to its own file
  • 24c351d reworked month picker
  • 11411c2 added some space between the months and arrow buttons
  • cf2a4c4 updated current month check to make sure it considers future/past years
  • fd0fc8e using bold for current month instead of underline
  • f10f2ec refactored the is selected logic
  • 2382223 updated hover color to line up with other buttons
  • bac7cc7 not allowing user selection of the text inside the month buttons
  • c548932 changed the way hover is handled
  • b7a112a dynamically adjusting target month count based on width

📊 Changes

4 files changed (+175 additions, -151 deletions)

View changed files

➕ packages/desktop-client/src/components/budget/MonthPicker.js (+167 -0)
📝 packages/desktop-client/src/components/budget/misc.js (+1 -150)
📝 packages/desktop-client/src/components/budget/rollover/BudgetSummary.tsx (+1 -1)
➕ upcoming-release-notes/1235.md (+6 -0)

📄 Description

Reworked the budget month picker. Changes include:

  • Moved the month picker into its own file.

  • Variable amount of months displayed. The number of months displayed will now depend on the parent width. Years are displayed above the first visible month of that year.
    image

  • Selected months preview on hover. The selected months will be highlighted to show the user the resulting month range.

https://github.com/actualbudget/actual/assets/13181393/d551d271-e5ff-4c3b-9cf1-ff430a10f70c

  • Selection stays in the center (this also elimiated the need for the arrow buttons)

https://github.com/actualbudget/actual/assets/13181393/8fc949b6-b8a3-4583-a01c-d67ae8900d7e

Other minor changes:

  • Changed the active theme indicator from underline to bold (as discussed on Discord with @j-f1)

Other notes:

  • I originally intended for the years different to the current one to be gray, but Jed said that it might be confusing to users (as it might appear that they are disabled)
    image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1235 **Author:** [@Miodec](https://github.com/Miodec) **Created:** 6/30/2023 **Status:** ✅ Merged **Merged:** 7/11/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `month-picker` --- ### 📝 Commits (10+) - [`bcdfe75`](https://github.com/actualbudget/actual/commit/bcdfe7580244c3bf8bc1e3c1938d5ec9c235c1ca) extracted month picker to its own file - [`24c351d`](https://github.com/actualbudget/actual/commit/24c351dd3f01b66ccf9cb414c8701bbef03dc83d) reworked month picker - [`11411c2`](https://github.com/actualbudget/actual/commit/11411c233efb8d05509414a511c5b6b8d54e08cc) added some space between the months and arrow buttons - [`cf2a4c4`](https://github.com/actualbudget/actual/commit/cf2a4c42661c9dcd663586d742d236f7106a0575) updated current month check to make sure it considers future/past years - [`fd0fc8e`](https://github.com/actualbudget/actual/commit/fd0fc8eec29f14d0d92bf89aa72d075f100374c7) using bold for current month instead of underline - [`f10f2ec`](https://github.com/actualbudget/actual/commit/f10f2eca2e99cce846ee616b3d10a8e5b32bb610) refactored the is selected logic - [`2382223`](https://github.com/actualbudget/actual/commit/23822230eed4d62e272b0310f6c08505b5ae9ec1) updated hover color to line up with other buttons - [`bac7cc7`](https://github.com/actualbudget/actual/commit/bac7cc716c641ba89d1d86ed5c9b587d35587840) not allowing user selection of the text inside the month buttons - [`c548932`](https://github.com/actualbudget/actual/commit/c548932ebaca35cf61b361bd7e4643e9f83ef053) changed the way hover is handled - [`b7a112a`](https://github.com/actualbudget/actual/commit/b7a112a9e1673bf6de4365b080b5187e5214856a) dynamically adjusting target month count based on width ### 📊 Changes **4 files changed** (+175 additions, -151 deletions) <details> <summary>View changed files</summary> ➕ `packages/desktop-client/src/components/budget/MonthPicker.js` (+167 -0) 📝 `packages/desktop-client/src/components/budget/misc.js` (+1 -150) 📝 `packages/desktop-client/src/components/budget/rollover/BudgetSummary.tsx` (+1 -1) ➕ `upcoming-release-notes/1235.md` (+6 -0) </details> ### 📄 Description Reworked the budget month picker. Changes include: - Moved the month picker into its own file. - Variable amount of months displayed. The number of months displayed will now depend on the parent width. Years are displayed above the first visible month of that year. <img width="1172" alt="image" src="https://github.com/actualbudget/actual/assets/13181393/5ac2906e-5a97-4f5a-99c7-4373e5a51e24"> - Selected months preview on hover. The selected months will be highlighted to show the user the resulting month range. https://github.com/actualbudget/actual/assets/13181393/d551d271-e5ff-4c3b-9cf1-ff430a10f70c - Selection stays in the center (this also elimiated the need for the arrow buttons) https://github.com/actualbudget/actual/assets/13181393/8fc949b6-b8a3-4583-a01c-d67ae8900d7e Other minor changes: - Changed the active theme indicator from underline to bold (as discussed on Discord with @j-f1) Other notes: - I originally intended for the years different to the current one to be gray, but Jed said that it might be confusing to users (as it might appear that they are disabled) <img width="653" alt="image" src="https://github.com/actualbudget/actual/assets/13181393/331dbb6d-7da2-4ba9-86dd-4c16b0268940"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 06:07:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#29539
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?