github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #1122] [MERGED] Saved Filters Page #29457

New Issue
Closed
opened 2026-04-18 06:04:23 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 06:04:23 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1122
Author: @carkom
Created: 6/12/2023
Status: ✅ Merged
Merged: 7/2/2023
Merged by: @j-f1

Base: master ← Head: filters

📝 Commits (10+)

📊 Changes

24 files changed (+940 additions, -134 deletions)

View changed files

📝 packages/desktop-client/src/components/ManageRules.js (+11 -2)
📝 packages/desktop-client/src/components/accounts/Account.js (+92 -12)
➕ packages/desktop-client/src/components/autocomplete/SavedFilterAutocomplete.js (+64 -0)
📝 packages/desktop-client/src/components/common.tsx (+1 -0)
📝 packages/desktop-client/src/components/filters/FiltersMenu.js (+44 -14)
➕ packages/desktop-client/src/components/filters/SavedFilters.js (+318 -0)
📝 packages/desktop-client/src/components/modals/EditRule.js (+1 -1)
📝 packages/desktop-client/src/components/reports/CashFlow.js (+12 -23)
📝 packages/desktop-client/src/components/reports/Header.js (+26 -5)
📝 packages/desktop-client/src/components/reports/NetWorth.js (+22 -23)
📝 packages/desktop-client/src/components/reports/graphs/cash-flow-spreadsheet.tsx (+26 -16)
📝 packages/desktop-client/src/components/reports/graphs/net-worth-spreadsheet.tsx (+6 -2)
📝 packages/desktop-client/src/components/util/GenericInput.js (+25 -6)
📝 packages/desktop-client/src/hooks/useFilters.ts (+24 -3)
➕ packages/loot-core/migrations/1685375406832_transaction_filters.sql (+10 -0)
➕ packages/loot-core/src/client/data-hooks/filters.tsx (+22 -0)
📝 packages/loot-core/src/server/accounts/transaction-rules.ts (+28 -26)
📝 packages/loot-core/src/server/aql/schema/index.ts (+7 -0)
➕ packages/loot-core/src/server/filters/app.ts (+179 -0)
➕ packages/loot-core/src/server/filters/types/handlers.d.ts (+7 -0)

...and 4 more files

📄 Description

Hey all, this is still under construction. Just wanted to share my progress and get any feedback as I go so as to not go down any wrong roads.

DONE:

  • New sql table to house the list (Big shout out to @jlongster for setting this up for me)
  • Filters sidebar menu under the "More" heading
  • New filters landing page to display all the currently saved filters
  • Filters form for creating filter (includes any/all logic)
  • Delete menu item
  • OnClick pulls up the Edit menu but needs work *

TODO/Bugs:

  • - Fix Edit - currently not pulling existing data into the form
  • - Add "Filter Filters" box at the top so you can quickly find your filter (DONE)
  • Auto adjust row height (I played around with this for days and couldn't get it working right) (Depreciated)
  • - Form preview table seems to not be working (this is new, had it working a couple days ago) (DONE)
  • - Obviously still needs a link the the filter menu in transactions tables (DONE)
  • - Add "Save Filter" and "Edit Filter" option in the Accounts menu (DONE)
  • Consider addition of "Save Filter" and "Edit Filter" option in the Reports menu (Postponed)
  • - Check that duplicate filter conditions don't already exist (eg. prevent duplicate exact conditions) (DONE)
  • - Apply conditionsOp to Account/Reports pages when pulled from saved filters

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1122 **Author:** [@carkom](https://github.com/carkom) **Created:** 6/12/2023 **Status:** ✅ Merged **Merged:** 7/2/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `filters` --- ### 📝 Commits (10+) - [`91dc67a`](https://github.com/actualbudget/actual/commit/91dc67a6f509724525ee7f4424e0a1dcb0794b65) beep boop - [`7a7035d`](https://github.com/actualbudget/actual/commit/7a7035d35f601294a232e0e9d010708cd3d65c5d) more work - [`f35de7c`](https://github.com/actualbudget/actual/commit/f35de7cd64600a5dafcf038194bc28f6938dcd21) Bulk Load - [`0918709`](https://github.com/actualbudget/actual/commit/09187090abae204ae2e5d6f064bc557ae634719b) Progress - [`09780d2`](https://github.com/actualbudget/actual/commit/09780d22595351e0bf95a33cfad3048d965fee4a) Add Op field - [`00b8b34`](https://github.com/actualbudget/actual/commit/00b8b3435e77d7a182c2dd40032621dad089948b) updates - [`2dcd7de`](https://github.com/actualbudget/actual/commit/2dcd7de48f6fd28639318ef04f86c388907b09dd) Merge pull request #15 from actualbudget/master - [`79de5e1`](https://github.com/actualbudget/actual/commit/79de5e1b35071098188dd8a13b6fa9c9d3c22eb3) Remove modal file - [`4648f4d`](https://github.com/actualbudget/actual/commit/4648f4de2f608b08c949835736aebc5b84feeef0) fix build errors - [`da77073`](https://github.com/actualbudget/actual/commit/da77073701270b84fd78808d06100b324aac6bd0) Fix filter filters search box ### 📊 Changes **24 files changed** (+940 additions, -134 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/ManageRules.js` (+11 -2) 📝 `packages/desktop-client/src/components/accounts/Account.js` (+92 -12) ➕ `packages/desktop-client/src/components/autocomplete/SavedFilterAutocomplete.js` (+64 -0) 📝 `packages/desktop-client/src/components/common.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.js` (+44 -14) ➕ `packages/desktop-client/src/components/filters/SavedFilters.js` (+318 -0) 📝 `packages/desktop-client/src/components/modals/EditRule.js` (+1 -1) 📝 `packages/desktop-client/src/components/reports/CashFlow.js` (+12 -23) 📝 `packages/desktop-client/src/components/reports/Header.js` (+26 -5) 📝 `packages/desktop-client/src/components/reports/NetWorth.js` (+22 -23) 📝 `packages/desktop-client/src/components/reports/graphs/cash-flow-spreadsheet.tsx` (+26 -16) 📝 `packages/desktop-client/src/components/reports/graphs/net-worth-spreadsheet.tsx` (+6 -2) 📝 `packages/desktop-client/src/components/util/GenericInput.js` (+25 -6) 📝 `packages/desktop-client/src/hooks/useFilters.ts` (+24 -3) ➕ `packages/loot-core/migrations/1685375406832_transaction_filters.sql` (+10 -0) ➕ `packages/loot-core/src/client/data-hooks/filters.tsx` (+22 -0) 📝 `packages/loot-core/src/server/accounts/transaction-rules.ts` (+28 -26) 📝 `packages/loot-core/src/server/aql/schema/index.ts` (+7 -0) ➕ `packages/loot-core/src/server/filters/app.ts` (+179 -0) ➕ `packages/loot-core/src/server/filters/types/handlers.d.ts` (+7 -0) _...and 4 more files_ </details> ### 📄 Description Hey all, this is still under construction. Just wanted to share my progress and get any feedback as I go so as to not go down any wrong roads. DONE: - New sql table to house the list (Big shout out to @jlongster for setting this up for me) - Filters sidebar menu under the "More" heading - New filters landing page to display all the currently saved filters - Filters form for creating filter (includes any/all logic) - Delete menu item - OnClick pulls up the Edit menu but needs work * TODO/Bugs: - [x] - Fix Edit - currently not pulling existing data into the form - [x] - Add "Filter Filters" box at the top so you can quickly find your filter (**DONE**) - Auto adjust row height (I played around with this for days and couldn't get it working right) (**Depreciated**) - [x] - Form preview table seems to not be working (this is new, had it working a couple days ago) (**DONE**) - [x] - Obviously still needs a link the the filter menu in transactions tables (**DONE**) - [x] - Add "Save Filter" and "Edit Filter" option in the Accounts menu (**DONE**) - Consider addition of "Save Filter" and "Edit Filter" option in the **Reports** menu (**Postponed**) - [x] - Check that duplicate filter conditions don't already exist (eg. prevent duplicate exact conditions) (**DONE**) - [x] - Apply conditionsOp to Account/Reports pages when pulled from saved filters --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 06:04:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#29457
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?