[PR #771] [MERGED] reducing flakiness of tests by removing randomization #29241

Closed
opened 2026-04-18 05:56:01 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/771
Author: @MatissJanis
Created: 3/17/2023
Status: Merged
Merged: 3/17/2023
Merged by: @MatissJanis

Base: masterHead: matiss/flake


📝 Commits (2)

  • 108083a (reducing flakiness of tests by removing randomization)
  • 6edaa2b Add release notes

📊 Changes

2 files changed (+8 additions, -3 deletions)

View changed files

📝 packages/loot-core/src/mocks/index.js (+2 -3)
upcoming-release-notes/771.md (+6 -0)

📄 Description

This is not a full fix for the flakiness. One of the test cases will still be flaky. But at least this fixes the other test cases thus improving stability.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/771 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/17/2023 **Status:** ✅ Merged **Merged:** 3/17/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/flake` --- ### 📝 Commits (2) - [`108083a`](https://github.com/actualbudget/actual/commit/108083a7fad46dc5f34b38e93f23bcb8046edd58) :white_check_mark: (reducing flakiness of tests by removing randomization) - [`6edaa2b`](https://github.com/actualbudget/actual/commit/6edaa2b3e068bbcb53f744ebadf0e549667b83d8) Add release notes ### 📊 Changes **2 files changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/mocks/index.js` (+2 -3) ➕ `upcoming-release-notes/771.md` (+6 -0) </details> ### 📄 Description This is not a full fix for the flakiness. One of the test cases will still be flaky. But at least this fixes the other test cases thus improving stability. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 05:56:01 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#29241