github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #678] [MERGED] Fix error cases in displaying filters/rules #29172

New Issue
Closed
opened 2026-04-18 05:53:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 05:53:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/678
Author: @j-f1
Created: 2/21/2023
Status: ✅ Merged
Merged: 2/23/2023
Merged by: @j-f1

Base: master ← Head: jed/fix-filter-display

📝 Commits (5)

  • 97247a8 Add missing imported_payee case
  • 6482a19 Switch over to a switch to ensure no other cases are missed
  • dbc9e87 Fix switching from “amount” to “amount (inflow/outflow)”
  • 643e2f2 fix crash when parsing null value as number
  • 48c8cb4 Fix formatting for “payee/category/account contains” filters

📊 Changes

3 files changed (+48 additions, -29 deletions)

View changed files

📝 packages/desktop-client/src/components/ManageRules.js (+36 -26)
📝 packages/desktop-client/src/components/accounts/Filters.js (+6 -1)
📝 packages/loot-core/src/shared/rules.js (+6 -2)

📄 Description

This PR fixes a few existing edge cases, along with a few I probably introduced in #646. I’ve now tested all of the different filter types both in rules and in the account view, and things seem to work OK.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/678 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 2/21/2023 **Status:** ✅ Merged **Merged:** 2/23/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/fix-filter-display` --- ### 📝 Commits (5) - [`97247a8`](https://github.com/actualbudget/actual/commit/97247a86d214fc2f56f63fd5aa88c7219455d031) Add missing imported_payee case - [`6482a19`](https://github.com/actualbudget/actual/commit/6482a199cc47c95ff6a3736e71dc132ca1c6d5ee) Switch over to a `switch` to ensure no other cases are missed - [`dbc9e87`](https://github.com/actualbudget/actual/commit/dbc9e87e8d9de488ebd1926c5358f34217eb8845) Fix switching from “amount” to “amount (inflow/outflow)” - [`643e2f2`](https://github.com/actualbudget/actual/commit/643e2f2b043cb0ed20aa646791772b1a28f69048) fix crash when parsing null value as number - [`48c8cb4`](https://github.com/actualbudget/actual/commit/48c8cb46908efe83655eba3a9d640e6a30906c54) Fix formatting for “payee/category/account contains” filters ### 📊 Changes **3 files changed** (+48 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/ManageRules.js` (+36 -26) 📝 `packages/desktop-client/src/components/accounts/Filters.js` (+6 -1) 📝 `packages/loot-core/src/shared/rules.js` (+6 -2) </details> ### 📄 Description This PR fixes a few existing edge cases, along with a few I probably introduced in #646. I’ve now tested all of the different filter types both in rules and in the account view, and things seem to work OK. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 05:53:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#29172
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?