github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #492] [MERGED] ⬆️ upgrade eslint-plugin-import and fix issues #29101

New Issue
Closed
opened 2026-04-18 05:49:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 05:49:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/492
Author: @MatissJanis
Created: 1/21/2023
Status: ✅ Merged
Merged: 1/25/2023
Merged by: @MatissJanis

Base: master ← Head: matiss/upgrade-eslint-plugin-import

📝 Commits (3)

  • 55b7d60 ⬆️ upgrade eslint-plugin-import and fix issues
  • 001fcc9 Change import ordering
  • a84916b Merge branch 'master' into matiss/upgrade-eslint-plugin-import

📊 Changes

113 files changed (+393 additions, -39 deletions)

View changed files

📝 .eslintrc.js (+2 -1)
📝 packages/desktop-client/package.json (+1 -1)
📝 packages/desktop-client/src/components/App.js (+1 -0)
📝 packages/desktop-client/src/components/FinancesApp.js (+1 -0)
📝 packages/desktop-client/src/components/Titlebar.js (+1 -0)
📝 packages/desktop-client/src/components/accounts/Account.js (+1 -0)
📝 packages/desktop-client/src/components/accounts/MobileAccount.js (+1 -0)
📝 packages/desktop-client/src/components/budget/MobileBudget.js (+1 -0)
📝 packages/desktop-client/src/components/budget/MobileBudgetTable.js (+1 -0)
📝 packages/desktop-client/src/components/manager/ConfigServer.js (+1 -0)
📝 packages/desktop-client/src/components/manager/ManagementApp.js (+1 -0)
📝 packages/desktop-client/src/components/payees/ManagePayeesPage.js (+1 -0)
📝 packages/desktop-client/src/components/schedules/DiscoverSchedules.js (+1 -0)
📝 packages/desktop-client/src/components/schedules/LinkSchedule.js (+1 -0)
📝 packages/desktop-client/src/components/schedules/SchedulesTable.js (+1 -0)
📝 packages/desktop-client/src/components/schedules/index.js (+1 -0)
📝 packages/desktop-client/src/components/settings/Encryption.js (+1 -0)
📝 packages/desktop-client/src/components/settings/index.js (+1 -0)
📝 packages/loot-core/package.json (+1 -1)
📝 packages/loot-core/src/client/actions/account.js (+1 -0)

...and 80 more files

📄 Description

Apologies for the large PR.

Basically two changes here:

  1. upgrade eslint-plugin-import to the latest version
  2. run auto-fixer to fix all the issues (just re-shuffles some imports without changing any functionality)

Why the extra space between parent and sibling group?

The alternative is to move parent below sibling imports: example. Personally, I don't prefer this approach. So if the choice is between 1) keeping the import order as-is, but having a new line between them and 2) changing so parent imports go below sibling - I would prefer to go with option 1.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/492 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 1/21/2023 **Status:** ✅ Merged **Merged:** 1/25/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/upgrade-eslint-plugin-import` --- ### 📝 Commits (3) - [`55b7d60`](https://github.com/actualbudget/actual/commit/55b7d60d0e729592e1e5311615c9336745904467) :arrow_up: upgrade eslint-plugin-import and fix issues - [`001fcc9`](https://github.com/actualbudget/actual/commit/001fcc9cff62ed6d44011288d68a13839b4e0e0c) Change import ordering - [`a84916b`](https://github.com/actualbudget/actual/commit/a84916b3df73579c38538f6bb40ad0790f8f7b9b) Merge branch 'master' into matiss/upgrade-eslint-plugin-import ### 📊 Changes **113 files changed** (+393 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `.eslintrc.js` (+2 -1) 📝 `packages/desktop-client/package.json` (+1 -1) 📝 `packages/desktop-client/src/components/App.js` (+1 -0) 📝 `packages/desktop-client/src/components/FinancesApp.js` (+1 -0) 📝 `packages/desktop-client/src/components/Titlebar.js` (+1 -0) 📝 `packages/desktop-client/src/components/accounts/Account.js` (+1 -0) 📝 `packages/desktop-client/src/components/accounts/MobileAccount.js` (+1 -0) 📝 `packages/desktop-client/src/components/budget/MobileBudget.js` (+1 -0) 📝 `packages/desktop-client/src/components/budget/MobileBudgetTable.js` (+1 -0) 📝 `packages/desktop-client/src/components/manager/ConfigServer.js` (+1 -0) 📝 `packages/desktop-client/src/components/manager/ManagementApp.js` (+1 -0) 📝 `packages/desktop-client/src/components/payees/ManagePayeesPage.js` (+1 -0) 📝 `packages/desktop-client/src/components/schedules/DiscoverSchedules.js` (+1 -0) 📝 `packages/desktop-client/src/components/schedules/LinkSchedule.js` (+1 -0) 📝 `packages/desktop-client/src/components/schedules/SchedulesTable.js` (+1 -0) 📝 `packages/desktop-client/src/components/schedules/index.js` (+1 -0) 📝 `packages/desktop-client/src/components/settings/Encryption.js` (+1 -0) 📝 `packages/desktop-client/src/components/settings/index.js` (+1 -0) 📝 `packages/loot-core/package.json` (+1 -1) 📝 `packages/loot-core/src/client/actions/account.js` (+1 -0) _...and 80 more files_ </details> ### 📄 Description Apologies for the large PR. Basically two changes here: 1. upgrade `eslint-plugin-import` to the latest version 2. run auto-fixer to fix all the issues (just re-shuffles some imports without changing any functionality) **Why the extra space between `parent` and `sibling` group?** The alternative is to move `parent` below `sibling` imports: [example](https://github.com/actualbudget/actual/pull/492/commits/55b7d60d0e729592e1e5311615c9336745904467). Personally, I don't prefer this approach. So if the choice is between 1) keeping the import order as-is, but having a new line between them and 2) changing so parent imports go below sibling - I would prefer to go with option 1. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 05:49:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#29101
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?