github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-15 22:54:03 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #464] [MERGED] Updates to the @actual-budget/api package #29080

New Issue
Closed
opened 2026-04-18 05:48:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 05:48:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/464
Author: @j-f1
Created: 1/14/2023
Status: ✅ Merged
Merged: 2/24/2023
Merged by: @j-f1

Base: master ← Head: api-v5

📝 Commits (10+)

  • 1b714ba Make it easier to build the bundle.api.js for the API
  • 3cc3c98 Remove budgetId parameter, move config to top level of API
  • 0dce6f9 that’s a breaking change
  • 9e7353b Add support for signing into the server in init()
  • 742426b Add api.downloadBudget(syncId, { password }) method
  • a847424 Fix lint errors
  • 4b3dee3 Refactor: extract out getSyncError
  • 3421eca api/download-budget: sync if possible instead of downloading
  • 91365ce Don’t bother with fetching remote files and installing key if the file is local
  • 7b2cec0 *groupId

📊 Changes

9 files changed (+112 additions, -47 deletions)

View changed files

📝 .github/workflows/build.yml (+1 -1)
📝 packages/api/index.js (+3 -3)
📝 packages/api/methods.js (+7 -2)
📝 packages/api/package.json (+4 -1)
📝 packages/loot-core/src/client/actions/budgets.js (+6 -14)
📝 packages/loot-core/src/server/api.js (+51 -12)
📝 packages/loot-core/src/server/main.js (+16 -12)
📝 packages/loot-core/src/shared/errors.js (+14 -0)
📝 packages/loot-core/webpack/webpack.api.config.js (+10 -2)

📄 Description

While working on https://github.com/actualbudget/docs/pull/76, I made some improvements to make the API easier to use.

@jlongster if possible I would love a review of these changes, especially around handling keys (in packages/loot-core/src/server/api.js). I want to make sure I’m guiding people down a correct and stable path here.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/464 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 1/14/2023 **Status:** ✅ Merged **Merged:** 2/24/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `api-v5` --- ### 📝 Commits (10+) - [`1b714ba`](https://github.com/actualbudget/actual/commit/1b714bafecf2f36a8d261a47b9451fbe4eba55b6) Make it easier to build the bundle.api.js for the API - [`3cc3c98`](https://github.com/actualbudget/actual/commit/3cc3c98483446659af22cb3bea65522d77ca2d88) Remove budgetId parameter, move config to top level of API - [`0dce6f9`](https://github.com/actualbudget/actual/commit/0dce6f9c84b0025006c5f61368b94e6303c8a145) that’s a breaking change - [`9e7353b`](https://github.com/actualbudget/actual/commit/9e7353bf214642dd45020dfffac80749d1975ef5) Add support for signing into the server in init() - [`742426b`](https://github.com/actualbudget/actual/commit/742426b01c8c95208851356e2a711773dc7d7dc7) Add api.downloadBudget(syncId, { password }) method - [`a847424`](https://github.com/actualbudget/actual/commit/a8474247b71aa5640fe18dc1f2656a588e4c4e2d) Fix lint errors - [`4b3dee3`](https://github.com/actualbudget/actual/commit/4b3dee302f3366e64231cab8ef9f5ce0a71f4294) Refactor: extract out getSyncError - [`3421eca`](https://github.com/actualbudget/actual/commit/3421ecab8f6527baad76f1ea957573a175d861d2) api/download-budget: sync if possible instead of downloading - [`91365ce`](https://github.com/actualbudget/actual/commit/91365ce7fc0aebe6e3256bf59e0a61c10dd50bc2) Don’t bother with fetching remote files and installing key if the file is local - [`7b2cec0`](https://github.com/actualbudget/actual/commit/7b2cec0c44cabbf67edb52924ece380b3df84241) *groupId ### 📊 Changes **9 files changed** (+112 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+1 -1) 📝 `packages/api/index.js` (+3 -3) 📝 `packages/api/methods.js` (+7 -2) 📝 `packages/api/package.json` (+4 -1) 📝 `packages/loot-core/src/client/actions/budgets.js` (+6 -14) 📝 `packages/loot-core/src/server/api.js` (+51 -12) 📝 `packages/loot-core/src/server/main.js` (+16 -12) 📝 `packages/loot-core/src/shared/errors.js` (+14 -0) 📝 `packages/loot-core/webpack/webpack.api.config.js` (+10 -2) </details> ### 📄 Description While working on https://github.com/actualbudget/docs/pull/76, I made some improvements to make the API easier to use. @jlongster if possible I would love a review of these changes, especially around handling keys (in `packages/loot-core/src/server/api.js`). I want to make sure I’m guiding people down a correct and stable path here. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 05:48:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#29080
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?