github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #7479] Missing jws runtime dependency in packages/sync-server/package.json #28883

New Issue
Closed
opened 2026-04-18 05:37:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 05:37:28 -05:00
Owner
Copy Link

Originally created by @coderabbitai[bot] on GitHub (Apr 11, 2026).
Original GitHub issue: https://github.com/actualbudget/actual/issues/7479

Originally assigned to: @MatissJanis on GitHub.

Problem

In PR #7345, packages/sync-server/src/app-enablebanking/utils/jwt.ts imports sign from the jws package as a runtime dependency:

import { sign } from 'jws';

However, packages/sync-server/package.json only declares @types/jws as a devDependency — the actual jws runtime package is not listed as a direct dependency. This means the code is currently relying on jws being available as a transitive dependency of some other package.

Transitive dependencies should not be relied upon directly, as they can be removed or updated without warning when the parent package changes.

Expected Fix

Add jws as an explicit dependency in packages/sync-server/package.json:

"dependencies": {
  "jws": "^x.x.x"
}

References

Originally created by @coderabbitai[bot] on GitHub (Apr 11, 2026). Original GitHub issue: https://github.com/actualbudget/actual/issues/7479 Originally assigned to: @MatissJanis on GitHub. ## Problem In PR #7345, `packages/sync-server/src/app-enablebanking/utils/jwt.ts` imports `sign` from the `jws` package as a runtime dependency: ```ts import { sign } from 'jws'; ``` However, `packages/sync-server/package.json` only declares `@types/jws` as a devDependency — the actual `jws` runtime package is not listed as a direct dependency. This means the code is currently relying on `jws` being available as a **transitive dependency** of some other package. Transitive dependencies should not be relied upon directly, as they can be removed or updated without warning when the parent package changes. ## Expected Fix Add `jws` as an explicit dependency in `packages/sync-server/package.json`: ```json "dependencies": { "jws": "^x.x.x" } ``` ## References - PR: https://github.com/actualbudget/actual/pull/7345 - Comment: https://github.com/actualbudget/actual/pull/7345#discussion_r3068362047 - Requested by: @MatissJanis
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#28883
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?