github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-08 04:49:45 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[GH-ISSUE #6548] lint: enforce consistent TypeScript type import style #28562

New Issue
Closed
opened 2026-04-18 05:19:05 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-18 05:19:05 -05:00
Owner
Copy Link

Originally created by @coderabbitai[bot] on GitHub (Jan 4, 2026).
Original GitHub issue: https://github.com/actualbudget/actual/issues/6548

Problem

The codebase currently has inconsistent TypeScript type import styles. Some files use:

import type { Foo, Bar } from 'module';

While others use:

import { type Foo, type Bar } from 'module';

Proposal

We should enforce a consistent style using ESLint's OXlint @typescript-eslint/consistent-type-imports rule.

References

Originally created by @coderabbitai[bot] on GitHub (Jan 4, 2026). Original GitHub issue: https://github.com/actualbudget/actual/issues/6548 ## Problem The codebase currently has inconsistent TypeScript type import styles. Some files use: ```typescript import type { Foo, Bar } from 'module'; ``` While others use: ```typescript import { type Foo, type Bar } from 'module'; ``` ## Proposal We should enforce a consistent style using ~ESLint's~ OXlint `@typescript-eslint/consistent-type-imports` rule. ## References - Requested in: https://github.com/actualbudget/actual/pull/6411#discussion_r2659862273 - Related PR: https://github.com/actualbudget/actual/pull/6411 - Requested by: @MatissJanis
GiteaMirror added the tech debtgood first issue labels 2026-04-18 05:19:06 -05:00
GiteaMirror commented 2026-04-18 05:19:07 -05:00
Author
Owner
Copy Link

@miski-h commented on GitHub (Jan 4, 2026):

Hi! I'd like to work on this.

<!-- gh-comment-id:3708353640 --> @miski-h commented on GitHub (Jan 4, 2026): Hi! I'd like to work on this.
GiteaMirror commented 2026-04-18 05:19:08 -05:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Jan 4, 2026):

Feel free to send a PR for it. We do not generally assign tickets to people.

<!-- gh-comment-id:3708390330 --> @MatissJanis commented on GitHub (Jan 4, 2026): Feel free to send a PR for it. We do not generally assign tickets to people.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label good first issue tech debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#28562
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?