github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 15:14:02 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[GH-ISSUE #5945] [Bug]: Template strings in GoalTemplateModal uses currency ($) #28340

New Issue
Closed
opened 2026-04-18 05:03:27 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-18 05:03:27 -05:00
Owner
Copy Link

Originally created by @stefanedwards on GitHub (Oct 17, 2025).
Original GitHub issue: https://github.com/actualbudget/actual/issues/5945

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

The file packages/desktop-client/src/components/modals/GoalTemplateModal.tsx is a help-module describing the templating format, accessible via the help-menu when on the budget-page.

It has examples such as #template up to $150 with the description "Up to $150 each month, and remove extra funds over $150".

Actual seems to ignore the currency symbol ($) and translating it becomes a bit odd, as e.g., the Danish translation should refer to the $150 dollars. Hint: We have a different currency in Denmark.

Furthermore, I fear that the examples in the template-string might lead users in other countries to falsely believe that the template functions only works with budgets using dollars.

Lastly, the documentation (https://actualbudget.org/docs/experimental/goal-templates) does not use currency in the template-strings at all.

The solution is easy: Remove $ symbols in the template strings in GoalTemplateModal.tsx.

How can we reproduce the issue?

Open the GoalTemplate modal, via the help-menu from the budget-page.

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

Originally created by @stefanedwards on GitHub (Oct 17, 2025). Original GitHub issue: https://github.com/actualbudget/actual/issues/5945 ### Verified issue does not already exist? - [x] I have searched and found no existing issue ### What happened? The file `packages/desktop-client/src/components/modals/GoalTemplateModal.tsx` is a help-module describing the templating format, accessible via the help-menu when on the budget-page. It has examples such as `#template up to $150` with the description "Up to $150 each month, and remove extra funds over $150". Actual seems to ignore the currency symbol (`$`) and translating it becomes a bit odd, as e.g., the Danish translation should refer to the $150 dollars. Hint: We have a different currency in Denmark. Furthermore, I fear that the examples in the template-string might lead users in other countries to falsely believe that the template functions only works with budgets using dollars. Lastly, the documentation (https://actualbudget.org/docs/experimental/goal-templates) does not use currency in the template-strings at all. The solution is easy: Remove `$` symbols in the template strings in `GoalTemplateModal.tsx`. ### How can we reproduce the issue? Open the GoalTemplate modal, via the help-menu from the budget-page. ### Where are you hosting Actual? None ### What browsers are you seeing the problem on? _No response_ ### Operating System None
GiteaMirror added the good first issueuser interfacebug labels 2026-04-18 05:03:27 -05:00
GiteaMirror commented 2026-04-18 05:03:29 -05:00
Author
Owner
Copy Link

@matt-fidd commented on GitHub (Oct 17, 2025):

I suppose this isn't a bug per-se, but I'll leave it here for more visibility. It's an easy change so someone might pick it up pretty quickly.

<!-- gh-comment-id:3414589740 --> @matt-fidd commented on GitHub (Oct 17, 2025): I suppose this isn't a bug per-se, but I'll leave it here for more visibility. It's an easy change so someone might pick it up pretty quickly.
GiteaMirror commented 2026-04-18 05:03:29 -05:00
Author
Owner
Copy Link

@stefanedwards commented on GitHub (Oct 17, 2025):

Thanks. Just following the contribution guidelines. There's a PR ready for its fix.

<!-- gh-comment-id:3414603327 --> @stefanedwards commented on GitHub (Oct 17, 2025): Thanks. Just following the contribution guidelines. There's a PR ready for its fix.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug good first issue user interface
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#28340
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?