github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[GH-ISSUE #5726] [Bug]: Reconcile incorrectly parses amounts in swiss francs #28266

New Issue
Closed
opened 2026-04-18 04:56:46 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-04-18 04:56:46 -05:00
Owner
Copy Link

Originally created by @jullanggit on GitHub (Sep 14, 2025).
Original GitHub issue: https://github.com/actualbudget/actual/issues/5726

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

When reconciling and entering an amount like '2’805.53 Fr.' (a possible default value) I get this:

Your cleared balance 2’805.53 Fr. needs +277’747.47 Fr. to match your bank's balance of 280’553.00 Fr.

I think the parser incorrectly uses the '.' after 'Fr' as the decimal point, as this does not happen if I remove the '.'.

I have tried, but failed, to track down this issue. The input seems to follow this path:

desktop-client/src/components/accounts/Reconcile.tsx:ReconcileMenu:onsubmit 
   -> evalArithmetic -> .. -> parsePrimary -> currencyToAmount
   -> amountToInteger
   -> onReconcile
   ...

As far as I could tell everything from evalArithmetic onwards looks the most suspicious, but should work out; currencyToAmount does just use the last '.' as the decimal point, which could be the issue, but everything from the 'F' onwards should have already been filtered out by the regex loop in parsePrimary.
I have confirmed this by adding a test to arithmetic.test.ts, which does seem to correctly parse the given string.

I don't think amountToInteger or onReconcile are to blame here, they both seem pretty simple and don't have any code related to decimal points.

At the end, I am not really sure what causes this, so I am opening this issue, but if someone has an idea what it could be, I would be happy to implement the fix myself!

How can we reproduce the issue?

Set currency to Swiss franc and symbol position to after amount, then reconcile.

Where are you hosting Actual?

Locally via Yarn

What browsers are you seeing the problem on?

Firefox

Operating System

Linux

Originally created by @jullanggit on GitHub (Sep 14, 2025). Original GitHub issue: https://github.com/actualbudget/actual/issues/5726 ### Verified issue does not already exist? - [x] I have searched and found no existing issue ### What happened? When reconciling and entering an amount like '2’805.53 Fr.' (a possible default value) I get this: ``` Your cleared balance 2’805.53 Fr. needs +277’747.47 Fr. to match your bank's balance of 280’553.00 Fr. ``` I think the parser incorrectly uses the '.' after 'Fr' as the decimal point, as this does not happen if I remove the '.'. I have tried, but failed, to track down this issue. The input seems to follow this path: ``` desktop-client/src/components/accounts/Reconcile.tsx:ReconcileMenu:onsubmit -> evalArithmetic -> .. -> parsePrimary -> currencyToAmount -> amountToInteger -> onReconcile ... ``` As far as I could tell everything from `evalArithmetic` onwards looks the most suspicious, but should work out; `currencyToAmount` does just use the last '.' as the decimal point, which could be the issue, but everything from the 'F' onwards should have already been filtered out by the regex loop in `parsePrimary`. I have confirmed this by adding a test to `arithmetic.test.ts`, which does seem to correctly parse the given string. I don't think `amountToInteger` or `onReconcile` are to blame here, they both seem pretty simple and don't have any code related to decimal points. At the end, I am not really sure what causes this, so I am opening this issue, but if someone has an idea what it could be, I would be happy to implement the fix myself! ### How can we reproduce the issue? Set currency to Swiss franc and symbol position to `after amount`, then reconcile. ### Where are you hosting Actual? Locally via Yarn ### What browsers are you seeing the problem on? Firefox ### Operating System Linux
GiteaMirror added the user interfacebug labels 2026-04-18 04:56:46 -05:00
GiteaMirror commented 2026-04-18 04:56:48 -05:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Sep 15, 2025):

I don't think it has anything to do with the currency support. The parsing wont accept numbers of the format 1'000 at all. With the currency set to CHF and symbol after, it parses fine if you exclude the ' from the number

<!-- gh-comment-id:3293511780 --> @youngcw commented on GitHub (Sep 15, 2025): I don't think it has anything to do with the currency support. The parsing wont accept numbers of the format 1'000 at all. With the currency set to CHF and symbol after, it parses fine if you exclude the `'` from the number
GiteaMirror commented 2026-04-18 04:56:48 -05:00
Author
Owner
Copy Link

@jullanggit commented on GitHub (Sep 15, 2025):

Interesting, then I would suggest changing the code for the default value of the field to not include numbers of this format, as the string above was the default for me.

<!-- gh-comment-id:3293727763 --> @jullanggit commented on GitHub (Sep 15, 2025): Interesting, then I would suggest changing the code for the default value of the field to not include numbers of this format, as the string above was the default for me.
GiteaMirror commented 2026-04-18 04:56:49 -05:00
Author
Owner
Copy Link

@jullanggit commented on GitHub (Sep 15, 2025):

Okay, it seems like v25.9.0 fixed the issue, even though I had tried to look for changes in between to make sure I wasn't reporting an already resolved issue, but it seems like I missed the fixing change.
Thank you for your time and the continued great work on actual!

<!-- gh-comment-id:3293753194 --> @jullanggit commented on GitHub (Sep 15, 2025): Okay, it seems like v25.9.0 fixed the issue, even though I had tried to look for changes in between to make sure I wasn't reporting an already resolved issue, but it seems like I missed the fixing change. Thank you for your time and the continued great work on actual!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug user interface
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#28266
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?