mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-16 07:04:23 -05:00
[Bug] Show note icon when account has notes #280
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#280
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MikeBishop on GitHub (Feb 24, 2023).
Verified feature request does not already exist?
💻
Pitch: what problem are you trying to solve?
When a budget category has a note, the note icon is always visible, like this:
Account notes were recently added, but the icon only appears on hover even if there is a note present, like this:
Describe your ideal solution to this problem
Account notes should behave the same way category notes do, displaying the icon all the time if the note is non-empty.
Teaching and learning
No response
@j-f1 commented on GitHub (Feb 24, 2023):
I believe this already happens — can you send a screen recording showing the issue?
@Kidglove57 commented on GitHub (Feb 24, 2023):
I confirm that I cannot see that there is a Note to an account until the mouse is right over that area (right of the account name). Only then it shows both the edit button and the notes button.
https://user-images.githubusercontent.com/93882449/221311181-18e4a04a-81ff-4345-929e-005f32849861.MOV
Apologies for the poor quality of the clip
@j-f1 commented on GitHub (Feb 24, 2023):
You might be on an old version, then — the current version of Actual (
v23.2.9) has the icon always visible:https://user-images.githubusercontent.com/25517624/221312508-f064d04f-3a39-4513-a3f8-3e16432becbe.mov
@Kidglove57 commented on GitHub (Feb 24, 2023):
This is indeed very odd. i have double checked - I am on v 23.2.9! Behaviour for me is as per my clip above.
I have tested as follows on my Mac and on my iPad:
No Accounts note or edit button appears until I move the mouse to that area and then the button does appear and the content of the note is also revealed on hover, as expected.
@shall0pass commented on GitHub (Feb 24, 2023):
I was seeing the same effect @Kidglove57 saw today using the master netlify site, brave browser, windows 10. I don't see the same behavior in brave on Android. I'll see if I can repro it later.
Edit:
This was captured from the latest release, not the netlify image.
@Kidglove57 commented on GitHub (Feb 25, 2023):
@MatissJanis @shall0pass just to confirm that all my accounts have notes and I am still not seeing the accounts notes button until I move the mouse to that area.
@gsumpster commented on GitHub (Feb 25, 2023):
@Kidglove57, can you shoot over the version of Safari that you're seeing this on? I'm unable to reproduce on 16.2 on my Mac, even with notes on all accounts
@Kidglove57 commented on GitHub (Feb 25, 2023):
@gsumpster thanks! I have Safari 16.3. However, the Accounts note icon is not visible for me on my MacBook Air, or my iPad Air, in Safari, Firefox, Brave, Chrome.
BUT interestingly on setting up a new account and note in the preview version (Netlify) I can now see the note icon!
I then tried adding a brand new account and note in my production version of Actual - but still no account icon showing. I also downloaded a new browser (Edge for Mac) and tried that but still no icon.
PS: I then cleared my cache on Firefox and relaunched and the accounts notes icon showed. But next time I tried the icon was again no longer visible. Clearing the cache made no difference at all on Safari.
EDIT: For clarity, I can see the Monthly Budget Notes and the Category notes when these are populated. It is just the accounts note I have the problem with.
EDIT: If I select use desktop site in iPhone/iOS I cannot see the notes icon either - so I am at least consistent!
RANDOM THOUGHT : Might it have anything to do with the fact that the adjacent icon for editing the account name is hidden by default?
@MatissJanis commented on GitHub (Feb 25, 2023):
Are you able to reproduce the issue here? https://actualbudget.netlify.app/
If yes: could you provide reproduction steps?
@Kidglove57 commented on GitHub (Feb 25, 2023):
@MatissJanis No. I confirm that I cannot reproduce the issue at https://actualbudget.netlify.app/
However, I have tested my two production files (PikaPods and Fly hosted) for Actual on every browser I have on my MacBook Air (Firefox, Safari, Edge, Brave and Chrome), iPad Air and iPhone (with populated accounts notes). The notes icon does not show on any of them until I hover over that area.
I'll be interested to hear what @MikeBishop and @shall0pass report.
@shall0pass commented on GitHub (Feb 25, 2023):
I just used the netlify link and was able to reproduce the problem. I linked it to my personal actual-server instance to pull my budget.
I then logged out of my server and loaded a test budget. Added "Ally" to the note and tried. This was the result.
@shall0pass commented on GitHub (Feb 25, 2023):
I'll add. I cannot consistently repeat this behaviour. I tried using Edge, and got the expected results where the icon is visible when text is present. I couldn't even repeat the bahaviour this morning using the same browser on the same computer on the same netlify link. I don't have any insights into what is different beside AM or PM.
@Kidglove57 commented on GitHub (Feb 26, 2023):
I have experimented further with my real life file.
But this is where it gets puzzling.
I have no idea what all this means but I have been able to consistently reproduce this in several experiments this morning. In other words, the Notes icon is only visible
(a) in Netlify using any browser and
(b) when launching from the dock using a link dragged from Safari and regardless of what my default browser is.
Meanwhile, the category and month note icons remain visible in all these experiments!
@Kidglove57 commented on GitHub (Feb 26, 2023):
IMPORTANT UPDATE TO PREVIOUS POST:
I think I have a breakthrough. As background to this, The URL that I have saved always launches Actual to open at my Budget screen. When I do this the Accounts Note icon cannot be seen.
Quite by accident I just realised that if the URL that I use is specifically set to (say) "www.xxx.net/accounts" then I can see the Notes icon after launch (this was why the URL that I had dragged to the dock worked!)
EDIT and WARNING
My solution throws up other issues. After specififying “www.xxx.net/accounts” as my shortcut all my transaction entries and scheduled transactions started to duplicate! I had to revert to the old url and no account note icons
@MikeBishop commented on GitHub (Feb 27, 2023):
I'm seeing something similar with Brave/Windows. If I click my usual shortcut (to
/budget) and then click to the account with the note, the icon isn't there. If I manually type the/accountsURL and then click to the same account, the note does display. Going with no URL beyond the hostname redirects to/budgetand has the same behavior as my shortcut, no icon.@j-f1 commented on GitHub (Feb 27, 2023):
This is a CSS issue where the
opacity: 1is being overridden byopacity: 0on the parent.@Kidglove57 commented on GitHub (Feb 27, 2023):
Thank you @j-f1. Much appreciated and good to know that those of us experiencing are not simply outliers.
@j-f1 commented on GitHub (Feb 27, 2023):
Can you try with https://deploy-preview-700--actualbudget.netlify.app/ and let me know if things are working for you?
@Kidglove57 commented on GitHub (Feb 27, 2023):
Thank you @j-f1. Yes, they are. Although in fairness they were working in Netlify previously. Just not in "real life".