github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-15 14:43:36 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[Bug]: App Crash When Editing Note Filter to "One of" / "Not One of" #2694

New Issue
Closed
opened 2026-02-28 20:24:41 -06:00 by GiteaMirror · 9 comments
GiteaMirror commented 2026-02-28 20:24:41 -06:00
Owner
Copy Link

Originally created by @Kurokha on GitHub (Dec 7, 2025).

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

When editing an existing filter on the Notes field in any account overview, changing the filter type to "one of" or "not one of" causes the application to immediately crash with a Fatal Error. Client and Server version is v25.12.0

Browser Console Output:

TypeError: l.map is not a function
Lot Autocomplete.tsx:696
React 16
E usePress.mjs:134
Si useEffectEvent.mjs:30
onClick usePress.mjs:241
React 25
E usePress.mjs:134
Si useEffectEvent.mjs:30
onClick usePress.mjs:241
React 11
index.tsx:89
react-dom-client.production.js:5892:11

Stack Trace:

Lot@https://actual.domain/static/js/index.CO-yN_1L.js:198:535221 J_@https://actual.domain/static/js/index.CO-yN_1L.js:9:49009 bR@https://actual.domain/static/js/index.CO-yN_1L.js:9:71991 ZG@https://actual.domain/static/js/index.CO-yN_1L.js:9:82524 Aq@https://actual.domain/static/js/index.CO-yN_1L.js:9:118656 a_e@https://actual.domain/static/js/index.CO-yN_1L.js:9:117682 zR@https://actual.domain/static/js/index.CO-yN_1L.js:9:117506 Sq@https://actual.domain/static/js/index.CO-yN_1L.js:9:114248 Wq@https://actual.domain/static/js/index.CO-yN_1L.js:9:126391 A2@https://actual.domain/static/js/index.CO-yN_1L.js:9:124922 Bq@https://actual.domain/static/js/index.CO-yN_1L.js:9:125204 dNe/h_e/<@https://actual.domain/static/js/index.CO-yN_1L.js:9:126452

How can we reproduce the issue?

  1. Open any account overview.
  2. Create a filter on Notes, using any filter type except “one of” or “not one of”.
  3. Apply the filter — it works as expected.
  4. Edit the same filter and change the filter type to “one of” or “not one of”.
  5. The app instantly crashes with a Fatal Error.

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Windows 11

Originally created by @Kurokha on GitHub (Dec 7, 2025). ### Verified issue does not already exist? - [x] I have searched and found no existing issue ### What happened? When editing an existing filter on the Notes field in any account overview, changing the filter type to "one of" or "not one of" causes the application to immediately crash with a Fatal Error. Client and Server version is v25.12.0 Browser Console Output: > TypeError: l.map is not a function Lot Autocomplete.tsx:696 React 16 E usePress.mjs:134 Si useEffectEvent.mjs:30 onClick usePress.mjs:241 React 25 E usePress.mjs:134 Si useEffectEvent.mjs:30 onClick usePress.mjs:241 React 11 <anonymous> index.tsx:89 react-dom-client.production.js:5892:11 Stack Trace: > Lot@https://actual.domain/static/js/index.CO-yN_1L.js:198:535221 J_@https://actual.domain/static/js/index.CO-yN_1L.js:9:49009 bR@https://actual.domain/static/js/index.CO-yN_1L.js:9:71991 ZG@https://actual.domain/static/js/index.CO-yN_1L.js:9:82524 Aq@https://actual.domain/static/js/index.CO-yN_1L.js:9:118656 a_e@https://actual.domain/static/js/index.CO-yN_1L.js:9:117682 zR@https://actual.domain/static/js/index.CO-yN_1L.js:9:117506 Sq@https://actual.domain/static/js/index.CO-yN_1L.js:9:114248 Wq@https://actual.domain/static/js/index.CO-yN_1L.js:9:126391 A2@https://actual.domain/static/js/index.CO-yN_1L.js:9:124922 Bq@https://actual.domain/static/js/index.CO-yN_1L.js:9:125204 dNe/h_e/<@https://actual.domain/static/js/index.CO-yN_1L.js:9:126452 ### How can we reproduce the issue? 1. Open any account overview. 2. Create a filter on Notes, using any filter type except “one of” or “not one of”. 3. Apply the filter — it works as expected. 4. Edit the same filter and change the filter type to “one of” or “not one of”. 5. The app instantly crashes with a Fatal Error. ### Where are you hosting Actual? Docker ### What browsers are you seeing the problem on? Firefox ### Operating System Windows 11
GiteaMirror added the transactionsgood first issuebug labels 2026-02-28 20:24:41 -06:00
GiteaMirror commented 2026-02-28 20:24:42 -06:00
Author
Owner
Copy Link

@KatKeilty commented on GitHub (Dec 8, 2025):

Same Issue running on same OS, Browser & Docker, except also in widgets.

Attempting to use one of or any of causes a fatal error when editing widgets, but works occasionally (so far once)

Image
@KatKeilty commented on GitHub (Dec 8, 2025): Same Issue running on same OS, Browser & Docker, except also in widgets. Attempting to use one of or any of causes a fatal error when editing widgets, but works occasionally (so far once) <img width="583" height="373" alt="Image" src="https://github.com/user-attachments/assets/ec99c9d6-f956-45c4-ba43-40de41b18f63" />
GiteaMirror commented 2026-02-28 20:24:43 -06:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Dec 8, 2025):

breaks on Chrome based too

@youngcw commented on GitHub (Dec 8, 2025): breaks on Chrome based too
GiteaMirror commented 2026-02-28 20:24:43 -06:00
Author
Owner
Copy Link

@ttlgeek commented on GitHub (Dec 11, 2025):

Hello, I'd like to pick this up.

After browsing the code a bit it seems that the 'one of' / 'not one of' Op filters expect an array value but gets a string passed in instead.

I can see 2 ways to approach this:

  1. Disable the 'one of' / 'not one of' filters for the Notes filter
  2. Properly allow those 2 filters by querying the available notes from the transactions table and offer them as options (as implemented for the Payee filter for example).

@MatissJanis what do you think ?

@ttlgeek commented on GitHub (Dec 11, 2025): Hello, I'd like to pick this up. After browsing the code a bit it seems that the 'one of' / 'not one of' Op filters expect an array value but gets a string passed in instead. I can see 2 ways to approach this: 1. Disable the 'one of' / 'not one of' filters for the Notes filter 2. Properly allow those 2 filters by querying the available notes from the transactions table and offer them as options (as implemented for the Payee filter for example). @MatissJanis what do you think ?
GiteaMirror commented 2026-02-28 20:24:43 -06:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Dec 12, 2025):

IMO option (1) is better for notes since it is (and should be) a free-text field.

@MatissJanis commented on GitHub (Dec 12, 2025): IMO option (1) is better for notes since it is (and should be) a free-text field.
GiteaMirror commented 2026-02-28 20:24:44 -06:00
Author
Owner
Copy Link

@ttlgeek commented on GitHub (Dec 12, 2025):

Ok, i'll work on it. You can assign it to me

@ttlgeek commented on GitHub (Dec 12, 2025): Ok, i'll work on it. You can assign it to me
GiteaMirror commented 2026-02-28 20:24:44 -06:00
Author
Owner
Copy Link

@tomasgriffin commented on GitHub (Dec 19, 2025):

I'm facing a similar bug, should I raise a separate issue or is it the same thing? Steps to reproduce:

  1. Go to Transactions list
  2. Add new Filter: Category is any category
  3. Apply
  4. Click filter pill to edit it
  5. Click One of or Not one of
  6. Fatal error

Edit: this issue is subtly different so I raised it separately: https://github.com/actualbudget/actual/issues/6446 although would it make sense to fix it in the same PR?

@tomasgriffin commented on GitHub (Dec 19, 2025): I'm facing a similar bug, should I raise a separate issue or is it the same thing? Steps to reproduce: 1. Go to Transactions list 2. Add new Filter: Category `is` any category 3. Apply 4. Click filter pill to edit it 5. Click `One of` or `Not one of` 6. Fatal error Edit: this issue is subtly different so I raised it separately: https://github.com/actualbudget/actual/issues/6446 although would it make sense to fix it in the same PR?
GiteaMirror commented 2026-02-28 20:24:45 -06:00
Author
Owner
Copy Link

@jhutchens commented on GitHub (Dec 19, 2025):

Posted in discord yesterday, looks the same as this bug report.

I've noticed Actual consistently crashes when editing a report filter when moving from is to one of and the is field is set to a value. Haven't tested all the combinations, but guessing other changes can trigger a similar problem. Anyone know if this bug is already being tracked? Or I can create an issue.

TypeError: l.map is not a function at Lot...
Image Image
@jhutchens commented on GitHub (Dec 19, 2025): Posted in discord yesterday, looks the same as this bug report. I've noticed Actual consistently crashes when editing a report filter when moving from `is` to `one of` and the `is` field is set to a value. Haven't tested all the combinations, but guessing other changes can trigger a similar problem. Anyone know if this bug is already being tracked? Or I can create an issue. ``` TypeError: l.map is not a function at Lot... ``` <img width="255" height="197" alt="Image" src="https://github.com/user-attachments/assets/55a2ff40-50aa-447f-be58-55eb39cd8da3" /> <img width="566" height="250" alt="Image" src="https://github.com/user-attachments/assets/59aa83aa-578b-47d1-8b9f-e1930441b671" />
GiteaMirror commented 2026-02-28 20:24:45 -06:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Dec 19, 2025):

I've noticed Actual consistently crashes when editing a report filter when moving from is to one of and the is field is set to a value.

Would you mind opening a separate issue for this? The current issue is very much focused on the "notes" field and I don't think the fix we do there will apply universally.

@MatissJanis commented on GitHub (Dec 19, 2025): > I've noticed Actual consistently crashes when editing a report filter when moving from `is` to `one of` and the `is` field is set to a value. Would you mind opening a separate issue for this? The current issue is very much focused on the "notes" field and I don't think the fix we do there will apply universally.
GiteaMirror commented 2026-02-28 20:24:45 -06:00
Author
Owner
Copy Link

@jhutchens commented on GitHub (Dec 20, 2025):

I've noticed Actual consistently crashes when editing a report filter when moving from is to one of and the is field is set to a value.

Would you mind opening a separate issue for this? The current issue is very much focused on the "notes" field and I don't think the fix we do there will apply universally.

Done! #6452

@jhutchens commented on GitHub (Dec 20, 2025): > > I've noticed Actual consistently crashes when editing a report filter when moving from `is` to `one of` and the `is` field is set to a value. > > Would you mind opening a separate issue for this? The current issue is very much focused on the "notes" field and I don't think the fix we do there will apply universally. Done! #6452
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug good first issue transactions
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#2694
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?