github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #2794] [Bug]: SimpleFIN sync only executes if MX provides org domain #26907

New Issue
Closed
opened 2026-04-18 03:16:20 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-04-18 03:16:20 -05:00
Owner
Copy Link

Originally created by @cjfagerstrom on GitHub (May 24, 2024).
Original GitHub issue: https://github.com/actualbudget/actual/issues/2794

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

Summary

After an initial sync with SimpleFIN, subsequent syncs will only be executed if MX provided an org domain for the bank. This org domain is stored in the banks table in the bank_id column. Either the id column from the banks table, or the account_id column from the accounts table should instead be used to ensure SimpleFIN always syncs when there is a connected external account.

Reproducing

Export a copy of a budget. Open the db.sqlite file and navigate to the banks table. Delete the bank_id value for an entry. Save the database changes & zip the file. Import back to Actual Budget and attempt to sync accounts and they will not sync. MX does no provide the org domain which is used for the bank_id value for all banks.

Alternatively, take a non-syncing db.sqlite file and add the url for the bank (www.somedomain.tld) to the missing bank_id value and a non-syncing account will begin syncing.

Fix

Line 1060 in packages/loot-core/src/server/main.ts should be changed from if (acct.bankId) { to if (acct.account_id) {.

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome, Other

Operating System

Mac OSX

Originally created by @cjfagerstrom on GitHub (May 24, 2024). Original GitHub issue: https://github.com/actualbudget/actual/issues/2794 ### Verified issue does not already exist? - [X] I have searched and found no existing issue - [X] I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file) ### What happened? ### Summary After an initial sync with SimpleFIN, subsequent syncs will only be executed if MX provided an org domain for the bank. This org domain is stored in the `banks` table in the `bank_id` column. Either the `id` column from the `banks` table, or the `account_id` column from the `accounts` table should instead be used to ensure SimpleFIN always syncs when there is a connected external account. ### Reproducing Export a copy of a budget. Open the `db.sqlite` file and navigate to the `banks` table. Delete the `bank_id` value for an entry. Save the database changes & zip the file. Import back to Actual Budget and attempt to sync accounts and they will not sync. MX does no provide the org domain which is used for the `bank_id` value for all banks. Alternatively, take a non-syncing `db.sqlite` file and add the url for the bank (www.somedomain.tld) to the missing `bank_id` value and a non-syncing account will begin syncing. ### Fix Line 1060 in `packages/loot-core/src/server/main.ts` should be changed from `if (acct.bankId) {` to `if (acct.account_id) {`. ### Where are you hosting Actual? Docker ### What browsers are you seeing the problem on? Chrome, Other ### Operating System Mac OSX
GiteaMirror added the bug label 2026-04-18 03:16:20 -05:00
GiteaMirror commented 2026-04-18 03:16:22 -05:00
Author
Owner
Copy Link

@cjfagerstrom commented on GitHub (May 24, 2024):

Comment from SimpleFIN regarding this issue:

Right, it's definitely the case the MX is not providing that domain name. I guess I'm suggesting that I wouldn't rely on the domain name always being there. I would rather rely on the account id embedded in each account.

<!-- gh-comment-id:2130015205 --> @cjfagerstrom commented on GitHub (May 24, 2024): Comment from SimpleFIN regarding this issue: > Right, it's definitely the case the MX is not providing that domain name. I guess I'm suggesting that I wouldn't rely on the domain name always being there. I would rather rely on the account id embedded in each account.
GiteaMirror commented 2026-04-18 03:16:23 -05:00
Author
Owner
Copy Link

@duplaja commented on GitHub (Jun 4, 2024):

Submitted a pull request to address this: https://github.com/actualbudget/actual/pull/2836

<!-- gh-comment-id:2148526108 --> @duplaja commented on GitHub (Jun 4, 2024): Submitted a pull request to address this: https://github.com/actualbudget/actual/pull/2836
GiteaMirror commented 2026-04-18 03:16:24 -05:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Jul 17, 2024):

fixed by #2836

<!-- gh-comment-id:2233510416 --> @youngcw commented on GitHub (Jul 17, 2024): fixed by #2836
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#26907
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?