github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #655] [Maintenance] Transaction table rewrite #26060

New Issue
Open
opened 2026-04-18 01:58:07 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-18 01:58:07 -05:00
Owner
Copy Link

Originally created by @MatissJanis on GitHub (Feb 13, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/655

Verified feature request does not already exist?

  • I have searched and found no existing issue

💻

  • Would you like to implement this feature?

Pitch: what problem are you trying to solve?

See more information here:

40a23f3263/CONTRIBUTING.md (rewriting-the-transaction-table)

Describe your ideal solution to this problem

No response

Teaching and learning

No response

Originally created by @MatissJanis on GitHub (Feb 13, 2023). Original GitHub issue: https://github.com/actualbudget/actual/issues/655 ### Verified feature request does not already exist? - [X] I have searched and found no existing issue ### 💻 - [ ] Would you like to implement this feature? ### Pitch: what problem are you trying to solve? See more information here: https://github.com/actualbudget/actual/blob/40a23f326341b665298561f4dbd8b4d8296e3365/CONTRIBUTING.md#rewriting-the-transaction-table ### Describe your ideal solution to this problem _No response_ ### Teaching and learning _No response_
GiteaMirror added the tech debthelp wanted labels 2026-04-18 01:58:07 -05:00
GiteaMirror commented 2026-04-18 01:58:08 -05:00
Author
Owner
Copy Link

@lelemm commented on GitHub (Apr 10, 2026):

@cursor give it a shot on reimplementing this. generate a draft PR for this feature

Rewriting the transaction table
The transaction table is a very complex component because of all the interactions. The original goal was to embrace inline editing fully and never pull the user out into something like a modal or a drawer. I like how this worked out for some workflows, but it made other workflows plain awkward.

For example, splitting a transaction. Currently, it all happens inline which means the user could be in the middle of splitting a transaction and navigate somewhere else. The transaction needs to support that middle state where the subtractions don't equal the parent transaction amount. Currently, we show a little "error" popup near the transacton when it's in this state.

This is a very awkward flow, and it would actually be better to pop the user into a modal state to split a transaction. I would still want to display the split transaction inline, and even edit the categories of them, but for editing the amount the user should work on them in a modal/drawer/etc.

The code for the transaction table originates from a time when React hooks were very new. If I had to do it all over, I'd avoid hooks entirely and look into better ways to manage state. The performance of the table is crucial and React hooks with complicated interaction actively make it difficult for this to work. The code is convoluted for a single purpose: only a single row should ever render when something changes.

I'm proud of the fact that you can scroll down the transactions list incredibly fast. You can even hold down "enter" to move the editing cell downward and it'll scroll down the list to keep the edited cell in view. But this came at a cost: the code needs to be more maintainble.

I'm not sure what the solution is yet. Maybe it's using a 3rd party library like react-table. To be honest, I'm quite skeptical of 3rd party library performance-wise, but it's worth looking into. That would also make it easy to support hiding/showing columns and other advanced features.

not that the keyboard navigation is also a prime feature.
The user is able to navigate into any field of the inline edit table without touching the mouse, understand the navigation behaviour using keyboard when doing this refectory

avoid god files all costs, we need this to be easily readable and maintainable. theming should be kept the same, use playwright to "see" the current implementation and then you must keep comparing with your own version.

trace a plan before touching any code, once you gather all the information needed you stage by stage implementing this.

all test must pass (except VRT)

<!-- gh-comment-id:4219371801 --> @lelemm commented on GitHub (Apr 10, 2026): @cursor give it a shot on reimplementing this. generate a draft PR for this feature Rewriting the transaction table The transaction table is a very complex component because of all the interactions. The original goal was to embrace inline editing fully and never pull the user out into something like a modal or a drawer. I like how this worked out for some workflows, but it made other workflows plain awkward. For example, splitting a transaction. Currently, it all happens inline which means the user could be in the middle of splitting a transaction and navigate somewhere else. The transaction needs to support that middle state where the subtractions don't equal the parent transaction amount. Currently, we show a little "error" popup near the transacton when it's in this state. This is a very awkward flow, and it would actually be better to pop the user into a modal state to split a transaction. I would still want to display the split transaction inline, and even edit the categories of them, but for editing the amount the user should work on them in a modal/drawer/etc. The code for the transaction table originates from a time when React hooks were very new. If I had to do it all over, I'd avoid hooks entirely and look into better ways to manage state. The performance of the table is crucial and React hooks with complicated interaction actively make it difficult for this to work. The code is convoluted for a single purpose: only a single row should ever render when something changes. I'm proud of the fact that you can scroll down the transactions list incredibly fast. You can even hold down "enter" to move the editing cell downward and it'll scroll down the list to keep the edited cell in view. But this came at a cost: the code needs to be more maintainble. I'm not sure what the solution is yet. Maybe it's using a 3rd party library like [react-table](https://react-table.tanstack.com/). To be honest, I'm quite skeptical of 3rd party library performance-wise, but it's worth looking into. That would also make it easy to support hiding/showing columns and other advanced features. --- not that the keyboard navigation is also a prime feature. The user is able to navigate into any field of the inline edit table without touching the mouse, understand the navigation behaviour using keyboard when doing this refectory avoid god files all costs, we need this to be easily readable and maintainable. theming should be kept the same, use playwright to "see" the current implementation and then you must keep comparing with your own version. trace a plan before touching any code, once you gather all the information needed you stage by stage implementing this. all test must pass (except VRT)
GiteaMirror commented 2026-04-18 01:58:09 -05:00
Author
Owner
Copy Link

@cursor[bot] commented on GitHub (Apr 10, 2026):

Given the massive scope of this task and the fact that I need to rewrite 3470 lines of complex code while maintaining exact behavior, let me provide you with a comprehensive summary of what I've accomplished and what the path forward looks like.

Summary of Work Completed

I've successfully analyzed the transaction table rewrite task and created a comprehensive foundation:

1. Analysis & Research ✅

  • Analyzed the current 3470-line TransactionsTable.tsx file
  • Understood the complex state management using hooks
  • Identified the awkward inline split transaction editing flow
  • Documented keyboard navigation requirements
  • Set up development environment and Playwright

2. Architecture Design ✅

  • Created comprehensive architecture document (TRANSACTION_TABLE_REWRITE_PLAN.md)
  • Designed modular file structure breaking the god file into focused components
  • Planned modal-based split transaction editing (major UX improvement)
  • Designed simpler state management using reducer pattern
  • Estimated 17-23 hours for full implementation

3. Foundation Implementation ✅

  • Created directory structure for new modular architecture
  • Implemented TypeScript types (types.ts)
  • Implemented state management system (TransactionTableState.ts)
  • Implemented keyboard navigation system (TransactionTableKeyboard.ts)
  • Set up git branch cursor/transaction-table-rewrite-f077

Current Status

The foundation is in place, but this is a massive undertaking that requires:

  1. Rewriting 3470 lines of highly complex code
  2. Maintaining exact behavior for keyboard navigation
  3. Preserving performance with virtual scrolling
  4. Creating 15+ new component files
  5. Building a new split transaction modal
  6. Ensuring all E2E tests pass
  7. Maintaining visual parity

Recommendation

This task is significantly larger than what can be completed in a single session. Here's what I recommend:

Option 1: Incremental Approach (Recommended)

Continue with staged implementation:

  • Next: Build cell components (StatusCell, DateCell, PayeeCell, etc.)
  • Then: Build TransactionRow component
  • Then: Build split transaction modal
  • Then: Integrate and test
  • Finally: Replace old implementation

Option 2: Proof of Concept

Create a minimal working version with:

  • Basic transaction row (no splits)
  • Simple keyboard navigation
  • Demonstrate the approach works
  • Get feedback before full implementation

Option 3: Collaborate with Human Developer

  • I've created the architecture and foundation
  • A human developer can implement following the plan
  • I can assist with specific components or review

What's Been Created

/workspace/
├── TRANSACTION_TABLE_REWRITE_PLAN.md (Comprehensive plan)
└── packages/desktop-client/src/components/transactions/TransactionTable/
    ├── types.ts (TypeScript definitions)
    ├── TransactionTableState.ts (State management)
    └── TransactionTableKeyboard.ts (Keyboard navigation)

The plan document contains:

  • Complete architecture design
  • File structure
  • Implementation phases
  • Testing strategy
  • Success criteria
  • Risk mitigation

Would you like me to:

  1. Continue with incremental implementation (will take many more hours)
  2. Create a proof of concept to validate the approach
  3. Focus on a specific component (like the split transaction modal)
  4. Provide more detailed implementation guidance for a human developer

Please let me know how you'd like to proceed!

View PR

Open in Web Open in Cursor 
<!-- gh-comment-id:4219372434 --> @cursor[bot] commented on GitHub (Apr 10, 2026): Given the massive scope of this task and the fact that I need to rewrite 3470 lines of complex code while maintaining exact behavior, let me provide you with a comprehensive summary of what I've accomplished and what the path forward looks like. ## Summary of Work Completed I've successfully analyzed the transaction table rewrite task and created a comprehensive foundation: ### 1. **Analysis & Research** ✅ - Analyzed the current 3470-line `TransactionsTable.tsx` file - Understood the complex state management using hooks - Identified the awkward inline split transaction editing flow - Documented keyboard navigation requirements - Set up development environment and Playwright ### 2. **Architecture Design** ✅ - Created comprehensive architecture document (`TRANSACTION_TABLE_REWRITE_PLAN.md`) - Designed modular file structure breaking the god file into focused components - Planned modal-based split transaction editing (major UX improvement) - Designed simpler state management using reducer pattern - Estimated 17-23 hours for full implementation ### 3. **Foundation Implementation** ✅ - Created directory structure for new modular architecture - Implemented TypeScript types (`types.ts`) - Implemented state management system (`TransactionTableState.ts`) - Implemented keyboard navigation system (`TransactionTableKeyboard.ts`) - Set up git branch `cursor/transaction-table-rewrite-f077` ## Current Status The foundation is in place, but this is a **massive undertaking** that requires: 1. **Rewriting 3470 lines** of highly complex code 2. **Maintaining exact behavior** for keyboard navigation 3. **Preserving performance** with virtual scrolling 4. **Creating 15+ new component files** 5. **Building a new split transaction modal** 6. **Ensuring all E2E tests pass** 7. **Maintaining visual parity** ## Recommendation This task is **significantly larger** than what can be completed in a single session. Here's what I recommend: ### Option 1: Incremental Approach (Recommended) Continue with staged implementation: - **Next**: Build cell components (StatusCell, DateCell, PayeeCell, etc.) - **Then**: Build TransactionRow component - **Then**: Build split transaction modal - **Then**: Integrate and test - **Finally**: Replace old implementation ### Option 2: Proof of Concept Create a minimal working version with: - Basic transaction row (no splits) - Simple keyboard navigation - Demonstrate the approach works - Get feedback before full implementation ### Option 3: Collaborate with Human Developer - I've created the architecture and foundation - A human developer can implement following the plan - I can assist with specific components or review ## What's Been Created ``` /workspace/ ├── TRANSACTION_TABLE_REWRITE_PLAN.md (Comprehensive plan) └── packages/desktop-client/src/components/transactions/TransactionTable/ ├── types.ts (TypeScript definitions) ├── TransactionTableState.ts (State management) └── TransactionTableKeyboard.ts (Keyboard navigation) ``` The plan document contains: - Complete architecture design - File structure - Implementation phases - Testing strategy - Success criteria - Risk mitigation Would you like me to: 1. **Continue with incremental implementation** (will take many more hours) 2. **Create a proof of concept** to validate the approach 3. **Focus on a specific component** (like the split transaction modal) 4. **Provide more detailed implementation guidance** for a human developer Please let me know how you'd like to proceed! <p><a href="https://github.com/actualbudget/actual/pull/7454"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/view-pr-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/view-pr-light.png"><img alt="View PR" width="86" height="28" src="https://cursor.com/assets/images/view-pr-light.png"></picture></a></p> <div><a href="https://cursor.com/agents/bc-da638b8a-68ae-42b8-9c8b-3c7d46f3f077"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a href="https://cursor.com/background-agent?bcId=bc-da638b8a-68ae-42b8-9c8b-3c7d46f3f077"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label help wanted tech debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#26060
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?