github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7274] [MERGED] Fix Scheduled Transactions Not Being Included in Selected Balance #25665

New Issue
Closed
opened 2026-04-16 18:46:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 18:46:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7274
Author: @iaewing
Created: 3/24/2026
Status: ✅ Merged
Merged: 3/24/2026
Merged by: @matt-fidd

Base: master ← Head: fix/scheduled-transactions-and-selected-balance

📝 Commits (7)

  • daabcdb create failing tests to identify schedule bug
  • 1846e84 Export SelectedBalance to allow for testing
  • 5f54597 fix handling of scheduleIds
  • aa16ec0 create release notes
  • feec744 add tests for normal transactions to ensure no regressions introduced
  • 2922be4 Merge branch 'master' into fix/scheduled-transactions-and-selected-balance
  • a437db6 capitalize first letter of release notes

📊 Changes

3 files changed (+140 additions, -10 deletions)

View changed files

➕ packages/desktop-client/src/components/accounts/Balance.test.tsx (+121 -0)
📝 packages/desktop-client/src/components/accounts/Balance.tsx (+13 -10)
➕ upcoming-release-notes/7274.md (+6 -0)

📄 Description

Description

Fixes an issue with the Selected Balance feature that meant that scheduled transactions were not included. This allows users to more effectively "forecast" the balance of an account.

For example, if an account has a balance of $100 with 3 scheduled transactions, selecting those will now give you an accurate calculation of whether the account balance needs to be topped up or is sufficient to cover impending transactions.

Related issue(s)

No related issues I'm aware of.

Testing

Created Balance.test.tsx to test and expose the bug. Manually verified behaviour locally before and after implementation.

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 27 12.09 MB → 12.09 MB (-8 B) -0.00%
loot-core 1 4.83 MB 0%
api 4 4.06 MB 0%
cli 1 7.88 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
27 12.09 MB → 12.09 MB (-8 B) -0.00%
Changeset
File Δ Size
src/components/accounts/Balance.tsx 📉 -8 B (-0.08%) 9.89 kB → 9.88 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 3.23 MB → 3.23 MB (-8 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/BackgroundImage.js 119.98 kB 0%
static/js/FormulaEditor.js 846.44 kB 0%
static/js/ReportRouter.js 1.02 MB 0%
static/js/TransactionList.js 81.29 kB 0%
static/js/ca.js 185.57 kB 0%
static/js/da.js 104.66 kB 0%
static/js/de.js 177.58 kB 0%
static/js/en-GB.js 7.16 kB 0%
static/js/en.js 170.76 kB 0%
static/js/es.js 172.13 kB 0%
static/js/fr.js 177.61 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 168.97 kB 0%
static/js/narrow.js 354.27 kB 0%
static/js/nb-NO.js 154.72 kB 0%
static/js/nl.js 111.58 kB 0%
static/js/pl.js 88.34 kB 0%
static/js/pt-BR.js 180.5 kB 0%
static/js/resize-observer.js 18.03 kB 0%
static/js/sv.js 80.58 kB 0%
static/js/th.js 179.94 kB 0%
static/js/theme.js 30.68 kB 0%
static/js/uk.js 213.14 kB 0%
static/js/useTransactionBatchActions.js 4.29 MB 0%
static/js/wide.js 418 B 0%
static/js/workbox-window.prod.es5.js 7.28 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.83 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.Bq2rqD2u.js 4.83 MB 0%

api

Total

Files count Total bundle size % Changed
4 4.06 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.84 MB 0%
from-Bl-Hslp4.js 167.73 kB 0%
multipart-parser-BnDysoMr.js 8.1 kB 0%
src-iMkUmuwR.js 43.64 kB 0%

cli

Total

Files count Total bundle size % Changed
1 7.88 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.88 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7274 **Author:** [@iaewing](https://github.com/iaewing) **Created:** 3/24/2026 **Status:** ✅ Merged **Merged:** 3/24/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `fix/scheduled-transactions-and-selected-balance` --- ### 📝 Commits (7) - [`daabcdb`](https://github.com/actualbudget/actual/commit/daabcdb92c136c57673162dfcade5cb0540801db) create failing tests to identify schedule bug - [`1846e84`](https://github.com/actualbudget/actual/commit/1846e84dcc1b0bc84107d724d2a5322dc4bab276) Export SelectedBalance to allow for testing - [`5f54597`](https://github.com/actualbudget/actual/commit/5f5459716cfda549447473c840229824c4e585b7) fix handling of scheduleIds - [`aa16ec0`](https://github.com/actualbudget/actual/commit/aa16ec0cf013ff09caf6791ce6062aec4846cf1c) create release notes - [`feec744`](https://github.com/actualbudget/actual/commit/feec7440bcfa0546f6a51dbf36177f6f0c4eb1ca) add tests for normal transactions to ensure no regressions introduced - [`2922be4`](https://github.com/actualbudget/actual/commit/2922be439244bcbd6e0fae20ad0f91bb7483ac34) Merge branch 'master' into fix/scheduled-transactions-and-selected-balance - [`a437db6`](https://github.com/actualbudget/actual/commit/a437db696f1d030295511f5f223a8324b0a2aaea) capitalize first letter of release notes ### 📊 Changes **3 files changed** (+140 additions, -10 deletions) <details> <summary>View changed files</summary> ➕ `packages/desktop-client/src/components/accounts/Balance.test.tsx` (+121 -0) 📝 `packages/desktop-client/src/components/accounts/Balance.tsx` (+13 -10) ➕ `upcoming-release-notes/7274.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ## Description Fixes an issue with the `Selected Balance` feature that meant that scheduled transactions were not included. This allows users to more effectively "forecast" the balance of an account. For example, if an account has a balance of $100 with 3 scheduled transactions, selecting those will now give you an accurate calculation of whether the account balance needs to be topped up or is sufficient to cover impending transactions. ## Related issue(s) No related issues I'm aware of. ## Testing Created `Balance.test.tsx` to test and expose the bug. Manually verified behaviour locally before and after implementation. ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 12.09 MB → 12.09 MB (-8 B) | -0.00% loot-core | 1 | 4.83 MB | 0% api | 4 | 4.06 MB | 0% cli | 1 | 7.88 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 12.09 MB → 12.09 MB (-8 B) | -0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/accounts/Balance.tsx` | 📉 -8 B (-0.08%) | 9.89 kB → 9.88 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 3.23 MB → 3.23 MB (-8 B) | -0.00% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/BackgroundImage.js | 119.98 kB | 0% static/js/FormulaEditor.js | 846.44 kB | 0% static/js/ReportRouter.js | 1.02 MB | 0% static/js/TransactionList.js | 81.29 kB | 0% static/js/ca.js | 185.57 kB | 0% static/js/da.js | 104.66 kB | 0% static/js/de.js | 177.58 kB | 0% static/js/en-GB.js | 7.16 kB | 0% static/js/en.js | 170.76 kB | 0% static/js/es.js | 172.13 kB | 0% static/js/fr.js | 177.61 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 168.97 kB | 0% static/js/narrow.js | 354.27 kB | 0% static/js/nb-NO.js | 154.72 kB | 0% static/js/nl.js | 111.58 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 180.5 kB | 0% static/js/resize-observer.js | 18.03 kB | 0% static/js/sv.js | 80.58 kB | 0% static/js/th.js | 179.94 kB | 0% static/js/theme.js | 30.68 kB | 0% static/js/uk.js | 213.14 kB | 0% static/js/useTransactionBatchActions.js | 4.29 MB | 0% static/js/wide.js | 418 B | 0% static/js/workbox-window.prod.es5.js | 7.28 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.83 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.Bq2rqD2u.js | 4.83 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 4 | 4.06 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.84 MB | 0% from-Bl-Hslp4.js | 167.73 kB | 0% multipart-parser-BnDysoMr.js | 8.1 kB | 0% src-iMkUmuwR.js | 43.64 kB | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.88 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.88 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 18:46:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#25665
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?