github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7242] [MERGED] Fix updateTransaction corrupting split parents with partial updates #25642

New Issue
Closed
opened 2026-04-16 18:45:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 18:45:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7242
Author: @lwarrenthompson
Created: 3/20/2026
Status: ✅ Merged
Merged: 4/5/2026
Merged by: @matt-fidd

Base: master ← Head: fix/split-parent-update-corruption

📝 Commits (3)

  • 2e99e99 [AI] Fix updateTransaction corrupting split parents with partial updates
  • 9cc5851 [AI] Add release notes for PR #7242
  • 6cf01cb Address review feedback: remove verbose comment and simplify release note

📊 Changes

3 files changed (+42 additions, -1 deletions)

View changed files

📝 packages/loot-core/src/shared/transactions.test.ts (+34 -0)
📝 packages/loot-core/src/shared/transactions.ts (+2 -1)
➕ upcoming-release-notes/7242.md (+6 -0)

📄 Description

Summary

When api.updateTransaction(id, { notes: '...' }) is called on a split parent transaction, the updateTransaction() helper in shared/transactions.ts replaces the parent with the sparse update object instead of merging it with the existing transaction data. This causes:

  1. recalculateSplit() sees amount as undefined (→ 0), which doesn't match the children's total, and sets a SplitTransactionError on the parent
  2. makeChild() inherits undefined values for account, date, and cleared from the sparse parent object
  3. The UI then shows "Amount left" warnings on every affected split transaction

Root cause: Line 265 of transactions.ts uses transaction (the sparse partial update) directly instead of merging with trans (the existing full transaction):

// Before (bug):
const parent = trans.id === transaction.id ? transaction : trans;
// After (fix):
const parent = trans.id === transaction.id ? { ...trans, ...transaction } : trans;

Fix: Merge the incoming partial fields with the existing transaction data so all properties (amount, account, date, etc.) are preserved.

Test added: A new test case performs a notes-only partial update on a split parent and asserts no SplitTransactionError is set and the amount stays intact.

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 27 12.09 MB → 12.09 MB (+28 B) +0.00%
loot-core 1 4.83 MB → 4.83 MB (+31 B) +0.00%
api 4 4.06 MB → 4.06 MB (+28 B) +0.00%
cli 1 7.88 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
27 12.09 MB → 12.09 MB (+28 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts 📈 +28 B (+0.34%) 8.15 kB → 8.17 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/useTransactionBatchActions.js 4.29 MB → 4.29 MB (+28 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 3.23 MB 0%
static/js/BackgroundImage.js 119.98 kB 0%
static/js/FormulaEditor.js 846.44 kB 0%
static/js/ReportRouter.js 1.02 MB 0%
static/js/TransactionList.js 81.29 kB 0%
static/js/ca.js 182.91 kB 0%
static/js/da.js 104.66 kB 0%
static/js/de.js 174.79 kB 0%
static/js/en-GB.js 7.16 kB 0%
static/js/en.js 170.76 kB 0%
static/js/es.js 182.09 kB 0%
static/js/fr.js 177.47 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 166.25 kB 0%
static/js/narrow.js 354.27 kB 0%
static/js/nb-NO.js 152.2 kB 0%
static/js/nl.js 108.93 kB 0%
static/js/pl.js 88.34 kB 0%
static/js/pt-BR.js 177.84 kB 0%
static/js/resize-observer.js 18.03 kB 0%
static/js/sv.js 80.58 kB 0%
static/js/th.js 179.94 kB 0%
static/js/theme.js 30.68 kB 0%
static/js/uk.js 213.14 kB 0%
static/js/wide.js 418 B 0%
static/js/workbox-window.prod.es5.js 7.28 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.83 MB → 4.83 MB (+31 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts 📈 +31 B (+0.50%) 6.01 kB → 6.04 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.C5hh87H0.js 0 B → 4.83 MB (+4.83 MB) -

Removed

Asset File Size % Changed
kcab.worker.B6yxrEsJ.js 4.83 MB → 0 B (-4.83 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count Total bundle size % Changed
4 4.06 MB → 4.06 MB (+28 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts 📈 +28 B (+0.47%) 5.83 kB → 5.85 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
index.js 3.84 MB → 3.84 MB (+28 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
from-Bl-Hslp4.js 167.73 kB 0%
multipart-parser-BnDysoMr.js 8.1 kB 0%
src-iMkUmuwR.js 43.64 kB 0%

cli

Total

Files count Total bundle size % Changed
1 7.88 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.88 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7242 **Author:** [@lwarrenthompson](https://github.com/lwarrenthompson) **Created:** 3/20/2026 **Status:** ✅ Merged **Merged:** 4/5/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `fix/split-parent-update-corruption` --- ### 📝 Commits (3) - [`2e99e99`](https://github.com/actualbudget/actual/commit/2e99e99e6e32eabe4cd4f9f342d4b5c106b577c2) [AI] Fix updateTransaction corrupting split parents with partial updates - [`9cc5851`](https://github.com/actualbudget/actual/commit/9cc585198f364d70c91017782b9699dd8b7ecbb1) [AI] Add release notes for PR #7242 - [`6cf01cb`](https://github.com/actualbudget/actual/commit/6cf01cbb566f33c10a6d27a1b66eea9d926958d1) Address review feedback: remove verbose comment and simplify release note ### 📊 Changes **3 files changed** (+42 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/shared/transactions.test.ts` (+34 -0) 📝 `packages/loot-core/src/shared/transactions.ts` (+2 -1) ➕ `upcoming-release-notes/7242.md` (+6 -0) </details> ### 📄 Description ## Summary When `api.updateTransaction(id, { notes: '...' })` is called on a split parent transaction, the `updateTransaction()` helper in `shared/transactions.ts` replaces the parent with the sparse update object instead of merging it with the existing transaction data. This causes: 1. `recalculateSplit()` sees `amount` as `undefined` (→ 0), which doesn't match the children's total, and sets a `SplitTransactionError` on the parent 2. `makeChild()` inherits `undefined` values for `account`, `date`, and `cleared` from the sparse parent object 3. The UI then shows "Amount left" warnings on every affected split transaction **Root cause:** Line 265 of `transactions.ts` uses `transaction` (the sparse partial update) directly instead of merging with `trans` (the existing full transaction): ```js // Before (bug): const parent = trans.id === transaction.id ? transaction : trans; // After (fix): const parent = trans.id === transaction.id ? { ...trans, ...transaction } : trans; ``` **Fix:** Merge the incoming partial fields with the existing transaction data so all properties (`amount`, `account`, `date`, etc.) are preserved. **Test added:** A new test case performs a notes-only partial update on a split parent and asserts no `SplitTransactionError` is set and the amount stays intact. <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 12.09 MB → 12.09 MB (+28 B) | +0.00% loot-core | 1 | 4.83 MB → 4.83 MB (+31 B) | +0.00% api | 4 | 4.06 MB → 4.06 MB (+28 B) | +0.00% cli | 1 | 7.88 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 12.09 MB → 12.09 MB (+28 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts` | 📈 +28 B (+0.34%) | 8.15 kB → 8.17 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/useTransactionBatchActions.js | 4.29 MB → 4.29 MB (+28 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 3.23 MB | 0% static/js/BackgroundImage.js | 119.98 kB | 0% static/js/FormulaEditor.js | 846.44 kB | 0% static/js/ReportRouter.js | 1.02 MB | 0% static/js/TransactionList.js | 81.29 kB | 0% static/js/ca.js | 182.91 kB | 0% static/js/da.js | 104.66 kB | 0% static/js/de.js | 174.79 kB | 0% static/js/en-GB.js | 7.16 kB | 0% static/js/en.js | 170.76 kB | 0% static/js/es.js | 182.09 kB | 0% static/js/fr.js | 177.47 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 166.25 kB | 0% static/js/narrow.js | 354.27 kB | 0% static/js/nb-NO.js | 152.2 kB | 0% static/js/nl.js | 108.93 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 177.84 kB | 0% static/js/resize-observer.js | 18.03 kB | 0% static/js/sv.js | 80.58 kB | 0% static/js/th.js | 179.94 kB | 0% static/js/theme.js | 30.68 kB | 0% static/js/uk.js | 213.14 kB | 0% static/js/wide.js | 418 B | 0% static/js/workbox-window.prod.es5.js | 7.28 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.83 MB → 4.83 MB (+31 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts` | 📈 +31 B (+0.50%) | 6.01 kB → 6.04 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.C5hh87H0.js | 0 B → 4.83 MB (+4.83 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.B6yxrEsJ.js | 4.83 MB → 0 B (-4.83 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 4 | 4.06 MB → 4.06 MB (+28 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts` | 📈 +28 B (+0.47%) | 5.83 kB → 5.85 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.84 MB → 3.84 MB (+28 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- from-Bl-Hslp4.js | 167.73 kB | 0% multipart-parser-BnDysoMr.js | 8.1 kB | 0% src-iMkUmuwR.js | 43.64 kB | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.88 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.88 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 18:45:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#25642
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?