github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[Bug]: editing closed account names #255

New Issue
Closed
opened 2026-02-28 18:54:25 -06:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-02-28 18:54:25 -06:00
Owner
Copy Link

Originally created by @MatissJanis on GitHub (Feb 3, 2023).

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

When you edit a closed account name - it adds "closed:" prefix to it. Which then gets saved as the real account name.

Screenshot 2023-02-03 at 19 05 48

Reproduction:

  1. close an account
  2. open the closed account
  3. click on the closed account name to edit it
  4. observe "closed: xxxx" appearing in the edit field
  5. change it to "closed: xxxx yyyyy" (add something at the end)
  6. click "enter" to save
  7. notice that the new account name is "closed: closed: xxxx yyyyy"

What error did you receive?

No response

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

Originally created by @MatissJanis on GitHub (Feb 3, 2023). ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### What happened? When you edit a closed account name - it adds "closed:" prefix to it. Which then gets saved as the real account name. <img width="400" alt="Screenshot 2023-02-03 at 19 05 48" src="https://user-images.githubusercontent.com/886567/216686326-9c11b23c-eb95-42c1-8a03-141c1f38978d.png"> Reproduction: 1. close an account 2. open the closed account 3. click on the closed account name to edit it 4. observe "closed: xxxx" appearing in the edit field 5. change it to "closed: xxxx yyyyy" (add something at the end) 6. click "enter" to save 7. notice that the new account name is "closed: closed: xxxx yyyyy" ### What error did you receive? _No response_ ### Where are you hosting Actual? None ### What browsers are you seeing the problem on? _No response_ ### Operating System None
GiteaMirror added the buggood first issuehelp wanted labels 2026-02-28 18:54:25 -06:00
GiteaMirror commented 2026-02-28 18:54:26 -06:00
Author
Owner
Copy Link

@Kidglove57 commented on GitHub (Feb 3, 2023):

I have run into this quite a number of times and I am ashamed to say never reported it.

@Kidglove57 commented on GitHub (Feb 3, 2023): I have run into this quite a number of times and I am ashamed to say never reported it.
GiteaMirror commented 2026-02-28 18:54:26 -06:00
Author
Owner
Copy Link

@n1thun commented on GitHub (Feb 3, 2023):

Hi, can i pick this one up? i think i have the fix for the issue, we can either prevent the string concat for previously closed accounts or disable the edit button for closed account. This is my first contribution for this repo, are there any standard guide lines for PRs?

@n1thun commented on GitHub (Feb 3, 2023): Hi, can i pick this one up? i think i have the fix for the issue, we can either prevent the string concat for previously closed accounts or disable the edit button for closed account. This is my first contribution for this repo, are there any standard guide lines for PRs?
GiteaMirror commented 2026-02-28 18:54:26 -06:00
Author
Owner
Copy Link

@j-f1 commented on GitHub (Feb 3, 2023):

Hi @n1thun, that would be awesome! I think the ideal outcome would be that the title still looks the same (e.g. “Closed: [name]”) when viewing it, but when you go to edit the prefix should be removed. We don’t have any particular guidelines for PRs, aside from making sure that you have a reasonably descriptive PR title.

@j-f1 commented on GitHub (Feb 3, 2023): Hi @n1thun, that would be awesome! I think the ideal outcome would be that the title still looks the same (e.g. “Closed: [name]”) when viewing it, but when you go to edit the prefix should be removed. We don’t have any particular guidelines for PRs, aside from making sure that you have a reasonably descriptive PR title.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug good first issue help wanted
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#255
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?