github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #6503] [MERGED] expand logger to cover more of loot-core #25182

New Issue
Closed
opened 2026-04-16 18:26:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 18:26:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6503
Author: @matt-fidd
Created: 12/28/2025
Status: ✅ Merged
Merged: 12/30/2025
Merged by: @matt-fidd

Base: master ← Head: logger

📝 Commits (4)

📊 Changes

15 files changed (+92 additions, -67 deletions)

View changed files

📝 packages/eslint-plugin-actual/lib/rules/__tests__/prefer-logger-over-console.test.js (+8 -0)
📝 packages/eslint-plugin-actual/lib/rules/prefer-logger-over-console.js (+25 -44)
📝 packages/eslint-plugin-actual/lib/utils/import-helpers.js (+11 -1)
📝 packages/loot-core/src/platform/exceptions/index.ts (+4 -2)
📝 packages/loot-core/src/platform/server/connection/index.electron.ts (+3 -1)
📝 packages/loot-core/src/platform/server/connection/index.ts (+5 -3)
📝 packages/loot-core/src/platform/server/fetch/index.electron.ts (+3 -1)
📝 packages/loot-core/src/platform/server/fs/index.electron.ts (+5 -3)
📝 packages/loot-core/src/platform/server/fs/index.web.ts (+3 -1)
📝 packages/loot-core/src/platform/server/indexeddb/index.ts (+5 -3)
📝 packages/loot-core/src/platform/server/sqlite/index.electron.ts (+5 -3)
📝 packages/loot-core/src/platform/server/sqlite/index.web.ts (+2 -1)
📝 packages/loot-core/src/shared/test-helpers.ts (+5 -3)
📝 packages/loot-core/src/shared/transactions.ts (+2 -1)
➕ upcoming-release-notes/6503.md (+6 -0)

📄 Description

Found after https://github.com/actualbudget/actual/pull/6457 exposed the breadcrumb logs to the API when verbose: false

I did this by expanding the rule and then running it to let the autofixer do the code changes.

Summary by CodeRabbit

  • Refactor

    • Implemented centralized logging system across server and platform modules for improved consistency in diagnostics and error tracking.

  • Chores

    • Updated logging-related linting rules and import helpers to support centralized logging approach.

  • Tests

    • Updated test cases to reflect logging system changes.

✏️ Tip: You can customize this high-level summary in your review settings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6503 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 12/28/2025 **Status:** ✅ Merged **Merged:** 12/30/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `logger` --- ### 📝 Commits (4) - [`cabb91a`](https://github.com/actualbudget/actual/commit/cabb91a0d5cab7c744b8668b388593b78ec0363a) expand lint rule - [`d097d52`](https://github.com/actualbudget/actual/commit/d097d528f4232f3f70335bc8880827adebeafc93) note - [`c49fddf`](https://github.com/actualbudget/actual/commit/c49fddfb11afeb632533457ff78da87dd63e6159) fix tests - [`681fc9b`](https://github.com/actualbudget/actual/commit/681fc9b0dfdf7631e6d60e36c2afc3903958e61e) feedback ### 📊 Changes **15 files changed** (+92 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `packages/eslint-plugin-actual/lib/rules/__tests__/prefer-logger-over-console.test.js` (+8 -0) 📝 `packages/eslint-plugin-actual/lib/rules/prefer-logger-over-console.js` (+25 -44) 📝 `packages/eslint-plugin-actual/lib/utils/import-helpers.js` (+11 -1) 📝 `packages/loot-core/src/platform/exceptions/index.ts` (+4 -2) 📝 `packages/loot-core/src/platform/server/connection/index.electron.ts` (+3 -1) 📝 `packages/loot-core/src/platform/server/connection/index.ts` (+5 -3) 📝 `packages/loot-core/src/platform/server/fetch/index.electron.ts` (+3 -1) 📝 `packages/loot-core/src/platform/server/fs/index.electron.ts` (+5 -3) 📝 `packages/loot-core/src/platform/server/fs/index.web.ts` (+3 -1) 📝 `packages/loot-core/src/platform/server/indexeddb/index.ts` (+5 -3) 📝 `packages/loot-core/src/platform/server/sqlite/index.electron.ts` (+5 -3) 📝 `packages/loot-core/src/platform/server/sqlite/index.web.ts` (+2 -1) 📝 `packages/loot-core/src/shared/test-helpers.ts` (+5 -3) 📝 `packages/loot-core/src/shared/transactions.ts` (+2 -1) ➕ `upcoming-release-notes/6503.md` (+6 -0) </details> ### 📄 Description Found after https://github.com/actualbudget/actual/pull/6457 exposed the breadcrumb logs to the API when `verbose: false` I did this by expanding the rule and then running it to let the autofixer do the code changes. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Implemented centralized logging system across server and platform modules for improved consistency in diagnostics and error tracking. * **Chores** * Updated logging-related linting rules and import helpers to support centralized logging approach. * **Tests** * Updated test cases to reflect logging system changes. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 18:26:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#25182
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?