github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-08 04:49:45 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #6101] [MERGED] Combine bundle stats comments in PR #24934

New Issue
Closed
opened 2026-04-16 18:19:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 18:19:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6101
Author: @MatissJanis
Created: 11/10/2025
Status: ✅ Merged
Merged: 11/13/2025
Merged by: @MatissJanis

Base: master ← Head: 2025-11-10-ayck-EvtqT

📝 Commits (9)

  • f620a70 Combine bundle stats comments in PR
  • 459ad2d Refactor bundle stats comment generation to use a mapping approach for base and head stats, improving argument parsing and validation in the CI action.
  • 96c066f Enhance size comparison workflow by adding steps to checkout the base branch and set up the environment, ensuring accurate build status checks for pull requests.
  • bf96a96 Implement size comparison job in GitHub Actions workflow, replacing the deprecated size-compare.yml. This new job downloads build stats from both the base and head branches, processes the stats files, and generates a combined comment for pull requests, enhancing visibility into bundle size changes.
  • 71b165a Add release notes for bundle size stats update, consolidating workflow and PR comment generation.
  • 4daf02e Refactor GitHub Actions workflows by removing the deprecated size comparison job from build.yml and introducing a new size-compare.yml workflow. This new workflow enhances build status checks and ensures accurate reporting of bundle size changes for pull requests.
  • bacd243 Merge branch 'master' into 2025-11-10-ayck-EvtqT
  • c11f46e chore: update action versions and improve error messages in bundle stats scripts
  • 52582e3 fix: standardize error messages in bundle-stats-comment.mjs

📊 Changes

5 files changed (+924 additions, -28 deletions)

View changed files

📝 .github/workflows/build.yml (+7 -0)
📝 .github/workflows/size-compare.yml (+82 -28)
➕ packages/ci-actions/bin/bundle-stats-comment.mjs (+678 -0)
➕ packages/ci-actions/bin/update-bundle-stats-comment.mjs (+151 -0)
➕ upcoming-release-notes/6101.md (+6 -0)

📄 Description

Add a single PR comment about bundle size changes instead of multiple.

Demo: https://github.com/MatissJanis/actual/pull/11

It is expected for compare-sizes workflow to fail in this PR.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6101 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 11/10/2025 **Status:** ✅ Merged **Merged:** 11/13/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `2025-11-10-ayck-EvtqT` --- ### 📝 Commits (9) - [`f620a70`](https://github.com/actualbudget/actual/commit/f620a70505a56da404c95e2e24d1b2c3dcf7a2d8) Combine bundle stats comments in PR - [`459ad2d`](https://github.com/actualbudget/actual/commit/459ad2d789ea62540349a8991f00c473fa49caa4) Refactor bundle stats comment generation to use a mapping approach for base and head stats, improving argument parsing and validation in the CI action. - [`96c066f`](https://github.com/actualbudget/actual/commit/96c066f7f38f8d0ea3caf8a30b3e38e95c24adfa) Enhance size comparison workflow by adding steps to checkout the base branch and set up the environment, ensuring accurate build status checks for pull requests. - [`bf96a96`](https://github.com/actualbudget/actual/commit/bf96a96a61bcb6a7124aff15cd91a1296c30f1a9) Implement size comparison job in GitHub Actions workflow, replacing the deprecated size-compare.yml. This new job downloads build stats from both the base and head branches, processes the stats files, and generates a combined comment for pull requests, enhancing visibility into bundle size changes. - [`71b165a`](https://github.com/actualbudget/actual/commit/71b165a0a23fbad01246b16a29b6e68b319cfe23) Add release notes for bundle size stats update, consolidating workflow and PR comment generation. - [`4daf02e`](https://github.com/actualbudget/actual/commit/4daf02e535d8d606b2242169e179f917dddb64d4) Refactor GitHub Actions workflows by removing the deprecated size comparison job from build.yml and introducing a new size-compare.yml workflow. This new workflow enhances build status checks and ensures accurate reporting of bundle size changes for pull requests. - [`bacd243`](https://github.com/actualbudget/actual/commit/bacd243ff38fe32cabe8a1d6d64c9ce60e1a9143) Merge branch 'master' into 2025-11-10-ayck-EvtqT - [`c11f46e`](https://github.com/actualbudget/actual/commit/c11f46e57001543a046075ea362f59c84a94fb7e) chore: update action versions and improve error messages in bundle stats scripts - [`52582e3`](https://github.com/actualbudget/actual/commit/52582e39e6566df07c61287885c33a4a88ee2d7b) fix: standardize error messages in bundle-stats-comment.mjs ### 📊 Changes **5 files changed** (+924 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+7 -0) 📝 `.github/workflows/size-compare.yml` (+82 -28) ➕ `packages/ci-actions/bin/bundle-stats-comment.mjs` (+678 -0) ➕ `packages/ci-actions/bin/update-bundle-stats-comment.mjs` (+151 -0) ➕ `upcoming-release-notes/6101.md` (+6 -0) </details> ### 📄 Description Add a single PR comment about bundle size changes instead of multiple. Demo: https://github.com/MatissJanis/actual/pull/11 It is expected for `compare-sizes` workflow to fail in this PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 18:19:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#24934
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?