github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #6054] [MERGED] Select the user's current country as default when opening bank sync, instead of no value (uses browser timezone/locale) #24907

New Issue
Closed
opened 2026-04-16 18:17:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 18:17:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6054
Author: @henricook
Created: 11/2/2025
Status: ✅ Merged
Merged: 11/5/2025
Merged by: @matt-fidd

Base: master ← Head: auto-country

📝 Commits (1)

  • eb53b5f Select the user's current country as default when opening bank sync, instead of no value (uses browser locale)

📊 Changes

4 files changed (+291 additions, -1 deletions)

View changed files

➕ packages/desktop-client/src/components/modals/GoCardlessExternalMsgModal.test.tsx (+138 -0)
📝 packages/desktop-client/src/components/modals/GoCardlessExternalMsgModal.tsx (+13 -1)
➕ packages/desktop-client/src/components/util/localeToCountry.ts (+134 -0)
➕ upcoming-release-notes/6054.md (+6 -0)

📄 Description

As a UK user I have to setup Bank Sync again every 90 days and an extremely minor annoyance (but one that I thought I'd fix!) is having to select my country each time. I assert here that a default country selection of the user's current country (based on Timezone/Locale) is more helpful than an empty default.

Timezone/Locale's obviously not a direct analog for country but even if it's wrong for someone who regularly selects a country that's not the one they're accessing from, it's still more helpful than an empty default and the same amount of work to select otherwise.

Let me know what you think! I could go deeper on this and have the system remember the last country the user selected perhaps?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6054 **Author:** [@henricook](https://github.com/henricook) **Created:** 11/2/2025 **Status:** ✅ Merged **Merged:** 11/5/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `auto-country` --- ### 📝 Commits (1) - [`eb53b5f`](https://github.com/actualbudget/actual/commit/eb53b5feb3737299f39ccac89e3bd799328393cc) Select the user's current country as default when opening bank sync, instead of no value (uses browser locale) ### 📊 Changes **4 files changed** (+291 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `packages/desktop-client/src/components/modals/GoCardlessExternalMsgModal.test.tsx` (+138 -0) 📝 `packages/desktop-client/src/components/modals/GoCardlessExternalMsgModal.tsx` (+13 -1) ➕ `packages/desktop-client/src/components/util/localeToCountry.ts` (+134 -0) ➕ `upcoming-release-notes/6054.md` (+6 -0) </details> ### 📄 Description As a UK user I have to setup Bank Sync again every 90 days and an extremely minor annoyance (but one that I thought I'd fix!) is having to select my country each time. I assert here that a default country selection of the user's current country (based on Timezone/Locale) is more helpful than an empty default. Timezone/Locale's obviously not a direct analog for country but even if it's wrong for someone who regularly selects a country that's not the one they're accessing from, it's still more helpful than an empty default and the same amount of work to select otherwise. Let me know what you think! I could go deeper on this and have the system remember the last country the user selected perhaps? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 18:17:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#24907
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?