github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[Bug]: O(n*m) behavior in useDisplayPayee #2489

New Issue
Closed
opened 2026-02-28 20:15:40 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-02-28 20:15:40 -06:00
Owner
Copy Link

Originally created by @thromer on GitHub (Sep 20, 2025).

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

I used Chrome dev tools to profile the app when switching between accounts in a budget with a 8000+ payees and two accounts with 1000+ transactions. CPU spikes to over 100% for over 30s. The profile showed a significant amount of time in useDisplayPayee, which calls usePayee, which in turn calls payees.find. So I think performance is O(m*n) in the number of transactions and payees.

I expect changing PayeeState.payees in payeesSlice.ts from a PayeeEntity[] to a Map<string, PayeeEntity> would improve things. I can put together a PR, which will involve a little surgery to update all the existing uses of payees in desktop-client.

Let me know if I'm off track. I'm an infrastructure engineer by trade, not a React/Redux engineer!

How can we reproduce the issue?

See above.

Where are you hosting Actual?

Locally via Yarn

What browsers are you seeing the problem on?

Chrome

Operating System

Linux

Originally created by @thromer on GitHub (Sep 20, 2025). ### Verified issue does not already exist? - [x] I have searched and found no existing issue ### What happened? I used Chrome dev tools to profile the app when switching between accounts in a budget with a 8000+ payees and two accounts with 1000+ transactions. CPU spikes to over 100% for over 30s. The profile showed a significant amount of time in [`useDisplayPayee`](https://github.com/actualbudget/actual/blob/master/packages/desktop-client/src/hooks/useDisplayPayee.ts#L26), which calls [`usePayee`](https://github.com/actualbudget/actual/blob/master/packages/desktop-client/src/hooks/usePayee.ts), which in turn calls `payees.find`. So I think performance is O(m*n) in the number of transactions and payees. I expect changing `PayeeState.payees` in [`payeesSlice.ts`](https://github.com/actualbudget/actual/blob/master/packages/desktop-client/src/payees/payeesSlice.ts) from a `PayeeEntity[]` to a `Map<string, PayeeEntity>` would improve things. I can put together a PR, which will involve a little surgery to update all the existing uses of `payees` in `desktop-client`. Let me know if I'm off track. I'm an infrastructure engineer by trade, not a React/Redux engineer! ### How can we reproduce the issue? See above. ### Where are you hosting Actual? Locally via Yarn ### What browsers are you seeing the problem on? Chrome ### Operating System Linux
GiteaMirror added the user interfacebug labels 2026-02-28 20:15:40 -06:00
GiteaMirror commented 2026-02-28 20:15:41 -06:00
Author
Owner
Copy Link

@thromer commented on GitHub (Sep 21, 2025):

With #5761, switching between the 2 accounts is noticeably more responsive and the spike in CPU is single digit seconds.

@thromer commented on GitHub (Sep 21, 2025): With #5761, switching between the 2 accounts is noticeably more responsive and the spike in CPU is single digit seconds.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug user interface
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#2489
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?