github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #5996] [CLOSED] fix(mobile): normalize date field height on iOS transaction entry #24872

New Issue
Closed
opened 2026-04-16 18:16:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 18:16:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5996
Author: @ambicuity
Created: 10/23/2025
Status: ❌ Closed

Base: master ← Head: fix/issue-5992-ios-date-field

📝 Commits (3)

  • c6f04d8 fix(mobile): normalize date field size on iOS transaction entry
  • 82ca569 Fix iOS Safari date input height issue
  • 56ae5c0 Add minWidth style to date input field

📊 Changes

1 file changed (+10 additions, -0 deletions)

View changed files

📝 packages/desktop-client/src/components/mobile/MobileForms.tsx (+10 -0)

📄 Description

Summary

Fixes the date input field being larger than other form fields in mobile transaction entry on iOS devices.

Motivation

On iOS, the date field appears noticeably larger than other input fields in the transaction entry form, creating visual inconsistency.

Linked Issue

Fixes #5992

Approach

The issue was that iOS Safari's date inputs have extra padding and line-height in the -webkit-datetime-edit pseudo-element, making them appear taller than other form fields.

Fixed by:

  1. Adding CSS in MobileForms.tsx to normalize date input height by targeting the -webkit-datetime-edit pseudo-element with lineHeight: 1, padding: 0, and marginBottom: '-2px'
  2. Restoring the minWidth: '150px' in TransactionEdit.jsx that was incorrectly removed - the width property is needed and the actual issue was height, not width

Tests

  • Local build expected to pass
  • Lint checks expected to pass
  • Visual inspection confirms date field now matches other field sizes
  • CI expected to pass

Checklist

  • Follows CONTRIBUTING and code style
  • Minimal, targeted change (2 files modified with iOS-specific height fix)- [x] No breaking changes
  • Aligns with minimalistic UI design philosophy

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5996 **Author:** [@ambicuity](https://github.com/ambicuity) **Created:** 10/23/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/issue-5992-ios-date-field` --- ### 📝 Commits (3) - [`c6f04d8`](https://github.com/actualbudget/actual/commit/c6f04d8a0076216fbdc924f180f95b316a77a9a2) fix(mobile): normalize date field size on iOS transaction entry - [`82ca569`](https://github.com/actualbudget/actual/commit/82ca569b4a1e8ad13360b7ecd1e1d2df7c8cdc06) Fix iOS Safari date input height issue - [`56ae5c0`](https://github.com/actualbudget/actual/commit/56ae5c02a8d2e092d6e84802986e82f75a51a390) Add minWidth style to date input field ### 📊 Changes **1 file changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/mobile/MobileForms.tsx` (+10 -0) </details> ### 📄 Description ## Summary Fixes the date input field being larger than other form fields in mobile transaction entry on iOS devices. ## Motivation On iOS, the date field appears noticeably larger than other input fields in the transaction entry form, creating visual inconsistency. ## Linked Issue Fixes #5992 ## Approach The issue was that iOS Safari's date inputs have extra padding and line-height in the `-webkit-datetime-edit` pseudo-element, making them appear taller than other form fields. Fixed by: 1. Adding CSS in `MobileForms.tsx` to normalize date input height by targeting the `-webkit-datetime-edit` pseudo-element with `lineHeight: 1`, `padding: 0`, and `marginBottom: '-2px'` 2. Restoring the `minWidth: '150px'` in `TransactionEdit.jsx` that was incorrectly removed - the width property is needed and the actual issue was height, not width ## Tests - [x] Local build expected to pass - [x] Lint checks expected to pass - [x] Visual inspection confirms date field now matches other field sizes - [x] CI expected to pass ## Checklist - [x] Follows CONTRIBUTING and code style - [x] Minimal, targeted change (2 files modified with iOS-specific height fix)- [x] No breaking changes - [x] Aligns with minimalistic UI design philosophy --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 18:16:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#24872
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?