[PR #5905] [MERGED] Create e2e tests for mobile payees page #24811

Closed
opened 2026-04-16 18:14:39 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5905
Author: @MatissJanis
Created: 10/11/2025
Status: Merged
Merged: 10/13/2025
Merged by: @MatissJanis

Base: masterHead: cursor/create-e2e-tests-for-mobile-payees-page-4750


📝 Commits (10+)

  • 081e08a feat: Add mobile payees page and tests
  • 24c028a Remove redundant payee tests
  • 8e7a446 Remove mobile payees page and tests
  • 721dcf4 feat: Add mobile payees page and tests
  • 9101803 Remove redundant payee tests from mobile e2e suite
  • 0ce11b1 Update VRT
  • b3cf108 Checkpoint before follow-up message
  • 3dcc72e Remove redundant screenshot from mobile payees test
  • e4fdacf Merge branch 'cursor/create-e2e-tests-for-mobile-payees-page-4750' of https://github.com/actualbudget/actual into cursor/create-e2e-tests-for-mobile-payees-page-4750
  • ab8baa1 Refactor mobile payees tests to improve loading checks and visual regression testing. Removed redundant screenshot tests and updated existing ones for better accuracy.

📊 Changes

23 files changed (+203 additions, -22 deletions)

View changed files

📝 packages/desktop-client/e2e/page-models/mobile-navigation.ts (+9 -0)
packages/desktop-client/e2e/page-models/mobile-payees-page.ts (+75 -0)
📝 packages/desktop-client/e2e/page-models/mobile-rules-page.ts (+0 -22)
packages/desktop-client/e2e/payees.mobile.test.ts (+112 -0)
packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-checks-the-page-visuals-1-chromium-linux.png (+0 -0)
packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-checks-the-page-visuals-2-chromium-linux.png (+0 -0)
packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-checks-the-page-visuals-3-chromium-linux.png (+0 -0)
packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-clicking-on-a-payee-opens-rule-creation-form-1-chromium-linux.png (+0 -0)
packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-clicking-on-a-payee-opens-rule-creation-form-2-chromium-linux.png (+0 -0)
packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-clicking-on-a-payee-opens-rule-creation-form-3-chromium-linux.png (+0 -0)
packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-filters-out-unrelated-payees-1-chromium-linux.png (+0 -0)
packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-filters-out-unrelated-payees-2-chromium-linux.png (+0 -0)
packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-filters-out-unrelated-payees-3-chromium-linux.png (+0 -0)
packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-page-handles-empty-state-gracefully-1-chromium-linux.png (+0 -0)
packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-page-handles-empty-state-gracefully-2-chromium-linux.png (+0 -0)
packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-page-handles-empty-state-gracefully-3-chromium-linux.png (+0 -0)
packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-1-chromium-linux.png (+0 -0)
packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-2-chromium-linux.png (+0 -0)
packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-3-chromium-linux.png (+0 -0)
packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-4-chromium-linux.png (+0 -0)

...and 3 more files

📄 Description

Description

This PR introduces comprehensive end-to-end (E2E) tests for the mobile payees page.

Why these changes?
To ensure the mobile payees page functions correctly and maintains visual consistency across different themes and interactions. These tests mirror the structure and patterns of the existing mobile rules page E2E tests, providing robust coverage for a critical mobile feature.

What's included?

  • A new MobilePayeesPage page model and an E2E test suite (payees.mobile.test.ts) covering navigation, search, payee interaction, and visual regression checks.
  • MobileNavigation was updated to include a goToPayeesPage method.

Open in Cursor Open in Web


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5905 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 10/11/2025 **Status:** ✅ Merged **Merged:** 10/13/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `cursor/create-e2e-tests-for-mobile-payees-page-4750` --- ### 📝 Commits (10+) - [`081e08a`](https://github.com/actualbudget/actual/commit/081e08a8bbf8207703ed572b813da61803fab701) feat: Add mobile payees page and tests - [`24c028a`](https://github.com/actualbudget/actual/commit/24c028a308463657d0ada11456f32e3d96206a21) Remove redundant payee tests - [`8e7a446`](https://github.com/actualbudget/actual/commit/8e7a44680df0e507b93a08abe0c0c9c6b6c742aa) Remove mobile payees page and tests - [`721dcf4`](https://github.com/actualbudget/actual/commit/721dcf4350db5210b2c32aed538a283800a65f41) feat: Add mobile payees page and tests - [`9101803`](https://github.com/actualbudget/actual/commit/910180366078324d25150710ced3deca2f789023) Remove redundant payee tests from mobile e2e suite - [`0ce11b1`](https://github.com/actualbudget/actual/commit/0ce11b1ec3d63b8aa9467e3199fe8e90b001a8a9) Update VRT - [`b3cf108`](https://github.com/actualbudget/actual/commit/b3cf108c4276bec5a50fbe59181d9c3fe8b83968) Checkpoint before follow-up message - [`3dcc72e`](https://github.com/actualbudget/actual/commit/3dcc72e81c90219782c5d6e9a4ba56cc6630e6f9) Remove redundant screenshot from mobile payees test - [`e4fdacf`](https://github.com/actualbudget/actual/commit/e4fdacf698c5f97e4aab5f2f80f38c51aa28c7b7) Merge branch 'cursor/create-e2e-tests-for-mobile-payees-page-4750' of https://github.com/actualbudget/actual into cursor/create-e2e-tests-for-mobile-payees-page-4750 - [`ab8baa1`](https://github.com/actualbudget/actual/commit/ab8baa1cf08173624781384cb4f7fe79453ca656) Refactor mobile payees tests to improve loading checks and visual regression testing. Removed redundant screenshot tests and updated existing ones for better accuracy. ### 📊 Changes **23 files changed** (+203 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/page-models/mobile-navigation.ts` (+9 -0) ➕ `packages/desktop-client/e2e/page-models/mobile-payees-page.ts` (+75 -0) 📝 `packages/desktop-client/e2e/page-models/mobile-rules-page.ts` (+0 -22) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts` (+112 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-checks-the-page-visuals-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-checks-the-page-visuals-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-checks-the-page-visuals-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-clicking-on-a-payee-opens-rule-creation-form-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-clicking-on-a-payee-opens-rule-creation-form-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-clicking-on-a-payee-opens-rule-creation-form-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-filters-out-unrelated-payees-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-filters-out-unrelated-payees-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-filters-out-unrelated-payees-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-page-handles-empty-state-gracefully-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-page-handles-empty-state-gracefully-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-page-handles-empty-state-gracefully-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-4-chromium-linux.png` (+0 -0) _...and 3 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ### Description This PR introduces comprehensive end-to-end (E2E) tests for the mobile payees page. **Why these changes?** To ensure the mobile payees page functions correctly and maintains visual consistency across different themes and interactions. These tests mirror the structure and patterns of the existing mobile rules page E2E tests, providing robust coverage for a critical mobile feature. **What's included?** - A new `MobilePayeesPage` page model and an E2E test suite (`payees.mobile.test.ts`) covering navigation, search, payee interaction, and visual regression checks. - `MobileNavigation` was updated to include a `goToPayeesPage` method. --- <a href="https://cursor.com/background-agent?bcId=bc-cc7e9c6f-7629-45d8-9934-0bfee737ae5a"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-cc7e9c6f-7629-45d8-9934-0bfee737ae5a"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 18:14:39 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#24811